From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: "Stojaczyk, DariuszX" <dariuszx.stojaczyk@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area
Date: Fri, 1 Jun 2018 15:59:42 +0100 [thread overview]
Message-ID: <4ef183de-b569-efa7-f9a7-17593c4ab5b4@intel.com> (raw)
In-Reply-To: <FBE7E039FA50BF47A673AD0BD3CD56A846142C02@HASMSX105.ger.corp.intel.com>
>> Page size shouldn't be zero, should be alloc_sz.
>
> The 0 above is for the `flags` parameter. Page size is set to alloc_sz.
>
> ```
> void *
> eal_get_virtual_area(void *requested_addr, size_t *size,
> size_t page_sz, int flags, int mmap_flags);
> ```
>
> I believe it's okay. Correct me if I'm wrong.
Apologies, you're right. I misread the code.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-06-01 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 12:51 [PATCH 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area Dariusz Stojaczyk
2018-06-01 11:00 ` Burakov, Anatoly
2018-06-01 12:22 ` Stojaczyk, DariuszX
2018-06-01 14:59 ` Burakov, Anatoly [this message]
2018-06-01 12:51 ` [PATCH 2/2] memalloc: keep in mind a failed MAP_FIXED mmap may still perform an unmap Dariusz Stojaczyk
2018-06-01 11:08 ` Burakov, Anatoly
2018-06-01 12:41 ` Stojaczyk, DariuszX
2018-06-01 13:37 ` [PATCH 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area Dariusz Stojaczyk
2018-06-01 13:39 ` [PATCH v2 " Dariusz Stojaczyk
2018-06-01 10:24 ` Stojaczyk, DariuszX
2018-06-01 11:14 ` Burakov, Anatoly
2018-06-01 12:59 ` [PATCH v3 " Dariusz Stojaczyk
2018-06-01 12:59 ` [PATCH v3 2/2] memalloc: keep in mind a failed MAP_FIXED mmap may still perform an unmap Dariusz Stojaczyk
2018-06-01 15:07 ` Burakov, Anatoly
2018-06-01 15:06 ` [PATCH v3 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area Burakov, Anatoly
2018-07-12 21:42 ` [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ef183de-b569-efa7-f9a7-17593c4ab5b4@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.