From: John Garry <john.garry@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nvme <linux-nvme@lists.infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<iommu@lists.linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>, <chaitanya.kulkarni@wdc.com>
Subject: Re: nvme crash - Re: linux-next: Tree for Aug 13
Date: Fri, 14 Aug 2020 14:37:52 +0100 [thread overview]
Message-ID: <4f01dd86-62da-84bd-0ae4-7e31b5484514@huawei.com> (raw)
In-Reply-To: <895b0c2f-52eb-bd72-7cbf-aa6808c018d2@huawei.com>
On 14/08/2020 14:07, John Garry wrote:
>
> BTW, as for the DMA/sg scatterlist code, it so happens in this case that
> we try the dma alloc for size=0 in nvme_alloc_queue() - I know an
> allocation for size=0 makes no sense, but couldn't we bit a bit more
> robust?
it's giving ZERO_SIZE_PTR, which we deference, so ignore me...
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
chaitanya.kulkarni@wdc.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>,
iommu@lists.linux-foundation.org,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: nvme crash - Re: linux-next: Tree for Aug 13
Date: Fri, 14 Aug 2020 14:37:52 +0100 [thread overview]
Message-ID: <4f01dd86-62da-84bd-0ae4-7e31b5484514@huawei.com> (raw)
In-Reply-To: <895b0c2f-52eb-bd72-7cbf-aa6808c018d2@huawei.com>
On 14/08/2020 14:07, John Garry wrote:
>
> BTW, as for the DMA/sg scatterlist code, it so happens in this case that
> we try the dma alloc for size=0 in nvme_alloc_queue() - I know an
> allocation for size=0 makes no sense, but couldn't we bit a bit more
> robust?
it's giving ZERO_SIZE_PTR, which we deference, so ignore me...
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
chaitanya.kulkarni@wdc.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>,
iommu@lists.linux-foundation.org,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: nvme crash - Re: linux-next: Tree for Aug 13
Date: Fri, 14 Aug 2020 14:37:52 +0100 [thread overview]
Message-ID: <4f01dd86-62da-84bd-0ae4-7e31b5484514@huawei.com> (raw)
In-Reply-To: <895b0c2f-52eb-bd72-7cbf-aa6808c018d2@huawei.com>
On 14/08/2020 14:07, John Garry wrote:
>
> BTW, as for the DMA/sg scatterlist code, it so happens in this case that
> we try the dma alloc for size=0 in nvme_alloc_queue() - I know an
> allocation for size=0 makes no sense, but couldn't we bit a bit more
> robust?
it's giving ZERO_SIZE_PTR, which we deference, so ignore me...
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-08-14 13:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 6:58 linux-next: Tree for Aug 13 Stephen Rothwell
2020-08-13 11:00 ` nvme crash - " John Garry
2020-08-13 11:00 ` John Garry
2020-08-13 15:50 ` Christoph Hellwig
2020-08-13 15:50 ` Christoph Hellwig
2020-08-13 15:50 ` Christoph Hellwig
2020-08-14 12:00 ` John Garry
2020-08-14 12:00 ` John Garry
2020-08-14 12:00 ` John Garry
2020-08-14 12:08 ` Christoph Hellwig
2020-08-14 12:08 ` Christoph Hellwig
2020-08-14 12:08 ` Christoph Hellwig
2020-08-14 13:07 ` John Garry
2020-08-14 13:07 ` John Garry
2020-08-14 13:07 ` John Garry
2020-08-14 13:37 ` John Garry [this message]
2020-08-14 13:37 ` John Garry
2020-08-14 13:37 ` John Garry
2020-08-13 14:41 ` linux-next: Tree for Aug 13 [drivers/staging/vc04_services/bcm2835-camera/] Randy Dunlap
2020-08-13 14:41 ` Randy Dunlap
2020-08-13 18:35 ` linux-next: Tree for Aug 13 (drivers/media/i2c/max9286.c) Randy Dunlap
2020-08-13 19:01 ` Kieran Bingham
2020-08-13 21:55 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f01dd86-62da-84bd-0ae4-7e31b5484514@huawei.com \
--to=john.garry@huawei.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.