All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Johannes Thumshirn <jthumshirn@suse.de>,
	Christoph Hellwig <hch@lst.de>,
	Keith Busch <keith.busch@intel.com>
Cc: Hannes Reinecke <hare@suse.de>,
	maxg@mellanox.com,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list
Date: Fri, 2 Jun 2017 16:46:40 +0300	[thread overview]
Message-ID: <4f03d4c0-6f7b-dbc4-b0ee-bebe77e80ea6@grimberg.me> (raw)
In-Reply-To: <20170602094536.25775-4-jthumshirn@suse.de>


>  	switch (type) {
>  	case NVME_NQN_NVME:
> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
> index cfc5c7fb0ab7..4c6cb5ea1186 100644
> --- a/drivers/nvme/target/nvmet.h
> +++ b/drivers/nvme/target/nvmet.h
> @@ -46,6 +46,7 @@ struct nvmet_ns {
>  	u32			blksize_shift;
>  	loff_t			size;
>  	u8			nguid[16];
> +	uuid_be			uuid;

This should be uuid_le to match the rest of NVMe.

Also, it would be useful to generate a random default with uuid_le_gen()
for a better out-of-the-box experience.

WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH v3 3/8] nvmet: implement namespace identify descriptor list
Date: Fri, 2 Jun 2017 16:46:40 +0300	[thread overview]
Message-ID: <4f03d4c0-6f7b-dbc4-b0ee-bebe77e80ea6@grimberg.me> (raw)
In-Reply-To: <20170602094536.25775-4-jthumshirn@suse.de>


>  	switch (type) {
>  	case NVME_NQN_NVME:
> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
> index cfc5c7fb0ab7..4c6cb5ea1186 100644
> --- a/drivers/nvme/target/nvmet.h
> +++ b/drivers/nvme/target/nvmet.h
> @@ -46,6 +46,7 @@ struct nvmet_ns {
>  	u32			blksize_shift;
>  	loff_t			size;
>  	u8			nguid[16];
> +	uuid_be			uuid;

This should be uuid_le to match the rest of NVMe.

Also, it would be useful to generate a random default with uuid_le_gen()
for a better out-of-the-box experience.

  reply	other threads:[~2017-06-02 13:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02  9:45 [PATCH v3 0/8] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-06-02  9:45 ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 2/8] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 3/8] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn
2017-06-02 13:46   ` Sagi Grimberg [this message]
2017-06-02 13:46     ` Sagi Grimberg
2017-06-02 13:54     ` Johannes Thumshirn
2017-06-02 13:54       ` Johannes Thumshirn
2017-06-03  5:18     ` Christoph Hellwig
2017-06-03  5:18       ` Christoph Hellwig
2017-06-03  8:03       ` Sagi Grimberg
2017-06-03  8:03         ` Sagi Grimberg
2017-06-05  5:31   ` Christoph Hellwig
2017-06-05  5:31     ` Christoph Hellwig
2017-06-06  7:17     ` Johannes Thumshirn
2017-06-06  7:17       ` Johannes Thumshirn
2017-06-06  7:19       ` Christoph Hellwig
2017-06-06  7:19         ` Christoph Hellwig
2017-06-06  7:20         ` Johannes Thumshirn
2017-06-06  7:20           ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 4/8] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 5/8] nvme: get list of namespace descriptors Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 6/8] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 7/8] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn
2017-06-02  9:45 ` [PATCH v3 8/8] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn
2017-06-02  9:45   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f03d4c0-6f7b-dbc4-b0ee-bebe77e80ea6@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=maxg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.