[PATCH] arm/vgic: Fix reference to a non-existing function

[PATCH] arm/vgic: Fix reference to a non-existing function

[Michal Orzel]

Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
(xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
forgot to modify a comment about lr_pending list,
referring to a function that has been renamed.
Fix that.

Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/include/asm-arm/vgic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index e69a59063a..ade427a808 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -195,7 +195,7 @@ struct vgic_cpu {
      * corresponding LR it is also removed from this list. */
     struct list_head inflight_irqs;
     /* lr_pending is used to queue IRQs (struct pending_irq) that the
-     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
+     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
      * no LRs were available at the time.
      * As soon as an LR is freed we remove the first IRQ from this
      * list and write it to the LR register.
-- 
2.29.0

Re: [PATCH] arm/vgic: Fix reference to a non-existing function

[Bertrand Marquis]

Hi Michal,

> On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@arm.com> wrote:
> 
> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
> forgot to modify a comment about lr_pending list,
> referring to a function that has been renamed.
> Fix that.
> 
> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Thanks for that

Cheers
Bertrand

> ---
> xen/include/asm-arm/vgic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index e69a59063a..ade427a808 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -195,7 +195,7 @@ struct vgic_cpu {
>      * corresponding LR it is also removed from this list. */
>     struct list_head inflight_irqs;
>     /* lr_pending is used to queue IRQs (struct pending_irq) that the
> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>      * no LRs were available at the time.
>      * As soon as an LR is freed we remove the first IRQ from this
>      * list and write it to the LR register.
> -- 
> 2.29.0
> 

Re: [PATCH] arm/vgic: Fix reference to a non-existing function

[Ayan Kumar Halder]

On 03/12/2021 10:19, Bertrand Marquis wrote:
> Hi Michal,
> 
>> On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@arm.com> wrote:
>>
>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>> forgot to modify a comment about lr_pending list,
>> referring to a function that has been renamed.
>> Fix that.
>>
>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Bertrand is very fast. :D.
I wanted to check if it is ok to add my R-b.
> 
> Thanks for that
> 
> Cheers
> Bertrand
> 
>> ---
>> xen/include/asm-arm/vgic.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>> index e69a59063a..ade427a808 100644
>> --- a/xen/include/asm-arm/vgic.h
>> +++ b/xen/include/asm-arm/vgic.h
>> @@ -195,7 +195,7 @@ struct vgic_cpu {
>>       * corresponding LR it is also removed from this list. */
>>      struct list_head inflight_irqs;
>>      /* lr_pending is used to queue IRQs (struct pending_irq) that the
>> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
>> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>>       * no LRs were available at the time.
>>       * As soon as an LR is freed we remove the first IRQ from this
>>       * list and write it to the LR register.
>> -- 
>> 2.29.0
>>
> 
> 

Re: [PATCH] arm/vgic: Fix reference to a non-existing function

[Bertrand Marquis]

Hi Ayan,

> On 3 Dec 2021, at 11:23, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
> 
> 
> 
> On 03/12/2021 10:19, Bertrand Marquis wrote:
>> Hi Michal,
>>> On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@arm.com> wrote:
>>> 
>>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>>> forgot to modify a comment about lr_pending list,
>>> referring to a function that has been renamed.
>>> Fix that.
>>> 
>>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> 
> Bertrand is very fast. :D.

To be fare we are working together with Michal ;-)

> I wanted to check if it is ok to add my R-b.

It is always ok and welcome if you feel you understood and check the change and it is ok for you :-)
There is never enough reviewers.

Cheers
Bertrand

>> Thanks for that
>> Cheers
>> Bertrand
>>> ---
>>> xen/include/asm-arm/vgic.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>>> index e69a59063a..ade427a808 100644
>>> --- a/xen/include/asm-arm/vgic.h
>>> +++ b/xen/include/asm-arm/vgic.h
>>> @@ -195,7 +195,7 @@ struct vgic_cpu {
>>>      * corresponding LR it is also removed from this list. */
>>>     struct list_head inflight_irqs;
>>>     /* lr_pending is used to queue IRQs (struct pending_irq) that the
>>> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
>>> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>>>      * no LRs were available at the time.
>>>      * As soon as an LR is freed we remove the first IRQ from this
>>>      * list and write it to the LR register.
>>> -- 
>>> 2.29.0
>>> 

Re: [PATCH] arm/vgic: Fix reference to a non-existing function

[Julien Grall]

Hi Michal,

On 03/12/2021 09:58, Michal Orzel wrote:
> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
> forgot to modify a comment about lr_pending list,
> referring to a function that has been renamed.
> Fix that.
> 
> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84

The format for fixes tag is a 12 characters sha1 followed by the commit 
message. In this case, it would be:

Fixes: 68dcdf942326 ("xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq")

I can fix it on commit.

Acked-by: Julien Grall <jgrall@amazon.com>

> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
>   xen/include/asm-arm/vgic.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index e69a59063a..ade427a808 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -195,7 +195,7 @@ struct vgic_cpu {
>        * corresponding LR it is also removed from this list. */
>       struct list_head inflight_irqs;
>       /* lr_pending is used to queue IRQs (struct pending_irq) that the
> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>        * no LRs were available at the time.
>        * As soon as an LR is freed we remove the first IRQ from this
>        * list and write it to the LR register.
> 

Cheers,

-- 
Julien Grall

Re: [PATCH] arm/vgic: Fix reference to a non-existing function

[Michal Orzel]

Hi Julien,

On 03.12.2021 13:05, Julien Grall wrote:
> Hi Michal,
> 
> On 03/12/2021 09:58, Michal Orzel wrote:
>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>> forgot to modify a comment about lr_pending list,
>> referring to a function that has been renamed.
>> Fix that.
>>
>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
> 
> The format for fixes tag is a 12 characters sha1 followed by the commit message. In this case, it would be:
> 
> Fixes: 68dcdf942326 ("xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq")
> 
> I can fix it on commit.
Please do. I forgot about this requirement.
> 
> Acked-by: Julien Grall <jgrall@amazon.com>
> 
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> ---
>>   xen/include/asm-arm/vgic.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>> index e69a59063a..ade427a808 100644
>> --- a/xen/include/asm-arm/vgic.h
>> +++ b/xen/include/asm-arm/vgic.h
>> @@ -195,7 +195,7 @@ struct vgic_cpu {
>>        * corresponding LR it is also removed from this list. */
>>       struct list_head inflight_irqs;
>>       /* lr_pending is used to queue IRQs (struct pending_irq) that the
>> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
>> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>>        * no LRs were available at the time.
>>        * As soon as an LR is freed we remove the first IRQ from this
>>        * list and write it to the LR register.
>>
> 
> Cheers,
> 
Cheers,
Michal

Re: [PATCH] arm/vgic: Fix reference to a non-existing function

[Julien Grall]

On 03/12/2021 12:08, Michal Orzel wrote:
> On 03.12.2021 13:05, Julien Grall wrote:
>> Hi Michal,
>>
>> On 03/12/2021 09:58, Michal Orzel wrote:
>>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>>> forgot to modify a comment about lr_pending list,
>>> referring to a function that has been renamed.
>>> Fix that.
>>>
>>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
>>
>> The format for fixes tag is a 12 characters sha1 followed by the commit message. In this case, it would be:
>>
>> Fixes: 68dcdf942326 ("xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq") >>
>> I can fix it on commit.
> Please do. I forgot about this requirement.

Done and committed. I have also re-wrapped the commit message to 72 
characters rather than 50-characters.

-- 
Julien Grall