[Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer

[Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer

[Anthoine Bourgeois]

From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>

The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."

Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
---
 ui/gtk-gl-area.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298f..026b7d7 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
 
     gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
 
-    if (vc->gfx.guest_fb.framebuffer  == 0 ||
-        vc->gfx.w == 0 || vc->gfx.h == 0) {
+    if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
         gtk_gl_area_set_scanout_mode(vc, false);
         return;
     }
-- 
2.9.3

Re: [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer

[Philippe Mathieu-Daudé]

Hi Anthoine,

Cc'ing Gerd Hoffmann who is the maintainer of this file.

See
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer:

$ ./scripts/get_maintainer.pl -f ui/gtk-gl-area.c
Gerd Hoffmann <kraxel@redhat.com> (odd fixer:Graphics)

On 10/02/2017 09:40 AM, Anthoine Bourgeois wrote:
> From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
> 
> The gd_gl_area_scanout_texture must destroy framebuffer if there is
> no texture id instead of no framebuffer id.
> The effect was a black screen with "-vga virtio -display gtk,gl=on"
> options.
> The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
> 
> Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
> ---
>  ui/gtk-gl-area.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
> index 18b298f..026b7d7 100644
> --- a/ui/gtk-gl-area.c
> +++ b/ui/gtk-gl-area.c
> @@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
>  
>      gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
>  
> -    if (vc->gfx.guest_fb.framebuffer  == 0 ||
> -        vc->gfx.w == 0 || vc->gfx.h == 0) {
> +    if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
>          gtk_gl_area_set_scanout_mode(vc, false);
>          return;
>      }
> 

[Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer

[Anthoine Bourgeois]

The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."

Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
---
 ui/gtk-gl-area.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298f..026b7d7 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
 
     gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
 
-    if (vc->gfx.guest_fb.framebuffer  == 0 ||
-        vc->gfx.w == 0 || vc->gfx.h == 0) {
+    if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
         gtk_gl_area_set_scanout_mode(vc, false);
         return;
     }
-- 
2.9.3

[Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer

[Anthoine Bourgeois]

From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>

The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."

Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
---
 ui/gtk-gl-area.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 18b298f..026b7d7 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
 
     gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
 
-    if (vc->gfx.guest_fb.framebuffer  == 0 ||
-        vc->gfx.w == 0 || vc->gfx.h == 0) {
+    if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
         gtk_gl_area_set_scanout_mode(vc, false);
         return;
     }
-- 
2.9.3