* [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-28 14:37 ` AdityaXavier
0 siblings, 0 replies; 12+ messages in thread
From: AdityaXavier @ 2017-01-28 14:37 UTC (permalink / raw)
To: hauke
Cc: zajec5, bcm-kernel-feedback-list, robh+dt, mark.rutland, linux,
linux-arm-kernel, devicetree, linux-kernel, f.fainelli,
Aditya Xavier
From: Aditya Xavier <adityaxavier@gmail.com>
Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
V2: Updated subject, Power LED names, and WAN labels.
Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
---
arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
index 92f8a72..90d4420 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
@@ -27,18 +27,30 @@
leds {
compatible = "gpio-leds";
- power0 {
+ power-white {
label = "bcm53xx:white:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-off";
};
+ wan-white {
+ label = "bcm53xx:white:wan";
+ gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
+ };
+
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-off";
+ };
+
5ghz-1 {
label = "bcm53xx:white:5ghz-1";
gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
@@ -104,6 +116,12 @@
linux,code = <KEY_RESTART>;
gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
};
+
+ brightness {
+ label = "Backlight";
+ linux,code = <KEY_BRIGHTNESS_ZERO>;
+ gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
+ };
};
};
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-28 14:37 ` AdityaXavier
0 siblings, 0 replies; 12+ messages in thread
From: AdityaXavier @ 2017-01-28 14:37 UTC (permalink / raw)
To: hauke
Cc: mark.rutland, devicetree, f.fainelli, zajec5, linux,
linux-kernel, robh+dt, bcm-kernel-feedback-list, Aditya Xavier,
linux-arm-kernel
From: Aditya Xavier <adityaxavier@gmail.com>
Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
V2: Updated subject, Power LED names, and WAN labels.
Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
---
arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
index 92f8a72..90d4420 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
@@ -27,18 +27,30 @@
leds {
compatible = "gpio-leds";
- power0 {
+ power-white {
label = "bcm53xx:white:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-off";
};
+ wan-white {
+ label = "bcm53xx:white:wan";
+ gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
+ };
+
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-off";
+ };
+
5ghz-1 {
label = "bcm53xx:white:5ghz-1";
gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
@@ -104,6 +116,12 @@
linux,code = <KEY_RESTART>;
gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
};
+
+ brightness {
+ label = "Backlight";
+ linux,code = <KEY_BRIGHTNESS_ZERO>;
+ gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
+ };
};
};
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-28 14:37 ` AdityaXavier
0 siblings, 0 replies; 12+ messages in thread
From: AdityaXavier @ 2017-01-28 14:37 UTC (permalink / raw)
To: linux-arm-kernel
From: Aditya Xavier <adityaxavier@gmail.com>
Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
V2: Updated subject, Power LED names, and WAN labels.
Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
---
arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
index 92f8a72..90d4420 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
@@ -27,18 +27,30 @@
leds {
compatible = "gpio-leds";
- power0 {
+ power-white {
label = "bcm53xx:white:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
linux,default-trigger = "default-off";
};
+ wan-white {
+ label = "bcm53xx:white:wan";
+ gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
+ };
+
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-off";
+ };
+
5ghz-1 {
label = "bcm53xx:white:5ghz-1";
gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
@@ -104,6 +116,12 @@
linux,code = <KEY_RESTART>;
gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
};
+
+ brightness {
+ label = "Backlight";
+ linux,code = <KEY_BRIGHTNESS_ZERO>;
+ gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
+ };
};
};
--
2.9.3
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
2017-01-28 14:37 ` AdityaXavier
(?)
@ 2017-01-28 21:15 ` Rafał Miłecki
-1 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2017-01-28 21:15 UTC (permalink / raw)
To: AdityaXavier
Cc: Hauke Mehrtens, bcm-kernel-feedback-list, Rob Herring,
Mark Rutland, Russell King, linux-arm-kernel, devicetree,
Linux Kernel Mailing List, Florian Fainelli
On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
> From: Aditya Xavier <adityaxavier@gmail.com>
>
> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
> V2: Updated subject, Power LED names, and WAN labels.
Changelog (V2 ... part) should go into that /comments/ section (see below).
Florian: can you drop that line when applying this patch? Otherwise it
looks OK to me.
> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
Thanks for the patch!
> ---
Right here, below these 3 dashes is a place where you can add extra
comments (they won't go into log when doing "git am").
> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> index 92f8a72..90d4420 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> @@ -27,18 +27,30 @@
> leds {
> compatible = "gpio-leds";
>
> - power0 {
> + power-white {
> label = "bcm53xx:white:power";
> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-on";
> };
>
> - power1 {
> + power-amber {
> label = "bcm53xx:amber:power";
> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-off";
> };
>
> + wan-white {
> + label = "bcm53xx:white:wan";
> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> + };
> +
> + wan-amber {
> + label = "bcm53xx:amber:wan";
> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-off";
> + };
> +
> 5ghz-1 {
> label = "bcm53xx:white:5ghz-1";
> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
> @@ -104,6 +116,12 @@
> linux,code = <KEY_RESTART>;
> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
> };
> +
> + brightness {
> + label = "Backlight";
> + linux,code = <KEY_BRIGHTNESS_ZERO>;
> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
> + };
> };
> };
>
> --
> 2.9.3
>
--
Rafał
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-28 21:15 ` Rafał Miłecki
0 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2017-01-28 21:15 UTC (permalink / raw)
To: AdityaXavier
Cc: Mark Rutland, devicetree, Florian Fainelli, Hauke Mehrtens,
Russell King, Linux Kernel Mailing List, Rob Herring,
bcm-kernel-feedback-list, linux-arm-kernel
On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
> From: Aditya Xavier <adityaxavier@gmail.com>
>
> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
> V2: Updated subject, Power LED names, and WAN labels.
Changelog (V2 ... part) should go into that /comments/ section (see below).
Florian: can you drop that line when applying this patch? Otherwise it
looks OK to me.
> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
Thanks for the patch!
> ---
Right here, below these 3 dashes is a place where you can add extra
comments (they won't go into log when doing "git am").
> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> index 92f8a72..90d4420 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> @@ -27,18 +27,30 @@
> leds {
> compatible = "gpio-leds";
>
> - power0 {
> + power-white {
> label = "bcm53xx:white:power";
> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-on";
> };
>
> - power1 {
> + power-amber {
> label = "bcm53xx:amber:power";
> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-off";
> };
>
> + wan-white {
> + label = "bcm53xx:white:wan";
> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> + };
> +
> + wan-amber {
> + label = "bcm53xx:amber:wan";
> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-off";
> + };
> +
> 5ghz-1 {
> label = "bcm53xx:white:5ghz-1";
> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
> @@ -104,6 +116,12 @@
> linux,code = <KEY_RESTART>;
> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
> };
> +
> + brightness {
> + label = "Backlight";
> + linux,code = <KEY_BRIGHTNESS_ZERO>;
> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
> + };
> };
> };
>
> --
> 2.9.3
>
--
Rafał
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-28 21:15 ` Rafał Miłecki
0 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2017-01-28 21:15 UTC (permalink / raw)
To: linux-arm-kernel
On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
> From: Aditya Xavier <adityaxavier@gmail.com>
>
> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
> V2: Updated subject, Power LED names, and WAN labels.
Changelog (V2 ... part) should go into that /comments/ section (see below).
Florian: can you drop that line when applying this patch? Otherwise it
looks OK to me.
> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
Acked-by: Rafa? Mi?ecki <rafal@milecki.pl>
Thanks for the patch!
> ---
Right here, below these 3 dashes is a place where you can add extra
comments (they won't go into log when doing "git am").
> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> index 92f8a72..90d4420 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
> @@ -27,18 +27,30 @@
> leds {
> compatible = "gpio-leds";
>
> - power0 {
> + power-white {
> label = "bcm53xx:white:power";
> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-on";
> };
>
> - power1 {
> + power-amber {
> label = "bcm53xx:amber:power";
> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "default-off";
> };
>
> + wan-white {
> + label = "bcm53xx:white:wan";
> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "default-on";
> + };
> +
> + wan-amber {
> + label = "bcm53xx:amber:wan";
> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-off";
> + };
> +
> 5ghz-1 {
> label = "bcm53xx:white:5ghz-1";
> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
> @@ -104,6 +116,12 @@
> linux,code = <KEY_RESTART>;
> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
> };
> +
> + brightness {
> + label = "Backlight";
> + linux,code = <KEY_BRIGHTNESS_ZERO>;
> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
> + };
> };
> };
>
> --
> 2.9.3
>
--
Rafa?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
2017-01-28 21:15 ` Rafał Miłecki
(?)
@ 2017-01-30 9:08 ` Aditya Xavier
-1 siblings, 0 replies; 12+ messages in thread
From: Aditya Xavier @ 2017-01-30 9:08 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Hauke Mehrtens, bcm-kernel-feedback-list, Rob Herring,
Mark Rutland, Russell King, linux-arm-kernel, devicetree,
Linux Kernel Mailing List, Florian Fainelli
Would you require me to send the revised Patch ?
Or would this do ?
And thanks for guiding me through this process :)
> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>
> On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
>> From: Aditya Xavier <adityaxavier@gmail.com>
>>
>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>> V2: Updated subject, Power LED names, and WAN labels.
>
> Changelog (V2 ... part) should go into that /comments/ section (see below).
> Florian: can you drop that line when applying this patch? Otherwise it
> looks OK to me.
>
>
>> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
>
> Acked-by: Rafał Miłecki <rafal@milecki.pl>
>
> Thanks for the patch!
>
>
>> ---
>
> Right here, below these 3 dashes is a place where you can add extra
> comments (they won't go into log when doing "git am").
>
>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> index 92f8a72..90d4420 100644
>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> @@ -27,18 +27,30 @@
>> leds {
>> compatible = "gpio-leds";
>>
>> - power0 {
>> + power-white {
>> label = "bcm53xx:white:power";
>> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "default-on";
>> };
>>
>> - power1 {
>> + power-amber {
>> label = "bcm53xx:amber:power";
>> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "default-off";
>> };
>>
>> + wan-white {
>> + label = "bcm53xx:white:wan";
>> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
>> + linux,default-trigger = "default-on";
>> + };
>> +
>> + wan-amber {
>> + label = "bcm53xx:amber:wan";
>> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "default-off";
>> + };
>> +
>> 5ghz-1 {
>> label = "bcm53xx:white:5ghz-1";
>> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
>> @@ -104,6 +116,12 @@
>> linux,code = <KEY_RESTART>;
>> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>> };
>> +
>> + brightness {
>> + label = "Backlight";
>> + linux,code = <KEY_BRIGHTNESS_ZERO>;
>> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
>> + };
>> };
>> };
>>
>> --
>> 2.9.3
>>
>
>
>
> --
> Rafał
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-30 9:08 ` Aditya Xavier
0 siblings, 0 replies; 12+ messages in thread
From: Aditya Xavier @ 2017-01-30 9:08 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Hauke Mehrtens, bcm-kernel-feedback-list, Rob Herring,
Mark Rutland, Russell King, linux-arm-kernel, devicetree,
Linux Kernel Mailing List, Florian Fainelli
Would you require me to send the revised Patch ?
Or would this do ?
And thanks for guiding me through this process :)
> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>
> On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
>> From: Aditya Xavier <adityaxavier@gmail.com>
>>
>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>> V2: Updated subject, Power LED names, and WAN labels.
>
> Changelog (V2 ... part) should go into that /comments/ section (see below).
> Florian: can you drop that line when applying this patch? Otherwise it
> looks OK to me.
>
>
>> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
>
> Acked-by: Rafał Miłecki <rafal@milecki.pl>
>
> Thanks for the patch!
>
>
>> ---
>
> Right here, below these 3 dashes is a place where you can add extra
> comments (they won't go into log when doing "git am").
>
>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> index 92f8a72..90d4420 100644
>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> @@ -27,18 +27,30 @@
>> leds {
>> compatible = "gpio-leds";
>>
>> - power0 {
>> + power-white {
>> label = "bcm53xx:white:power";
>> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "default-on";
>> };
>>
>> - power1 {
>> + power-amber {
>> label = "bcm53xx:amber:power";
>> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "default-off";
>> };
>>
>> + wan-white {
>> + label = "bcm53xx:white:wan";
>> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
>> + linux,default-trigger = "default-on";
>> + };
>> +
>> + wan-amber {
>> + label = "bcm53xx:amber:wan";
>> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "default-off";
>> + };
>> +
>> 5ghz-1 {
>> label = "bcm53xx:white:5ghz-1";
>> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
>> @@ -104,6 +116,12 @@
>> linux,code = <KEY_RESTART>;
>> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>> };
>> +
>> + brightness {
>> + label = "Backlight";
>> + linux,code = <KEY_BRIGHTNESS_ZERO>;
>> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
>> + };
>> };
>> };
>>
>> --
>> 2.9.3
>>
>
>
>
> --
> Rafał
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-30 9:08 ` Aditya Xavier
0 siblings, 0 replies; 12+ messages in thread
From: Aditya Xavier @ 2017-01-30 9:08 UTC (permalink / raw)
To: linux-arm-kernel
Would you require me to send the revised Patch ?
Or would this do ?
And thanks for guiding me through this process :)
> On 29-Jan-2017, at 2:45 AM, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
>
> On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
>> From: Aditya Xavier <adityaxavier@gmail.com>
>>
>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>> V2: Updated subject, Power LED names, and WAN labels.
>
> Changelog (V2 ... part) should go into that /comments/ section (see below).
> Florian: can you drop that line when applying this patch? Otherwise it
> looks OK to me.
>
>
>> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
>
> Acked-by: Rafa? Mi?ecki <rafal@milecki.pl>
>
> Thanks for the patch!
>
>
>> ---
>
> Right here, below these 3 dashes is a place where you can add extra
> comments (they won't go into log when doing "git am").
>
>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> index 92f8a72..90d4420 100644
>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>> @@ -27,18 +27,30 @@
>> leds {
>> compatible = "gpio-leds";
>>
>> - power0 {
>> + power-white {
>> label = "bcm53xx:white:power";
>> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "default-on";
>> };
>>
>> - power1 {
>> + power-amber {
>> label = "bcm53xx:amber:power";
>> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>> linux,default-trigger = "default-off";
>> };
>>
>> + wan-white {
>> + label = "bcm53xx:white:wan";
>> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
>> + linux,default-trigger = "default-on";
>> + };
>> +
>> + wan-amber {
>> + label = "bcm53xx:amber:wan";
>> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "default-off";
>> + };
>> +
>> 5ghz-1 {
>> label = "bcm53xx:white:5ghz-1";
>> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
>> @@ -104,6 +116,12 @@
>> linux,code = <KEY_RESTART>;
>> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>> };
>> +
>> + brightness {
>> + label = "Backlight";
>> + linux,code = <KEY_BRIGHTNESS_ZERO>;
>> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
>> + };
>> };
>> };
>>
>> --
>> 2.9.3
>>
>
>
>
> --
> Rafa?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
2017-01-30 9:08 ` Aditya Xavier
(?)
@ 2017-01-30 17:37 ` Florian Fainelli
-1 siblings, 0 replies; 12+ messages in thread
From: Florian Fainelli @ 2017-01-30 17:37 UTC (permalink / raw)
To: Aditya Xavier, Rafał Miłecki
Cc: Hauke Mehrtens, bcm-kernel-feedback-list, Rob Herring,
Mark Rutland, Russell King, linux-arm-kernel, devicetree,
Linux Kernel Mailing List, Florian Fainelli
On 01/30/2017 01:08 AM, Aditya Xavier wrote:
> Would you require me to send the revised Patch ?
>
> Or would this do ?
Will take care of it this time.
>
> And thanks for guiding me through this process :)
>
>
>> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>>
>> On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
>>> From: Aditya Xavier <adityaxavier@gmail.com>
>>>
>>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>>> V2: Updated subject, Power LED names, and WAN labels.
>>
>> Changelog (V2 ... part) should go into that /comments/ section (see below).
>> Florian: can you drop that line when applying this patch? Otherwise it
>> looks OK to me.
>>
>>
>>> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
>>
>> Acked-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> Thanks for the patch!
>>
>>
>>> ---
>>
>> Right here, below these 3 dashes is a place where you can add extra
>> comments (they won't go into log when doing "git am").
>>
>>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> index 92f8a72..90d4420 100644
>>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> @@ -27,18 +27,30 @@
>>> leds {
>>> compatible = "gpio-leds";
>>>
>>> - power0 {
>>> + power-white {
>>> label = "bcm53xx:white:power";
>>> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>>> linux,default-trigger = "default-on";
>>> };
>>>
>>> - power1 {
>>> + power-amber {
>>> label = "bcm53xx:amber:power";
>>> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>>> linux,default-trigger = "default-off";
>>> };
>>>
>>> + wan-white {
>>> + label = "bcm53xx:white:wan";
>>> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
>>> + linux,default-trigger = "default-on";
>>> + };
>>> +
>>> + wan-amber {
>>> + label = "bcm53xx:amber:wan";
>>> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
>>> + linux,default-trigger = "default-off";
>>> + };
>>> +
>>> 5ghz-1 {
>>> label = "bcm53xx:white:5ghz-1";
>>> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
>>> @@ -104,6 +116,12 @@
>>> linux,code = <KEY_RESTART>;
>>> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>>> };
>>> +
>>> + brightness {
>>> + label = "Backlight";
>>> + linux,code = <KEY_BRIGHTNESS_ZERO>;
>>> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
>>> + };
>>> };
>>> };
>>>
>>> --
>>> 2.9.3
>>>
>>
>>
>>
>> --
>> Rafał
>
--
Florian
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-30 17:37 ` Florian Fainelli
0 siblings, 0 replies; 12+ messages in thread
From: Florian Fainelli @ 2017-01-30 17:37 UTC (permalink / raw)
To: Aditya Xavier, Rafał Miłecki
Cc: Mark Rutland, devicetree, Florian Fainelli, Hauke Mehrtens,
Russell King, Linux Kernel Mailing List, Rob Herring,
bcm-kernel-feedback-list, linux-arm-kernel
On 01/30/2017 01:08 AM, Aditya Xavier wrote:
> Would you require me to send the revised Patch ?
>
> Or would this do ?
Will take care of it this time.
>
> And thanks for guiding me through this process :)
>
>
>> On 29-Jan-2017, at 2:45 AM, Rafał Miłecki <zajec5@gmail.com> wrote:
>>
>> On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
>>> From: Aditya Xavier <adityaxavier@gmail.com>
>>>
>>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>>> V2: Updated subject, Power LED names, and WAN labels.
>>
>> Changelog (V2 ... part) should go into that /comments/ section (see below).
>> Florian: can you drop that line when applying this patch? Otherwise it
>> looks OK to me.
>>
>>
>>> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
>>
>> Acked-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> Thanks for the patch!
>>
>>
>>> ---
>>
>> Right here, below these 3 dashes is a place where you can add extra
>> comments (they won't go into log when doing "git am").
>>
>>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> index 92f8a72..90d4420 100644
>>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> @@ -27,18 +27,30 @@
>>> leds {
>>> compatible = "gpio-leds";
>>>
>>> - power0 {
>>> + power-white {
>>> label = "bcm53xx:white:power";
>>> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>>> linux,default-trigger = "default-on";
>>> };
>>>
>>> - power1 {
>>> + power-amber {
>>> label = "bcm53xx:amber:power";
>>> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>>> linux,default-trigger = "default-off";
>>> };
>>>
>>> + wan-white {
>>> + label = "bcm53xx:white:wan";
>>> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
>>> + linux,default-trigger = "default-on";
>>> + };
>>> +
>>> + wan-amber {
>>> + label = "bcm53xx:amber:wan";
>>> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
>>> + linux,default-trigger = "default-off";
>>> + };
>>> +
>>> 5ghz-1 {
>>> label = "bcm53xx:white:5ghz-1";
>>> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
>>> @@ -104,6 +116,12 @@
>>> linux,code = <KEY_RESTART>;
>>> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>>> };
>>> +
>>> + brightness {
>>> + label = "Backlight";
>>> + linux,code = <KEY_BRIGHTNESS_ZERO>;
>>> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
>>> + };
>>> };
>>> };
>>>
>>> --
>>> 2.9.3
>>>
>>
>>
>>
>> --
>> Rafał
>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys
@ 2017-01-30 17:37 ` Florian Fainelli
0 siblings, 0 replies; 12+ messages in thread
From: Florian Fainelli @ 2017-01-30 17:37 UTC (permalink / raw)
To: linux-arm-kernel
On 01/30/2017 01:08 AM, Aditya Xavier wrote:
> Would you require me to send the revised Patch ?
>
> Or would this do ?
Will take care of it this time.
>
> And thanks for guiding me through this process :)
>
>
>> On 29-Jan-2017, at 2:45 AM, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
>>
>> On 28 January 2017 at 15:37, AdityaXavier <adityaxavier@gmail.com> wrote:
>>> From: Aditya Xavier <adityaxavier@gmail.com>
>>>
>>> Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
>>> V2: Updated subject, Power LED names, and WAN labels.
>>
>> Changelog (V2 ... part) should go into that /comments/ section (see below).
>> Florian: can you drop that line when applying this patch? Otherwise it
>> looks OK to me.
>>
>>
>>> Signed-off-by: Aditya Xavier <adityaxavier@gmail.com>
>>
>> Acked-by: Rafa? Mi?ecki <rafal@milecki.pl>
>>
>> Thanks for the patch!
>>
>>
>>> ---
>>
>> Right here, below these 3 dashes is a place where you can add extra
>> comments (they won't go into log when doing "git am").
>>
>>> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
>>> 1 file changed, 20 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> index 92f8a72..90d4420 100644
>>> --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
>>> @@ -27,18 +27,30 @@
>>> leds {
>>> compatible = "gpio-leds";
>>>
>>> - power0 {
>>> + power-white {
>>> label = "bcm53xx:white:power";
>>> gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
>>> linux,default-trigger = "default-on";
>>> };
>>>
>>> - power1 {
>>> + power-amber {
>>> label = "bcm53xx:amber:power";
>>> gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
>>> linux,default-trigger = "default-off";
>>> };
>>>
>>> + wan-white {
>>> + label = "bcm53xx:white:wan";
>>> + gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
>>> + linux,default-trigger = "default-on";
>>> + };
>>> +
>>> + wan-amber {
>>> + label = "bcm53xx:amber:wan";
>>> + gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
>>> + linux,default-trigger = "default-off";
>>> + };
>>> +
>>> 5ghz-1 {
>>> label = "bcm53xx:white:5ghz-1";
>>> gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
>>> @@ -104,6 +116,12 @@
>>> linux,code = <KEY_RESTART>;
>>> gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
>>> };
>>> +
>>> + brightness {
>>> + label = "Backlight";
>>> + linux,code = <KEY_BRIGHTNESS_ZERO>;
>>> + gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
>>> + };
>>> };
>>> };
>>>
>>> --
>>> 2.9.3
>>>
>>
>>
>>
>> --
>> Rafa?
>
--
Florian
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-01-30 17:37 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-28 14:37 [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys AdityaXavier
2017-01-28 14:37 ` AdityaXavier
2017-01-28 14:37 ` AdityaXavier
2017-01-28 21:15 ` Rafał Miłecki
2017-01-28 21:15 ` Rafał Miłecki
2017-01-28 21:15 ` Rafał Miłecki
2017-01-30 9:08 ` Aditya Xavier
2017-01-30 9:08 ` Aditya Xavier
2017-01-30 9:08 ` Aditya Xavier
2017-01-30 17:37 ` Florian Fainelli
2017-01-30 17:37 ` Florian Fainelli
2017-01-30 17:37 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.