All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	Pavel Shilovsky <pshilov-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
	Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
Subject: Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m
Date: Tue, 19 Dec 2017 12:01:19 +0100	[thread overview]
Message-ID: <4f2d6c8d-2958-3eb4-25b3-c789a0e1226d@samba.org> (raw)
In-Reply-To: <CAK8P3a3TQSt8skuyu7uHBbyG_jHS8wUaPPJ1XSh4u+aHxBzN8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]

Am 19.12.2017 um 11:56 schrieb Arnd Bergmann via samba-technical:
> On Tue, Dec 19, 2017 at 11:33 AM, Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
>> Hi Arnd,
>>
>>> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
>>> index 500fd69fb58b..3bfc55c08bef 100644
>>> --- a/fs/cifs/Kconfig
>>> +++ b/fs/cifs/Kconfig
>>> @@ -199,6 +199,7 @@ config CIFS_SMB311
>>>  config CIFS_SMB_DIRECT
>>>       bool "SMB Direct support (Experimental)"
>>>       depends on CIFS && INFINIBAND
>>> +     depends on CIFS=m || INFINIBAND=y
>>>       help
>>>         Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
>>>         SMB Direct allows transferring SMB packets over RDMA. If unsure,
>>
>> Is this really correct? Should CIFS_SMB_DIRECT be allowed with:
>>
>> CIFS=n and INFINIBAND=y ???
>> or
>> CIFS=m and INFINIBAND=n ???
>>
>> I guess a more complex logic should be used here
>> or am I missing something?
> 
> The two ones you listed are prohibited by the existing
> 'depends on CIFS && INFINIBAND' dependency.
> 
> We could rephrase the dependency as
> 
> depends on (CIFS=y && INFINIBAND=y) || \
>             (CIFS=m && INFINIBAND=y) || \
>             (CIFS=m && INFINIBAND=m)
> 
> which has the same effect as
> 
>       depends on CIFS && INFINIBAND
>       depends on CIFS=m || INFINIBAND=y
> 
> but I don't think that adds any clarity.

Thanks for the clarification!

I somehow assumed the patch has been:


-      depends on CIFS && INFINIBAND
+      depends on CIFS=m || INFINIBAND=y

instead of:
       depends on CIFS && INFINIBAND
+      depends on CIFS=m || INFINIBAND=y

metze


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Metzmacher <metze@samba.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steve French <sfrench@samba.org>,
	Pavel Shilovsky <pshilov@microsoft.com>,
	Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m
Date: Tue, 19 Dec 2017 12:01:19 +0100	[thread overview]
Message-ID: <4f2d6c8d-2958-3eb4-25b3-c789a0e1226d@samba.org> (raw)
In-Reply-To: <CAK8P3a3TQSt8skuyu7uHBbyG_jHS8wUaPPJ1XSh4u+aHxBzN8w@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1656 bytes --]

Am 19.12.2017 um 11:56 schrieb Arnd Bergmann via samba-technical:
> On Tue, Dec 19, 2017 at 11:33 AM, Stefan Metzmacher <metze@samba.org> wrote:
>> Hi Arnd,
>>
>>> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
>>> index 500fd69fb58b..3bfc55c08bef 100644
>>> --- a/fs/cifs/Kconfig
>>> +++ b/fs/cifs/Kconfig
>>> @@ -199,6 +199,7 @@ config CIFS_SMB311
>>>  config CIFS_SMB_DIRECT
>>>       bool "SMB Direct support (Experimental)"
>>>       depends on CIFS && INFINIBAND
>>> +     depends on CIFS=m || INFINIBAND=y
>>>       help
>>>         Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1.
>>>         SMB Direct allows transferring SMB packets over RDMA. If unsure,
>>
>> Is this really correct? Should CIFS_SMB_DIRECT be allowed with:
>>
>> CIFS=n and INFINIBAND=y ???
>> or
>> CIFS=m and INFINIBAND=n ???
>>
>> I guess a more complex logic should be used here
>> or am I missing something?
> 
> The two ones you listed are prohibited by the existing
> 'depends on CIFS && INFINIBAND' dependency.
> 
> We could rephrase the dependency as
> 
> depends on (CIFS=y && INFINIBAND=y) || \
>             (CIFS=m && INFINIBAND=y) || \
>             (CIFS=m && INFINIBAND=m)
> 
> which has the same effect as
> 
>       depends on CIFS && INFINIBAND
>       depends on CIFS=m || INFINIBAND=y
> 
> but I don't think that adds any clarity.

Thanks for the clarification!

I somehow assumed the patch has been:


-      depends on CIFS && INFINIBAND
+      depends on CIFS=m || INFINIBAND=y

instead of:
       depends on CIFS && INFINIBAND
+      depends on CIFS=m || INFINIBAND=y

metze


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2017-12-19 11:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 10:12 [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m Arnd Bergmann
     [not found] ` <20171219101327.2165797-1-arnd-r2nGTMty4D4@public.gmane.org>
2017-12-19 10:33   ` Stefan Metzmacher
2017-12-19 10:33     ` Stefan Metzmacher
2017-12-19 10:56     ` Arnd Bergmann
     [not found]       ` <CAK8P3a3TQSt8skuyu7uHBbyG_jHS8wUaPPJ1XSh4u+aHxBzN8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-19 11:01         ` Stefan Metzmacher [this message]
2017-12-19 11:01           ` Stefan Metzmacher
2017-12-19 12:39   ` Jean Delvare
2017-12-19 12:39     ` Jean Delvare
2017-12-19 21:21   ` Long Li
2017-12-19 21:21     ` Long Li
     [not found]     ` <MWHPR21MB08468B3FE04EAF4B41A92B75CE0F0-saRRjQKJ25OdAu0pOMKhMc1VXTxX1y3OvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-12-20  6:34       ` Stefan Metzmacher
2017-12-20  6:34         ` Stefan Metzmacher
2017-12-20  8:17     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f2d6c8d-2958-3eb4-25b3-c789a0e1226d@samba.org \
    --to=metze-eunubhrolfbytjvyw6ydsg@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pshilov-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
    --cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
    --cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.