* [PATCH 1/9] clk: qcom: rpmh: define IPA clocks where required
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 13:39 ` Alex Elder
2023-01-06 7:33 ` [PATCH 2/9] interconnect: qcom: sdx55: drop IP0 remnants Dmitry Baryshkov
` (7 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
Follow the example of sc7180 and sdx55 and implement IP0 resource as
clocks rather than interconnects.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/clk/qcom/clk-rpmh.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 586a810c682c..5f914cf36b10 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -445,6 +445,7 @@ static struct clk_hw *sm8150_rpmh_clocks[] = {
[RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_a_ao.hw,
[RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw,
[RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw,
+ [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};
static const struct clk_rpmh_desc clk_rpmh_sm8150 = {
@@ -484,6 +485,7 @@ static struct clk_hw *sc8180x_rpmh_clocks[] = {
[RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_d_ao.hw,
[RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_d.hw,
[RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_d_ao.hw,
+ [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};
static const struct clk_rpmh_desc clk_rpmh_sc8180x = {
@@ -504,6 +506,7 @@ static struct clk_hw *sm8250_rpmh_clocks[] = {
[RPMH_RF_CLK1_A] = &clk_rpmh_rf_clk1_a_ao.hw,
[RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw,
[RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw,
+ [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};
static const struct clk_rpmh_desc clk_rpmh_sm8250 = {
@@ -546,6 +549,7 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = {
[RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
[RPMH_PKA_CLK] = &clk_rpmh_pka.hw,
[RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw,
+ [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};
static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 1/9] clk: qcom: rpmh: define IPA clocks where required
2023-01-06 7:33 ` [PATCH 1/9] clk: qcom: rpmh: define IPA clocks where required Dmitry Baryshkov
@ 2023-01-06 13:39 ` Alex Elder
2023-01-06 18:33 ` Dmitry Baryshkov
0 siblings, 1 reply; 17+ messages in thread
From: Alex Elder @ 2023-01-06 13:39 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Stephen Boyd, Michael Turquette, Rob Herring,
Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Johan Hovold, linux-arm-msm,
linux-clk, linux-pm, devicetree
On 1/6/23 1:33 AM, Dmitry Baryshkov wrote:
> Follow the example of sc7180 and sdx55 and implement IP0 resource as
> clocks rather than interconnects.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
So this is simply adding these clocks? Were they not
defined/implemented as interconnects before? (It
isn't clear from your message above, and I just want
to be sure there's no duplication.)
-Alex
> ---
> drivers/clk/qcom/clk-rpmh.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 586a810c682c..5f914cf36b10 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -445,6 +445,7 @@ static struct clk_hw *sm8150_rpmh_clocks[] = {
> [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_a_ao.hw,
> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw,
> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sm8150 = {
> @@ -484,6 +485,7 @@ static struct clk_hw *sc8180x_rpmh_clocks[] = {
> [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_d_ao.hw,
> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_d.hw,
> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_d_ao.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sc8180x = {
> @@ -504,6 +506,7 @@ static struct clk_hw *sm8250_rpmh_clocks[] = {
> [RPMH_RF_CLK1_A] = &clk_rpmh_rf_clk1_a_ao.hw,
> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw,
> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sm8250 = {
> @@ -546,6 +549,7 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = {
> [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> [RPMH_PKA_CLK] = &clk_rpmh_pka.hw,
> [RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw,
> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 1/9] clk: qcom: rpmh: define IPA clocks where required
2023-01-06 13:39 ` Alex Elder
@ 2023-01-06 18:33 ` Dmitry Baryshkov
0 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 18:33 UTC (permalink / raw)
To: Alex Elder, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Stephen Boyd, Michael Turquette, Rob Herring,
Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Johan Hovold, linux-arm-msm,
linux-clk, linux-pm, devicetree
On 06/01/2023 15:39, Alex Elder wrote:
> On 1/6/23 1:33 AM, Dmitry Baryshkov wrote:
>> Follow the example of sc7180 and sdx55 and implement IP0 resource as
>> clocks rather than interconnects.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> So this is simply adding these clocks? Were they not
> defined/implemented as interconnects before? (It
> isn't clear from your message above, and I just want
> to be sure there's no duplication.)
Well, that's the point of the patchset: to turn them from ICC to clock.
I can change the order of the patches in the patchset, if you think it
will make it more obvious.
>
> -Alex
>
>> ---
>> drivers/clk/qcom/clk-rpmh.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
>> index 586a810c682c..5f914cf36b10 100644
>> --- a/drivers/clk/qcom/clk-rpmh.c
>> +++ b/drivers/clk/qcom/clk-rpmh.c
>> @@ -445,6 +445,7 @@ static struct clk_hw *sm8150_rpmh_clocks[] = {
>> [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_a_ao.hw,
>> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw,
>> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw,
>> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>> };
>> static const struct clk_rpmh_desc clk_rpmh_sm8150 = {
>> @@ -484,6 +485,7 @@ static struct clk_hw *sc8180x_rpmh_clocks[] = {
>> [RPMH_RF_CLK2_A] = &clk_rpmh_rf_clk2_d_ao.hw,
>> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_d.hw,
>> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_d_ao.hw,
>> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>> };
>> static const struct clk_rpmh_desc clk_rpmh_sc8180x = {
>> @@ -504,6 +506,7 @@ static struct clk_hw *sm8250_rpmh_clocks[] = {
>> [RPMH_RF_CLK1_A] = &clk_rpmh_rf_clk1_a_ao.hw,
>> [RPMH_RF_CLK3] = &clk_rpmh_rf_clk3_a.hw,
>> [RPMH_RF_CLK3_A] = &clk_rpmh_rf_clk3_a_ao.hw,
>> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>> };
>> static const struct clk_rpmh_desc clk_rpmh_sm8250 = {
>> @@ -546,6 +549,7 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = {
>> [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>> [RPMH_PKA_CLK] = &clk_rpmh_pka.hw,
>> [RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw,
>> + [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>> };
>> static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/9] interconnect: qcom: sdx55: drop IP0 remnants
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 1/9] clk: qcom: rpmh: define IPA clocks where required Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 3/9] interconnect: qcom: sc7180: " Dmitry Baryshkov
` (6 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
Drop two defines leftover from the commit 2fb251c26560 ("interconnect:
qcom: sdx55: Drop IP0 interconnects"), which dropped handling of the IP0
resource in favour of handling it in the clk-rpmh driver.
Fixes: 2fb251c26560 ("interconnect: qcom: sdx55: Drop IP0 interconnects")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/sdx55.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/interconnect/qcom/sdx55.h b/drivers/interconnect/qcom/sdx55.h
index deff8afe0631..f7394f460127 100644
--- a/drivers/interconnect/qcom/sdx55.h
+++ b/drivers/interconnect/qcom/sdx55.h
@@ -6,7 +6,6 @@
#ifndef __DRIVERS_INTERCONNECT_QCOM_SDX55_H
#define __DRIVERS_INTERCONNECT_QCOM_SDX55_H
-#define SDX55_MASTER_IPA_CORE 0
#define SDX55_MASTER_LLCC 1
#define SDX55_MASTER_TCU_0 2
#define SDX55_MASTER_SNOC_GC_MEM_NOC 3
@@ -28,7 +27,6 @@
#define SDX55_MASTER_QDSS_ETR 19
#define SDX55_MASTER_SDCC_1 20
#define SDX55_MASTER_USB3 21
-#define SDX55_SLAVE_IPA_CORE 22
#define SDX55_SLAVE_EBI_CH0 23
#define SDX55_SLAVE_LLCC 24
#define SDX55_SLAVE_MEM_NOC_SNOC 25
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 3/9] interconnect: qcom: sc7180: drop IP0 remnants
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 1/9] clk: qcom: rpmh: define IPA clocks where required Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 2/9] interconnect: qcom: sdx55: drop IP0 remnants Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 13:44 ` Alex Elder
2023-01-06 7:33 ` [PATCH 4/9] interconnect: qcom: sm8150: Drop IP0 interconnects Dmitry Baryshkov
` (5 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
Drop two defines leftover from the commit 2f3724930eb4 ("interconnect:
qcom: sc7180: Drop IP0 interconnects"), which dropped handling of the
IP0 resource in favour of handling it in the clk-rpmh driver.
Fixes: 2f3724930eb4 ("interconnect: qcom: sc7180: Drop IP0 interconnects")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/sc7180.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/interconnect/qcom/sc7180.h b/drivers/interconnect/qcom/sc7180.h
index c6212a10c2f6..b691d97d56cf 100644
--- a/drivers/interconnect/qcom/sc7180.h
+++ b/drivers/interconnect/qcom/sc7180.h
@@ -11,7 +11,6 @@
#define SC7180_MASTER_APPSS_PROC 0
#define SC7180_MASTER_SYS_TCU 1
#define SC7180_MASTER_NPU_SYS 2
-#define SC7180_MASTER_IPA_CORE 3
#define SC7180_MASTER_LLCC 4
#define SC7180_MASTER_A1NOC_CFG 5
#define SC7180_MASTER_A2NOC_CFG 6
@@ -58,7 +57,6 @@
#define SC7180_MASTER_USB3 47
#define SC7180_MASTER_EMMC 48
#define SC7180_SLAVE_EBI1 49
-#define SC7180_SLAVE_IPA_CORE 50
#define SC7180_SLAVE_A1NOC_CFG 51
#define SC7180_SLAVE_A2NOC_CFG 52
#define SC7180_SLAVE_AHB2PHY_SOUTH 53
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 3/9] interconnect: qcom: sc7180: drop IP0 remnants
2023-01-06 7:33 ` [PATCH 3/9] interconnect: qcom: sc7180: " Dmitry Baryshkov
@ 2023-01-06 13:44 ` Alex Elder
2023-01-06 18:52 ` Dmitry Baryshkov
0 siblings, 1 reply; 17+ messages in thread
From: Alex Elder @ 2023-01-06 13:44 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Stephen Boyd, Michael Turquette, Rob Herring,
Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Johan Hovold, linux-arm-msm,
linux-clk, linux-pm, devicetree
On 1/6/23 1:33 AM, Dmitry Baryshkov wrote:
> Drop two defines leftover from the commit 2f3724930eb4 ("interconnect:
> qcom: sc7180: Drop IP0 interconnects"), which dropped handling of the
> IP0 resource in favour of handling it in the clk-rpmh driver.
>
> Fixes: 2f3724930eb4 ("interconnect: qcom: sc7180: Drop IP0 interconnects")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On this patch and the rest like it in this series, I suggest
adding a comment that indicates why there's a gap in the simple
numeric sequence. Feel free to ignore this if you don't think
this is a good idea. I'll give examples below, although I
don't fully understand why there's a master and slave on the
interconnect, but just a single clock for RPMH clock...
-Alex
> ---
> drivers/interconnect/qcom/sc7180.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/sc7180.h b/drivers/interconnect/qcom/sc7180.h
> index c6212a10c2f6..b691d97d56cf 100644
> --- a/drivers/interconnect/qcom/sc7180.h
> +++ b/drivers/interconnect/qcom/sc7180.h
> @@ -11,7 +11,6 @@
> #define SC7180_MASTER_APPSS_PROC 0
> #define SC7180_MASTER_SYS_TCU 1
> #define SC7180_MASTER_NPU_SYS 2
> -#define SC7180_MASTER_IPA_CORE 3
/* MASTER_IPA_CORE (4) is represented as an RPMH clock */
> #define SC7180_MASTER_LLCC 4
> #define SC7180_MASTER_A1NOC_CFG 5
> #define SC7180_MASTER_A2NOC_CFG 6
> @@ -58,7 +57,6 @@
> #define SC7180_MASTER_USB3 47
> #define SC7180_MASTER_EMMC 48
> #define SC7180_SLAVE_EBI1 49
> -#define SC7180_SLAVE_IPA_CORE 50
/* SLAVE_IPA_CORE (50) is represented as an RPMH clock */
> #define SC7180_SLAVE_A1NOC_CFG 51
> #define SC7180_SLAVE_A2NOC_CFG 52
> #define SC7180_SLAVE_AHB2PHY_SOUTH 53
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 3/9] interconnect: qcom: sc7180: drop IP0 remnants
2023-01-06 13:44 ` Alex Elder
@ 2023-01-06 18:52 ` Dmitry Baryshkov
0 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 18:52 UTC (permalink / raw)
To: Alex Elder, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Stephen Boyd, Michael Turquette, Rob Herring,
Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Johan Hovold, linux-arm-msm,
linux-clk, linux-pm, devicetree
On 06/01/2023 15:44, Alex Elder wrote:
> On 1/6/23 1:33 AM, Dmitry Baryshkov wrote:
>> Drop two defines leftover from the commit 2f3724930eb4 ("interconnect:
>> qcom: sc7180: Drop IP0 interconnects"), which dropped handling of the
>> IP0 resource in favour of handling it in the clk-rpmh driver.
>>
>> Fixes: 2f3724930eb4 ("interconnect: qcom: sc7180: Drop IP0
>> interconnects")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> On this patch and the rest like it in this series, I suggest
> adding a comment that indicates why there's a gap in the simple
> numeric sequence.
Ok, sounds fair.
> Feel free to ignore this if you don't think
> this is a good idea. I'll give examples below, although I
> don't fully understand why there's a master and slave on the
> interconnect, but just a single clock for RPMH clock...
Well, interconnects is a about paths between nodes. So even if we have
to cast a vote on a single resource, there should be two nodes.
>
> -Alex
>
>> ---
>> drivers/interconnect/qcom/sc7180.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/interconnect/qcom/sc7180.h
>> b/drivers/interconnect/qcom/sc7180.h
>> index c6212a10c2f6..b691d97d56cf 100644
>> --- a/drivers/interconnect/qcom/sc7180.h
>> +++ b/drivers/interconnect/qcom/sc7180.h
>> @@ -11,7 +11,6 @@
>> #define SC7180_MASTER_APPSS_PROC 0
>> #define SC7180_MASTER_SYS_TCU 1
>> #define SC7180_MASTER_NPU_SYS 2
>> -#define SC7180_MASTER_IPA_CORE 3
> /* MASTER_IPA_CORE (4) is represented as an RPMH clock */
>> #define SC7180_MASTER_LLCC 4
>> #define SC7180_MASTER_A1NOC_CFG 5
>> #define SC7180_MASTER_A2NOC_CFG 6
>> @@ -58,7 +57,6 @@
>> #define SC7180_MASTER_USB3 47
>> #define SC7180_MASTER_EMMC 48
>> #define SC7180_SLAVE_EBI1 49
>> -#define SC7180_SLAVE_IPA_CORE 50
> /* SLAVE_IPA_CORE (50) is represented as an RPMH clock */
>> #define SC7180_SLAVE_A1NOC_CFG 51
>> #define SC7180_SLAVE_A2NOC_CFG 52
>> #define SC7180_SLAVE_AHB2PHY_SOUTH 53
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/9] interconnect: qcom: sm8150: Drop IP0 interconnects
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
` (2 preceding siblings ...)
2023-01-06 7:33 ` [PATCH 3/9] interconnect: qcom: sc7180: " Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 13:47 ` Alex Elder
2023-01-06 7:33 ` [PATCH 5/9] interconnect: qcom: sm8250: " Dmitry Baryshkov
` (4 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
Similar to the sdx55 and sc7180, let's drop the IP0 interconnects here
because the IP0 resource is also used in the clk-rpmh.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/sm8150.c | 21 ---------------------
drivers/interconnect/qcom/sm8150.h | 2 --
2 files changed, 23 deletions(-)
diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c
index 1d04a4bfea80..c5ab29322164 100644
--- a/drivers/interconnect/qcom/sm8150.c
+++ b/drivers/interconnect/qcom/sm8150.c
@@ -56,7 +56,6 @@ DEFINE_QNODE(qnm_pcie, SM8150_MASTER_GEM_NOC_PCIE_SNOC, 1, 16, SM8150_SLAVE_LLCC
DEFINE_QNODE(qnm_snoc_gc, SM8150_MASTER_SNOC_GC_MEM_NOC, 1, 8, SM8150_SLAVE_LLCC);
DEFINE_QNODE(qnm_snoc_sf, SM8150_MASTER_SNOC_SF_MEM_NOC, 1, 16, SM8150_SLAVE_LLCC);
DEFINE_QNODE(qxm_ecc, SM8150_MASTER_ECC, 2, 32, SM8150_SLAVE_LLCC);
-DEFINE_QNODE(ipa_core_master, SM8150_MASTER_IPA_CORE, 1, 8, SM8150_SLAVE_IPA_CORE);
DEFINE_QNODE(llcc_mc, SM8150_MASTER_LLCC, 4, 4, SM8150_SLAVE_EBI_CH0);
DEFINE_QNODE(qhm_mnoc_cfg, SM8150_MASTER_CNOC_MNOC_CFG, 1, 4, SM8150_SLAVE_SERVICE_MNOC);
DEFINE_QNODE(qxm_camnoc_hf0, SM8150_MASTER_CAMNOC_HF0, 1, 32, SM8150_SLAVE_MNOC_HF_MEM_NOC);
@@ -139,7 +138,6 @@ DEFINE_QNODE(qns_ecc, SM8150_SLAVE_ECC, 1, 32);
DEFINE_QNODE(qns_gem_noc_snoc, SM8150_SLAVE_GEM_NOC_SNOC, 1, 8, SM8150_MASTER_GEM_NOC_SNOC);
DEFINE_QNODE(qns_llcc, SM8150_SLAVE_LLCC, 4, 16, SM8150_MASTER_LLCC);
DEFINE_QNODE(srvc_gemnoc, SM8150_SLAVE_SERVICE_GEM_NOC, 1, 4);
-DEFINE_QNODE(ipa_core_slave, SM8150_SLAVE_IPA_CORE, 1, 8);
DEFINE_QNODE(ebi, SM8150_SLAVE_EBI_CH0, 4, 4);
DEFINE_QNODE(qns2_mem_noc, SM8150_SLAVE_MNOC_SF_MEM_NOC, 1, 32, SM8150_MASTER_MNOC_SF_MEM_NOC);
DEFINE_QNODE(qns_mem_noc_hf, SM8150_SLAVE_MNOC_HF_MEM_NOC, 2, 32, SM8150_MASTER_MNOC_HF_MEM_NOC);
@@ -172,7 +170,6 @@ DEFINE_QBCM(bcm_co0, "CO0", false, &qns_cdsp_mem_noc);
DEFINE_QBCM(bcm_ce0, "CE0", false, &qxm_crypto);
DEFINE_QBCM(bcm_sn1, "SN1", false, &qxs_imem);
DEFINE_QBCM(bcm_co1, "CO1", false, &qnm_npu);
-DEFINE_QBCM(bcm_ip0, "IP0", false, &ipa_core_slave);
DEFINE_QBCM(bcm_cn0, "CN0", true, &qhm_spdm, &qnm_snoc, &qhs_a1_noc_cfg, &qhs_a2_noc_cfg, &qhs_ahb2phy_south, &qhs_aop, &qhs_aoss, &qhs_camera_cfg, &qhs_clk_ctl, &qhs_compute_dsp, &qhs_cpr_cx, &qhs_cpr_mmcx, &qhs_cpr_mx, &qhs_crypto0_cfg, &qhs_ddrss_cfg, &qhs_display_cfg, &qhs_emac_cfg, &qhs_glm, &qhs_gpuss_cfg, &qhs_imem_cfg, &qhs_ipa, &qhs_mnoc_cfg, &qhs_npu_cfg, &qhs_pcie0_cfg, &qhs_pcie1_cfg, &qhs_phy_refgen_north, &qhs_pimem_cfg, &qhs_prng, &qhs_qdss_cfg, &qhs_qspi, &qhs_qupv3_east, &qhs_qupv3_north, &qhs_qupv3_south, &qhs_sdc2, &qhs_sdc4, &qhs_snoc_cfg, &qhs_spdm, &qhs_spss_cfg, &qhs_ssc_cfg, &qhs_tcsr, &qhs_tlmm_east, &qhs_tlmm_north, &qhs_tlmm_south, &qhs_tlmm_west, &qhs_tsif, &qhs_ufs_card_cfg, &qhs_ufs_mem_cfg, &qhs_usb3_0, &qhs_usb3_1, &qhs_venus_cfg, &qhs_vsense_ctrl_cfg, &qns_cnoc_a2noc, &srvc_cnoc);
DEFINE_QBCM(bcm_qup0, "QUP0", false, &qhm_qup0, &qhm_qup1, &qhm_qup2);
DEFINE_QBCM(bcm_sn2, "SN2", false, &qns_gemnoc_gc);
@@ -398,22 +395,6 @@ static const struct qcom_icc_desc sm8150_gem_noc = {
.num_bcms = ARRAY_SIZE(gem_noc_bcms),
};
-static struct qcom_icc_bcm * const ipa_virt_bcms[] = {
- &bcm_ip0,
-};
-
-static struct qcom_icc_node * const ipa_virt_nodes[] = {
- [MASTER_IPA_CORE] = &ipa_core_master,
- [SLAVE_IPA_CORE] = &ipa_core_slave,
-};
-
-static const struct qcom_icc_desc sm8150_ipa_virt = {
- .nodes = ipa_virt_nodes,
- .num_nodes = ARRAY_SIZE(ipa_virt_nodes),
- .bcms = ipa_virt_bcms,
- .num_bcms = ARRAY_SIZE(ipa_virt_bcms),
-};
-
static struct qcom_icc_bcm * const mc_virt_bcms[] = {
&bcm_acv,
&bcm_mc0,
@@ -517,8 +498,6 @@ static const struct of_device_id qnoc_of_match[] = {
.data = &sm8150_dc_noc},
{ .compatible = "qcom,sm8150-gem-noc",
.data = &sm8150_gem_noc},
- { .compatible = "qcom,sm8150-ipa-virt",
- .data = &sm8150_ipa_virt},
{ .compatible = "qcom,sm8150-mc-virt",
.data = &sm8150_mc_virt},
{ .compatible = "qcom,sm8150-mmss-noc",
diff --git a/drivers/interconnect/qcom/sm8150.h b/drivers/interconnect/qcom/sm8150.h
index 97996f64d799..1120b1a9fddc 100644
--- a/drivers/interconnect/qcom/sm8150.h
+++ b/drivers/interconnect/qcom/sm8150.h
@@ -35,7 +35,6 @@
#define SM8150_MASTER_GPU_TCU 24
#define SM8150_MASTER_GRAPHICS_3D 25
#define SM8150_MASTER_IPA 26
-#define SM8150_MASTER_IPA_CORE 27
#define SM8150_MASTER_LLCC 28
#define SM8150_MASTER_MDP_PORT0 29
#define SM8150_MASTER_MDP_PORT1 30
@@ -94,7 +93,6 @@
#define SM8150_SLAVE_GRAPHICS_3D_CFG 83
#define SM8150_SLAVE_IMEM_CFG 84
#define SM8150_SLAVE_IPA_CFG 85
-#define SM8150_SLAVE_IPA_CORE 86
#define SM8150_SLAVE_LLCC 87
#define SM8150_SLAVE_LLCC_CFG 88
#define SM8150_SLAVE_MNOC_HF_MEM_NOC 89
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 4/9] interconnect: qcom: sm8150: Drop IP0 interconnects
2023-01-06 7:33 ` [PATCH 4/9] interconnect: qcom: sm8150: Drop IP0 interconnects Dmitry Baryshkov
@ 2023-01-06 13:47 ` Alex Elder
0 siblings, 0 replies; 17+ messages in thread
From: Alex Elder @ 2023-01-06 13:47 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Stephen Boyd, Michael Turquette, Rob Herring,
Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Johan Hovold, linux-arm-msm,
linux-clk, linux-pm, devicetree
On 1/6/23 1:33 AM, Dmitry Baryshkov wrote:
> Similar to the sdx55 and sc7180, let's drop the IP0 interconnects here
> because the IP0 resource is also used in the clk-rpmh.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
For the interconnects that are already (also) represented by
RPMH clocks, I believe the interconnects are never used. So
I *think* it would be better to remove these first, possibly
even as a bug fix (?).
Similarly, for the three others you're converting to be
represented as clocks, I don't think they're used (yet?),
so you could remove those before redefining as clocks too.
Please explain to me if I'm misunderstanding.
-Alex
> ---
> drivers/interconnect/qcom/sm8150.c | 21 ---------------------
> drivers/interconnect/qcom/sm8150.h | 2 --
> 2 files changed, 23 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/sm8150.c b/drivers/interconnect/qcom/sm8150.c
> index 1d04a4bfea80..c5ab29322164 100644
> --- a/drivers/interconnect/qcom/sm8150.c
> +++ b/drivers/interconnect/qcom/sm8150.c
> @@ -56,7 +56,6 @@ DEFINE_QNODE(qnm_pcie, SM8150_MASTER_GEM_NOC_PCIE_SNOC, 1, 16, SM8150_SLAVE_LLCC
> DEFINE_QNODE(qnm_snoc_gc, SM8150_MASTER_SNOC_GC_MEM_NOC, 1, 8, SM8150_SLAVE_LLCC);
> DEFINE_QNODE(qnm_snoc_sf, SM8150_MASTER_SNOC_SF_MEM_NOC, 1, 16, SM8150_SLAVE_LLCC);
> DEFINE_QNODE(qxm_ecc, SM8150_MASTER_ECC, 2, 32, SM8150_SLAVE_LLCC);
> -DEFINE_QNODE(ipa_core_master, SM8150_MASTER_IPA_CORE, 1, 8, SM8150_SLAVE_IPA_CORE);
> DEFINE_QNODE(llcc_mc, SM8150_MASTER_LLCC, 4, 4, SM8150_SLAVE_EBI_CH0);
> DEFINE_QNODE(qhm_mnoc_cfg, SM8150_MASTER_CNOC_MNOC_CFG, 1, 4, SM8150_SLAVE_SERVICE_MNOC);
> DEFINE_QNODE(qxm_camnoc_hf0, SM8150_MASTER_CAMNOC_HF0, 1, 32, SM8150_SLAVE_MNOC_HF_MEM_NOC);
> @@ -139,7 +138,6 @@ DEFINE_QNODE(qns_ecc, SM8150_SLAVE_ECC, 1, 32);
> DEFINE_QNODE(qns_gem_noc_snoc, SM8150_SLAVE_GEM_NOC_SNOC, 1, 8, SM8150_MASTER_GEM_NOC_SNOC);
> DEFINE_QNODE(qns_llcc, SM8150_SLAVE_LLCC, 4, 16, SM8150_MASTER_LLCC);
> DEFINE_QNODE(srvc_gemnoc, SM8150_SLAVE_SERVICE_GEM_NOC, 1, 4);
> -DEFINE_QNODE(ipa_core_slave, SM8150_SLAVE_IPA_CORE, 1, 8);
> DEFINE_QNODE(ebi, SM8150_SLAVE_EBI_CH0, 4, 4);
> DEFINE_QNODE(qns2_mem_noc, SM8150_SLAVE_MNOC_SF_MEM_NOC, 1, 32, SM8150_MASTER_MNOC_SF_MEM_NOC);
> DEFINE_QNODE(qns_mem_noc_hf, SM8150_SLAVE_MNOC_HF_MEM_NOC, 2, 32, SM8150_MASTER_MNOC_HF_MEM_NOC);
> @@ -172,7 +170,6 @@ DEFINE_QBCM(bcm_co0, "CO0", false, &qns_cdsp_mem_noc);
> DEFINE_QBCM(bcm_ce0, "CE0", false, &qxm_crypto);
> DEFINE_QBCM(bcm_sn1, "SN1", false, &qxs_imem);
> DEFINE_QBCM(bcm_co1, "CO1", false, &qnm_npu);
> -DEFINE_QBCM(bcm_ip0, "IP0", false, &ipa_core_slave);
> DEFINE_QBCM(bcm_cn0, "CN0", true, &qhm_spdm, &qnm_snoc, &qhs_a1_noc_cfg, &qhs_a2_noc_cfg, &qhs_ahb2phy_south, &qhs_aop, &qhs_aoss, &qhs_camera_cfg, &qhs_clk_ctl, &qhs_compute_dsp, &qhs_cpr_cx, &qhs_cpr_mmcx, &qhs_cpr_mx, &qhs_crypto0_cfg, &qhs_ddrss_cfg, &qhs_display_cfg, &qhs_emac_cfg, &qhs_glm, &qhs_gpuss_cfg, &qhs_imem_cfg, &qhs_ipa, &qhs_mnoc_cfg, &qhs_npu_cfg, &qhs_pcie0_cfg, &qhs_pcie1_cfg, &qhs_phy_refgen_north, &qhs_pimem_cfg, &qhs_prng, &qhs_qdss_cfg, &qhs_qspi, &qhs_qupv3_east, &qhs_qupv3_north, &qhs_qupv3_south, &qhs_sdc2, &qhs_sdc4, &qhs_snoc_cfg, &qhs_spdm, &qhs_spss_cfg, &qhs_ssc_cfg, &qhs_tcsr, &qhs_tlmm_east, &qhs_tlmm_north, &qhs_tlmm_south, &qhs_tlmm_west, &qhs_tsif, &qhs_ufs_card_cfg, &qhs_ufs_mem_cfg, &qhs_usb3_0, &qhs_usb3_1, &qhs_venus_cfg, &qhs_vsense_ctrl_cfg, &qns_cnoc_a2noc, &srvc_cnoc);
> DEFINE_QBCM(bcm_qup0, "QUP0", false, &qhm_qup0, &qhm_qup1, &qhm_qup2);
> DEFINE_QBCM(bcm_sn2, "SN2", false, &qns_gemnoc_gc);
> @@ -398,22 +395,6 @@ static const struct qcom_icc_desc sm8150_gem_noc = {
> .num_bcms = ARRAY_SIZE(gem_noc_bcms),
> };
>
> -static struct qcom_icc_bcm * const ipa_virt_bcms[] = {
> - &bcm_ip0,
> -};
> -
> -static struct qcom_icc_node * const ipa_virt_nodes[] = {
> - [MASTER_IPA_CORE] = &ipa_core_master,
> - [SLAVE_IPA_CORE] = &ipa_core_slave,
> -};
> -
> -static const struct qcom_icc_desc sm8150_ipa_virt = {
> - .nodes = ipa_virt_nodes,
> - .num_nodes = ARRAY_SIZE(ipa_virt_nodes),
> - .bcms = ipa_virt_bcms,
> - .num_bcms = ARRAY_SIZE(ipa_virt_bcms),
> -};
> -
> static struct qcom_icc_bcm * const mc_virt_bcms[] = {
> &bcm_acv,
> &bcm_mc0,
> @@ -517,8 +498,6 @@ static const struct of_device_id qnoc_of_match[] = {
> .data = &sm8150_dc_noc},
> { .compatible = "qcom,sm8150-gem-noc",
> .data = &sm8150_gem_noc},
> - { .compatible = "qcom,sm8150-ipa-virt",
> - .data = &sm8150_ipa_virt},
> { .compatible = "qcom,sm8150-mc-virt",
> .data = &sm8150_mc_virt},
> { .compatible = "qcom,sm8150-mmss-noc",
> diff --git a/drivers/interconnect/qcom/sm8150.h b/drivers/interconnect/qcom/sm8150.h
> index 97996f64d799..1120b1a9fddc 100644
> --- a/drivers/interconnect/qcom/sm8150.h
> +++ b/drivers/interconnect/qcom/sm8150.h
> @@ -35,7 +35,6 @@
> #define SM8150_MASTER_GPU_TCU 24
> #define SM8150_MASTER_GRAPHICS_3D 25
> #define SM8150_MASTER_IPA 26
> -#define SM8150_MASTER_IPA_CORE 27
> #define SM8150_MASTER_LLCC 28
> #define SM8150_MASTER_MDP_PORT0 29
> #define SM8150_MASTER_MDP_PORT1 30
> @@ -94,7 +93,6 @@
> #define SM8150_SLAVE_GRAPHICS_3D_CFG 83
> #define SM8150_SLAVE_IMEM_CFG 84
> #define SM8150_SLAVE_IPA_CFG 85
> -#define SM8150_SLAVE_IPA_CORE 86
> #define SM8150_SLAVE_LLCC 87
> #define SM8150_SLAVE_LLCC_CFG 88
> #define SM8150_SLAVE_MNOC_HF_MEM_NOC 89
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 5/9] interconnect: qcom: sm8250: Drop IP0 interconnects
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
` (3 preceding siblings ...)
2023-01-06 7:33 ` [PATCH 4/9] interconnect: qcom: sm8150: Drop IP0 interconnects Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 6/9] interconnect: qcom: sc8180x: " Dmitry Baryshkov
` (3 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
Similar to the sdx55 and sc7180, let's drop the IP0 interconnects here
because the IP0 resource is also used in the clk-rpmh.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/sm8250.c | 21 ---------------------
drivers/interconnect/qcom/sm8250.h | 2 --
2 files changed, 23 deletions(-)
diff --git a/drivers/interconnect/qcom/sm8250.c b/drivers/interconnect/qcom/sm8250.c
index 5cdb058fa095..e3bb008cb219 100644
--- a/drivers/interconnect/qcom/sm8250.c
+++ b/drivers/interconnect/qcom/sm8250.c
@@ -51,7 +51,6 @@ DEFINE_QNODE(qnm_mnoc_sf, SM8250_MASTER_MNOC_SF_MEM_NOC, 2, 32, SM8250_SLAVE_LLC
DEFINE_QNODE(qnm_pcie, SM8250_MASTER_ANOC_PCIE_GEM_NOC, 1, 16, SM8250_SLAVE_LLCC, SM8250_SLAVE_GEM_NOC_SNOC);
DEFINE_QNODE(qnm_snoc_gc, SM8250_MASTER_SNOC_GC_MEM_NOC, 1, 8, SM8250_SLAVE_LLCC);
DEFINE_QNODE(qnm_snoc_sf, SM8250_MASTER_SNOC_SF_MEM_NOC, 1, 16, SM8250_SLAVE_LLCC, SM8250_SLAVE_GEM_NOC_SNOC, SM8250_SLAVE_MEM_NOC_PCIE_SNOC);
-DEFINE_QNODE(ipa_core_master, SM8250_MASTER_IPA_CORE, 1, 8, SM8250_SLAVE_IPA_CORE);
DEFINE_QNODE(llcc_mc, SM8250_MASTER_LLCC, 4, 4, SM8250_SLAVE_EBI_CH0);
DEFINE_QNODE(qhm_mnoc_cfg, SM8250_MASTER_CNOC_MNOC_CFG, 1, 4, SM8250_SLAVE_SERVICE_MNOC);
DEFINE_QNODE(qnm_camnoc_hf, SM8250_MASTER_CAMNOC_HF, 2, 32, SM8250_SLAVE_MNOC_HF_MEM_NOC);
@@ -138,7 +137,6 @@ DEFINE_QNODE(qns_sys_pcie, SM8250_SLAVE_MEM_NOC_PCIE_SNOC, 1, 8, SM8250_MASTER_G
DEFINE_QNODE(srvc_even_gemnoc, SM8250_SLAVE_SERVICE_GEM_NOC_1, 1, 4);
DEFINE_QNODE(srvc_odd_gemnoc, SM8250_SLAVE_SERVICE_GEM_NOC_2, 1, 4);
DEFINE_QNODE(srvc_sys_gemnoc, SM8250_SLAVE_SERVICE_GEM_NOC, 1, 4);
-DEFINE_QNODE(ipa_core_slave, SM8250_SLAVE_IPA_CORE, 1, 8);
DEFINE_QNODE(ebi, SM8250_SLAVE_EBI_CH0, 4, 4);
DEFINE_QNODE(qns_mem_noc_hf, SM8250_SLAVE_MNOC_HF_MEM_NOC, 2, 32, SM8250_MASTER_MNOC_HF_MEM_NOC);
DEFINE_QNODE(qns_mem_noc_sf, SM8250_SLAVE_MNOC_SF_MEM_NOC, 2, 32, SM8250_MASTER_MNOC_SF_MEM_NOC);
@@ -171,7 +169,6 @@ DEFINE_QBCM(bcm_mc0, "MC0", true, &ebi);
DEFINE_QBCM(bcm_sh0, "SH0", true, &qns_llcc);
DEFINE_QBCM(bcm_mm0, "MM0", true, &qns_mem_noc_hf);
DEFINE_QBCM(bcm_ce0, "CE0", false, &qxm_crypto);
-DEFINE_QBCM(bcm_ip0, "IP0", false, &ipa_core_slave);
DEFINE_QBCM(bcm_mm1, "MM1", false, &qnm_camnoc_hf, &qxm_mdp0, &qxm_mdp1);
DEFINE_QBCM(bcm_sh2, "SH2", false, &alm_gpu_tcu, &alm_sys_tcu);
DEFINE_QBCM(bcm_mm2, "MM2", false, &qns_mem_noc_sf);
@@ -386,22 +383,6 @@ static const struct qcom_icc_desc sm8250_gem_noc = {
.num_bcms = ARRAY_SIZE(gem_noc_bcms),
};
-static struct qcom_icc_bcm * const ipa_virt_bcms[] = {
- &bcm_ip0,
-};
-
-static struct qcom_icc_node * const ipa_virt_nodes[] = {
- [MASTER_IPA_CORE] = &ipa_core_master,
- [SLAVE_IPA_CORE] = &ipa_core_slave,
-};
-
-static const struct qcom_icc_desc sm8250_ipa_virt = {
- .nodes = ipa_virt_nodes,
- .num_nodes = ARRAY_SIZE(ipa_virt_nodes),
- .bcms = ipa_virt_bcms,
- .num_bcms = ARRAY_SIZE(ipa_virt_bcms),
-};
-
static struct qcom_icc_bcm * const mc_virt_bcms[] = {
&bcm_acv,
&bcm_mc0,
@@ -531,8 +512,6 @@ static const struct of_device_id qnoc_of_match[] = {
.data = &sm8250_dc_noc},
{ .compatible = "qcom,sm8250-gem-noc",
.data = &sm8250_gem_noc},
- { .compatible = "qcom,sm8250-ipa-virt",
- .data = &sm8250_ipa_virt},
{ .compatible = "qcom,sm8250-mc-virt",
.data = &sm8250_mc_virt},
{ .compatible = "qcom,sm8250-mmss-noc",
diff --git a/drivers/interconnect/qcom/sm8250.h b/drivers/interconnect/qcom/sm8250.h
index b31fb431a20f..27189b97af9e 100644
--- a/drivers/interconnect/qcom/sm8250.h
+++ b/drivers/interconnect/qcom/sm8250.h
@@ -31,7 +31,6 @@
#define SM8250_MASTER_GPU_TCU 20
#define SM8250_MASTER_GRAPHICS_3D 21
#define SM8250_MASTER_IPA 22
-#define SM8250_MASTER_IPA_CORE 23
#define SM8250_MASTER_LLCC 24
#define SM8250_MASTER_MDP_PORT0 25
#define SM8250_MASTER_MDP_PORT1 26
@@ -92,7 +91,6 @@
#define SM8250_SLAVE_GRAPHICS_3D_CFG 81
#define SM8250_SLAVE_IMEM_CFG 82
#define SM8250_SLAVE_IPA_CFG 83
-#define SM8250_SLAVE_IPA_CORE 84
#define SM8250_SLAVE_IPC_ROUTER_CFG 85
#define SM8250_SLAVE_ISENSE_CFG 86
#define SM8250_SLAVE_LLCC 87
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 6/9] interconnect: qcom: sc8180x: Drop IP0 interconnects
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
` (4 preceding siblings ...)
2023-01-06 7:33 ` [PATCH 5/9] interconnect: qcom: sm8250: " Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 7/9] interconnect: qcom: sc8280xp: " Dmitry Baryshkov
` (2 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
Similar to the sdx55 and sc7180, let's drop the IP0 interconnects here
because the IP0 resource is also used in the clk-rpmh.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/sc8180x.c | 38 -----------------------------
drivers/interconnect/qcom/sc8180x.h | 2 --
2 files changed, 40 deletions(-)
diff --git a/drivers/interconnect/qcom/sc8180x.c b/drivers/interconnect/qcom/sc8180x.c
index 0f515bf10bd7..c76e3a6a98cd 100644
--- a/drivers/interconnect/qcom/sc8180x.c
+++ b/drivers/interconnect/qcom/sc8180x.c
@@ -469,15 +469,6 @@ static struct qcom_icc_node mas_qxm_ecc = {
.links = { SC8180X_SLAVE_LLCC }
};
-static struct qcom_icc_node mas_ipa_core_master = {
- .name = "mas_ipa_core_master",
- .id = SC8180X_MASTER_IPA_CORE,
- .channels = 1,
- .buswidth = 8,
- .num_links = 1,
- .links = { SC8180X_SLAVE_IPA_CORE }
-};
-
static struct qcom_icc_node mas_llcc_mc = {
.name = "mas_llcc_mc",
.id = SC8180X_MASTER_LLCC,
@@ -1201,13 +1192,6 @@ static struct qcom_icc_node slv_srvc_gemnoc1 = {
.buswidth = 4
};
-static struct qcom_icc_node slv_ipa_core_slave = {
- .name = "slv_ipa_core_slave",
- .id = SC8180X_SLAVE_IPA_CORE,
- .channels = 1,
- .buswidth = 8
-};
-
static struct qcom_icc_node slv_ebi = {
.name = "slv_ebi",
.id = SC8180X_SLAVE_EBI_CH0,
@@ -1524,11 +1508,6 @@ static struct qcom_icc_bcm bcm_co2 = {
.nodes = { &mas_qnm_npu }
};
-static struct qcom_icc_bcm bcm_ip0 = {
- .name = "IP0",
- .nodes = { &slv_ipa_core_slave }
-};
-
static struct qcom_icc_bcm bcm_sn3 = {
.name = "SN3",
.keepalive = true,
@@ -1604,10 +1583,6 @@ static struct qcom_icc_bcm * const gem_noc_bcms[] = {
&bcm_sh3,
};
-static struct qcom_icc_bcm * const ipa_virt_bcms[] = {
- &bcm_ip0,
-};
-
static struct qcom_icc_bcm * const mc_virt_bcms[] = {
&bcm_mc0,
&bcm_acv,
@@ -1766,11 +1741,6 @@ static struct qcom_icc_node * const gem_noc_nodes[] = {
[SLAVE_SERVICE_GEM_NOC_1] = &slv_srvc_gemnoc1,
};
-static struct qcom_icc_node * const ipa_virt_nodes[] = {
- [MASTER_IPA_CORE] = &mas_ipa_core_master,
- [SLAVE_IPA_CORE] = &slv_ipa_core_slave,
-};
-
static struct qcom_icc_node * const mc_virt_nodes[] = {
[MASTER_LLCC] = &mas_llcc_mc,
[SLAVE_EBI_CH0] = &slv_ebi,
@@ -1857,13 +1827,6 @@ static const struct qcom_icc_desc sc8180x_gem_noc = {
.num_bcms = ARRAY_SIZE(gem_noc_bcms),
};
-static const struct qcom_icc_desc sc8180x_ipa_virt = {
- .nodes = ipa_virt_nodes,
- .num_nodes = ARRAY_SIZE(ipa_virt_nodes),
- .bcms = ipa_virt_bcms,
- .num_bcms = ARRAY_SIZE(ipa_virt_bcms),
-};
-
static const struct qcom_icc_desc sc8180x_mc_virt = {
.nodes = mc_virt_nodes,
.num_nodes = ARRAY_SIZE(mc_virt_nodes),
@@ -1913,7 +1876,6 @@ static const struct of_device_id qnoc_of_match[] = {
{ .compatible = "qcom,sc8180x-config-noc", .data = &sc8180x_config_noc },
{ .compatible = "qcom,sc8180x-dc-noc", .data = &sc8180x_dc_noc },
{ .compatible = "qcom,sc8180x-gem-noc", .data = &sc8180x_gem_noc },
- { .compatible = "qcom,sc8180x-ipa-virt", .data = &sc8180x_ipa_virt },
{ .compatible = "qcom,sc8180x-mc-virt", .data = &sc8180x_mc_virt },
{ .compatible = "qcom,sc8180x-mmss-noc", .data = &sc8180x_mmss_noc },
{ .compatible = "qcom,sc8180x-qup-virt", .data = &sc8180x_qup_virt },
diff --git a/drivers/interconnect/qcom/sc8180x.h b/drivers/interconnect/qcom/sc8180x.h
index 2eafd35543c7..5b3bb0f0cb51 100644
--- a/drivers/interconnect/qcom/sc8180x.h
+++ b/drivers/interconnect/qcom/sc8180x.h
@@ -51,7 +51,6 @@
#define SC8180X_MASTER_SNOC_GC_MEM_NOC 41
#define SC8180X_MASTER_SNOC_SF_MEM_NOC 42
#define SC8180X_MASTER_ECC 43
-#define SC8180X_MASTER_IPA_CORE 44
#define SC8180X_MASTER_LLCC 45
#define SC8180X_MASTER_CNOC_MNOC_CFG 46
#define SC8180X_MASTER_CAMNOC_HF0 47
@@ -146,7 +145,6 @@
#define SC8180X_SLAVE_LLCC 136
#define SC8180X_SLAVE_SERVICE_GEM_NOC 137
#define SC8180X_SLAVE_SERVICE_GEM_NOC_1 138
-#define SC8180X_SLAVE_IPA_CORE 139
#define SC8180X_SLAVE_EBI_CH0 140
#define SC8180X_SLAVE_MNOC_SF_MEM_NOC 141
#define SC8180X_SLAVE_MNOC_HF_MEM_NOC 142
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 7/9] interconnect: qcom: sc8280xp: Drop IP0 interconnects
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
` (5 preceding siblings ...)
2023-01-06 7:33 ` [PATCH 6/9] interconnect: qcom: sc8180x: " Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 8/9] dt-bindings: interconnect: qcom: Remove sc7180/sdx55 ipa compatibles Dmitry Baryshkov
2023-01-06 7:33 ` [PATCH 9/9] dt-bindings: interconnect: qcom: drop IPA_CORE related defines Dmitry Baryshkov
8 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
Similar to the sdx55 and sc7180, let's drop the IP0 interconnects here
because the IP0 resource is also used in the clk-rpmh.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/sc8280xp.c | 25 -------------------------
drivers/interconnect/qcom/sc8280xp.h | 2 --
2 files changed, 27 deletions(-)
diff --git a/drivers/interconnect/qcom/sc8280xp.c b/drivers/interconnect/qcom/sc8280xp.c
index 507fe5f89791..e56df893ec3e 100644
--- a/drivers/interconnect/qcom/sc8280xp.c
+++ b/drivers/interconnect/qcom/sc8280xp.c
@@ -284,15 +284,6 @@ static struct qcom_icc_node xm_ufs_card = {
.links = { SC8280XP_SLAVE_A2NOC_SNOC },
};
-static struct qcom_icc_node ipa_core_master = {
- .name = "ipa_core_master",
- .id = SC8280XP_MASTER_IPA_CORE,
- .channels = 1,
- .buswidth = 8,
- .num_links = 1,
- .links = { SC8280XP_SLAVE_IPA_CORE },
-};
-
static struct qcom_icc_node qup0_core_master = {
.name = "qup0_core_master",
.id = SC8280XP_MASTER_QUP_CORE_0,
@@ -882,13 +873,6 @@ static struct qcom_icc_node srvc_aggre2_noc = {
.buswidth = 4,
};
-static struct qcom_icc_node ipa_core_slave = {
- .name = "ipa_core_slave",
- .id = SC8280XP_SLAVE_IPA_CORE,
- .channels = 1,
- .buswidth = 8,
-};
-
static struct qcom_icc_node qup0_core_slave = {
.name = "qup0_core_slave",
.id = SC8280XP_SLAVE_QUP_CORE_0,
@@ -1845,12 +1829,6 @@ static struct qcom_icc_bcm bcm_cn3 = {
},
};
-static struct qcom_icc_bcm bcm_ip0 = {
- .name = "IP0",
- .num_nodes = 1,
- .nodes = { &ipa_core_slave },
-};
-
static struct qcom_icc_bcm bcm_mc0 = {
.name = "MC0",
.keepalive = true,
@@ -2077,18 +2055,15 @@ static const struct qcom_icc_desc sc8280xp_aggre2_noc = {
};
static struct qcom_icc_bcm * const clk_virt_bcms[] = {
- &bcm_ip0,
&bcm_qup0,
&bcm_qup1,
&bcm_qup2,
};
static struct qcom_icc_node * const clk_virt_nodes[] = {
- [MASTER_IPA_CORE] = &ipa_core_master,
[MASTER_QUP_CORE_0] = &qup0_core_master,
[MASTER_QUP_CORE_1] = &qup1_core_master,
[MASTER_QUP_CORE_2] = &qup2_core_master,
- [SLAVE_IPA_CORE] = &ipa_core_slave,
[SLAVE_QUP_CORE_0] = &qup0_core_slave,
[SLAVE_QUP_CORE_1] = &qup1_core_slave,
[SLAVE_QUP_CORE_2] = &qup2_core_slave,
diff --git a/drivers/interconnect/qcom/sc8280xp.h b/drivers/interconnect/qcom/sc8280xp.h
index 74d8fa412d65..1b12472ddca4 100644
--- a/drivers/interconnect/qcom/sc8280xp.h
+++ b/drivers/interconnect/qcom/sc8280xp.h
@@ -10,7 +10,6 @@
#define SC8280XP_MASTER_PCIE_TCU 1
#define SC8280XP_MASTER_SYS_TCU 2
#define SC8280XP_MASTER_APPSS_PROC 3
-#define SC8280XP_MASTER_IPA_CORE 4
#define SC8280XP_MASTER_LLCC 5
#define SC8280XP_MASTER_CNOC_LPASS_AG_NOC 6
#define SC8280XP_MASTER_CDSP_NOC_CFG 7
@@ -84,7 +83,6 @@
#define SC8280XP_MASTER_USB4_0 75
#define SC8280XP_MASTER_USB4_1 76
#define SC8280XP_SLAVE_EBI1 512
-#define SC8280XP_SLAVE_IPA_CORE 513
#define SC8280XP_SLAVE_AHB2PHY_0 514
#define SC8280XP_SLAVE_AHB2PHY_1 515
#define SC8280XP_SLAVE_AHB2PHY_2 516
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 8/9] dt-bindings: interconnect: qcom: Remove sc7180/sdx55 ipa compatibles
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
` (6 preceding siblings ...)
2023-01-06 7:33 ` [PATCH 7/9] interconnect: qcom: sc8280xp: " Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 11:09 ` Krzysztof Kozlowski
2023-01-06 7:33 ` [PATCH 9/9] dt-bindings: interconnect: qcom: drop IPA_CORE related defines Dmitry Baryshkov
8 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
These interconnects are modeled as clks, not interconnects, therefore
remove the compatibles from the binding as they're unused.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
index a429a1ed1006..4e8d950c2832 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
@@ -58,7 +58,6 @@ properties:
- qcom,sc8180x-config-noc
- qcom,sc8180x-dc-noc
- qcom,sc8180x-gem-noc
- - qcom,sc8180x-ipa-virt
- qcom,sc8180x-mc-virt
- qcom,sc8180x-mmss-noc
- qcom,sc8180x-qup-virt
@@ -96,7 +95,6 @@ properties:
- qcom,sm8150-config-noc
- qcom,sm8150-dc-noc
- qcom,sm8150-gem-noc
- - qcom,sm8150-ipa-virt
- qcom,sm8150-mc-virt
- qcom,sm8150-mmss-noc
- qcom,sm8150-system-noc
@@ -106,7 +104,6 @@ properties:
- qcom,sm8250-config-noc
- qcom,sm8250-dc-noc
- qcom,sm8250-gem-noc
- - qcom,sm8250-ipa-virt
- qcom,sm8250-mc-virt
- qcom,sm8250-mmss-noc
- qcom,sm8250-npu-noc
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 8/9] dt-bindings: interconnect: qcom: Remove sc7180/sdx55 ipa compatibles
2023-01-06 7:33 ` [PATCH 8/9] dt-bindings: interconnect: qcom: Remove sc7180/sdx55 ipa compatibles Dmitry Baryshkov
@ 2023-01-06 11:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-06 11:09 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Stephen Boyd, Michael Turquette, Rob Herring,
Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
On 06/01/2023 08:33, Dmitry Baryshkov wrote:
> These interconnects are modeled as clks, not interconnects, therefore
> remove the compatibles from the binding as they're unused.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml | 3 ---
> 1 file changed, 3 deletions(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 9/9] dt-bindings: interconnect: qcom: drop IPA_CORE related defines
2023-01-06 7:33 [PATCH 0/9] clk/interconnect: qcom: finish migration of IP0 to clocks Dmitry Baryshkov
` (7 preceding siblings ...)
2023-01-06 7:33 ` [PATCH 8/9] dt-bindings: interconnect: qcom: Remove sc7180/sdx55 ipa compatibles Dmitry Baryshkov
@ 2023-01-06 7:33 ` Dmitry Baryshkov
2023-01-06 11:09 ` Krzysztof Kozlowski
8 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2023-01-06 7:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Stephen Boyd,
Michael Turquette, Rob Herring, Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
These interconnects are modeled as clks, not interconnects, therefore
remove corresponding defines from the binding as they're unused.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
include/dt-bindings/interconnect/qcom,sc7180.h | 3 ---
include/dt-bindings/interconnect/qcom,sc8180x.h | 3 ---
include/dt-bindings/interconnect/qcom,sc8280xp.h | 2 --
include/dt-bindings/interconnect/qcom,sdx55.h | 2 --
include/dt-bindings/interconnect/qcom,sm8150.h | 3 ---
include/dt-bindings/interconnect/qcom,sm8250.h | 3 ---
6 files changed, 16 deletions(-)
diff --git a/include/dt-bindings/interconnect/qcom,sc7180.h b/include/dt-bindings/interconnect/qcom,sc7180.h
index f9970f6032eb..de5d5867bd67 100644
--- a/include/dt-bindings/interconnect/qcom,sc7180.h
+++ b/include/dt-bindings/interconnect/qcom,sc7180.h
@@ -108,9 +108,6 @@
#define SLAVE_LLCC 11
#define SLAVE_SERVICE_GEM_NOC 12
-#define MASTER_IPA_CORE 0
-#define SLAVE_IPA_CORE 1
-
#define MASTER_LLCC 0
#define SLAVE_EBI1 1
diff --git a/include/dt-bindings/interconnect/qcom,sc8180x.h b/include/dt-bindings/interconnect/qcom,sc8180x.h
index e84cfec5afdd..0bdc8d6cb401 100644
--- a/include/dt-bindings/interconnect/qcom,sc8180x.h
+++ b/include/dt-bindings/interconnect/qcom,sc8180x.h
@@ -129,9 +129,6 @@
#define SLAVE_SERVICE_GEM_NOC 16
#define SLAVE_SERVICE_GEM_NOC_1 17
-#define MASTER_IPA_CORE 0
-#define SLAVE_IPA_CORE 1
-
#define MASTER_LLCC 0
#define SLAVE_EBI_CH0 1
diff --git a/include/dt-bindings/interconnect/qcom,sc8280xp.h b/include/dt-bindings/interconnect/qcom,sc8280xp.h
index a3e5fda7c127..7440c2776415 100644
--- a/include/dt-bindings/interconnect/qcom,sc8280xp.h
+++ b/include/dt-bindings/interconnect/qcom,sc8280xp.h
@@ -48,11 +48,9 @@
#define SLAVE_SERVICE_A2NOC 19
/* clk_virt */
-#define MASTER_IPA_CORE 0
#define MASTER_QUP_CORE_0 1
#define MASTER_QUP_CORE_1 2
#define MASTER_QUP_CORE_2 3
-#define SLAVE_IPA_CORE 4
#define SLAVE_QUP_CORE_0 5
#define SLAVE_QUP_CORE_1 6
#define SLAVE_QUP_CORE_2 7
diff --git a/include/dt-bindings/interconnect/qcom,sdx55.h b/include/dt-bindings/interconnect/qcom,sdx55.h
index bfb6524a2d90..1925f0784ab2 100644
--- a/include/dt-bindings/interconnect/qcom,sdx55.h
+++ b/include/dt-bindings/interconnect/qcom,sdx55.h
@@ -70,7 +70,5 @@
#define SLAVE_QDSS_STM 48
#define SLAVE_TCU 49
-#define MASTER_IPA_CORE 0
-#define SLAVE_IPA_CORE 1
#endif
diff --git a/include/dt-bindings/interconnect/qcom,sm8150.h b/include/dt-bindings/interconnect/qcom,sm8150.h
index a25684680c42..ef292791f52e 100644
--- a/include/dt-bindings/interconnect/qcom,sm8150.h
+++ b/include/dt-bindings/interconnect/qcom,sm8150.h
@@ -121,9 +121,6 @@
#define SLAVE_LLCC 15
#define SLAVE_SERVICE_GEM_NOC 16
-#define MASTER_IPA_CORE 0
-#define SLAVE_IPA_CORE 1
-
#define MASTER_LLCC 0
#define SLAVE_EBI_CH0 1
diff --git a/include/dt-bindings/interconnect/qcom,sm8250.h b/include/dt-bindings/interconnect/qcom,sm8250.h
index 1b4d9fbe888d..a4af5cc19271 100644
--- a/include/dt-bindings/interconnect/qcom,sm8250.h
+++ b/include/dt-bindings/interconnect/qcom,sm8250.h
@@ -115,9 +115,6 @@
#define SLAVE_SERVICE_GEM_NOC_2 15
#define SLAVE_SERVICE_GEM_NOC 16
-#define MASTER_IPA_CORE 0
-#define SLAVE_IPA_CORE 1
-
#define MASTER_LLCC 0
#define SLAVE_EBI_CH0 1
--
2.39.0
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 9/9] dt-bindings: interconnect: qcom: drop IPA_CORE related defines
2023-01-06 7:33 ` [PATCH 9/9] dt-bindings: interconnect: qcom: drop IPA_CORE related defines Dmitry Baryshkov
@ 2023-01-06 11:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-06 11:09 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Stephen Boyd, Michael Turquette, Rob Herring,
Krzysztof Kozlowski, Taniya Das
Cc: Georgi Djakov, Odelu Kukatla, Alex Elder, Johan Hovold,
linux-arm-msm, linux-clk, linux-pm, devicetree
On 06/01/2023 08:33, Dmitry Baryshkov wrote:
> These interconnects are modeled as clks, not interconnects, therefore
> remove corresponding defines from the binding as they're unused.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> include/dt-bindings/interconnect/qcom,sc7180.h | 3 ---
> include/dt-bindings/interconnect/qcom,sc8180x.h | 3 ---
> include/dt-bindings/interconnect/qcom,sc8280xp.h | 2 --
> include/dt-bindings/interconnect/qcom,sdx55.h | 2 --
> include/dt-bindings/interconnect/qcom,sm8150.h | 3 ---
> include/dt-bindings/interconnect/qcom,sm8250.h | 3 ---
> 6 files changed, 16 deletions(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread