From: "Leonardo Brás" <leobras@redhat.com> To: Conor Dooley <conor@kernel.org> Cc: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/6] Deduplicating RISCV cmpxchg.h macros Date: Tue, 21 Mar 2023 03:30:35 -0300 [thread overview] Message-ID: <4f35f41c143b02b6b815e7eb527ca3acd8b4aabe.camel@redhat.com> (raw) In-Reply-To: <8f698f49-135a-4263-8471-96f406919cb1@spud> Hello Conor, thanks for the feedback! On Sun, 2023-03-19 at 20:35 +0000, Conor Dooley wrote: > On Sat, Mar 18, 2023 at 05:00:54AM -0300, Leonardo Bras wrote: > > While studying riscv's cmpxchg.h file, I got really interested in > > understanding how RISCV asm implemented the different versions of > > {cmp,}xchg. > > > > When I understood the pattern, it made sense for me to remove the > > duplications and create macros to make it easier to understand what exactly > > changes between the versions: Instruction sufixes & barriers. > > > > I split those changes in 3 levels for each cmpxchg and xchg, resulting a > > total of 6 patches. I did this so it becomes easier to review and remove > > the last levels if desired, but I have no issue squashing them if it's > > better. > > > > Please provide comments. > > > > Thanks! > > Leo > > > > Leonardo Bras (6): > > riscv/cmpxchg: Deduplicate cmpxchg() asm functions > > riscv/cmpxchg: Deduplicate cmpxchg() macros > > riscv/cmpxchg: Deduplicate arch_cmpxchg() macros > > > riscv/cmpxchg: Deduplicate xchg() asm functions > > FWIW, this patch seems to break the build pretty badly: > https://patchwork.kernel.org/project/linux-riscv/patch/20230318080059.1109286-5-leobras@redhat.com/ Thanks for pointing out! It was an intermediary error: Sufix for amoswap on acquire version was "d.aqrl" instead of the correct".d.aqrl", and that caused the fail. I did not notice anything because the next commit made it more general, and thus removed this line of code. I will send a v2-RFC shortly. I see that patch 4/6 has 5 fails, but on each one of them I can see: "I: build output in /ci/workspace/[...]", or ""I: build output in /tmp/[...]". I could not find any reference to where this is saved, though. Could you point where can I find the error output, just for the sake of further debugging? > > Patches 1 & 5 also add quite a lot of sparse issues (like 1000), but I > think that may be more of an artifact of the testing process as opposed > to something caused by this patchset. For those I can see the build output diffs. Both added error lines to conchuod/build_rv64_gcc_allmodconfig. I tried to mimic this with [make allmodconfig + gcc build with CROSS_COMPILE=riscv64-linux-gnu- ] but I could not get any error in any patch. For patch 1/6 it removes as much error lines (-) as it adds (+), and the error messages are mostly the same, apart for an line number. For patch 5/6 it actually adds many more lines, but tracking (some of) the errors gave me no idea why. > > Cheers, > Conor. Thanks a lot! Leo
WARNING: multiple messages have this Message-ID (diff)
From: "Leonardo Brás" <leobras@redhat.com> To: Conor Dooley <conor@kernel.org> Cc: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/6] Deduplicating RISCV cmpxchg.h macros Date: Tue, 21 Mar 2023 03:30:35 -0300 [thread overview] Message-ID: <4f35f41c143b02b6b815e7eb527ca3acd8b4aabe.camel@redhat.com> (raw) In-Reply-To: <8f698f49-135a-4263-8471-96f406919cb1@spud> Hello Conor, thanks for the feedback! On Sun, 2023-03-19 at 20:35 +0000, Conor Dooley wrote: > On Sat, Mar 18, 2023 at 05:00:54AM -0300, Leonardo Bras wrote: > > While studying riscv's cmpxchg.h file, I got really interested in > > understanding how RISCV asm implemented the different versions of > > {cmp,}xchg. > > > > When I understood the pattern, it made sense for me to remove the > > duplications and create macros to make it easier to understand what exactly > > changes between the versions: Instruction sufixes & barriers. > > > > I split those changes in 3 levels for each cmpxchg and xchg, resulting a > > total of 6 patches. I did this so it becomes easier to review and remove > > the last levels if desired, but I have no issue squashing them if it's > > better. > > > > Please provide comments. > > > > Thanks! > > Leo > > > > Leonardo Bras (6): > > riscv/cmpxchg: Deduplicate cmpxchg() asm functions > > riscv/cmpxchg: Deduplicate cmpxchg() macros > > riscv/cmpxchg: Deduplicate arch_cmpxchg() macros > > > riscv/cmpxchg: Deduplicate xchg() asm functions > > FWIW, this patch seems to break the build pretty badly: > https://patchwork.kernel.org/project/linux-riscv/patch/20230318080059.1109286-5-leobras@redhat.com/ Thanks for pointing out! It was an intermediary error: Sufix for amoswap on acquire version was "d.aqrl" instead of the correct".d.aqrl", and that caused the fail. I did not notice anything because the next commit made it more general, and thus removed this line of code. I will send a v2-RFC shortly. I see that patch 4/6 has 5 fails, but on each one of them I can see: "I: build output in /ci/workspace/[...]", or ""I: build output in /tmp/[...]". I could not find any reference to where this is saved, though. Could you point where can I find the error output, just for the sake of further debugging? > > Patches 1 & 5 also add quite a lot of sparse issues (like 1000), but I > think that may be more of an artifact of the testing process as opposed > to something caused by this patchset. For those I can see the build output diffs. Both added error lines to conchuod/build_rv64_gcc_allmodconfig. I tried to mimic this with [make allmodconfig + gcc build with CROSS_COMPILE=riscv64-linux-gnu- ] but I could not get any error in any patch. For patch 1/6 it removes as much error lines (-) as it adds (+), and the error messages are mostly the same, apart for an line number. For patch 5/6 it actually adds many more lines, but tracking (some of) the errors gave me no idea why. > > Cheers, > Conor. Thanks a lot! Leo _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-03-21 6:31 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-18 8:00 [RFC PATCH 0/6] Deduplicating RISCV cmpxchg.h macros Leonardo Bras 2023-03-18 8:00 ` Leonardo Bras 2023-03-18 8:00 ` [RFC PATCH 1/6] riscv/cmpxchg: Deduplicate cmpxchg() asm functions Leonardo Bras 2023-03-18 8:00 ` Leonardo Bras 2023-03-18 8:00 ` [RFC PATCH 2/6] riscv/cmpxchg: Deduplicate cmpxchg() macros Leonardo Bras 2023-03-18 8:00 ` Leonardo Bras 2023-03-18 8:00 ` [RFC PATCH 3/6] riscv/cmpxchg: Deduplicate arch_cmpxchg() macros Leonardo Bras 2023-03-18 8:00 ` Leonardo Bras 2023-03-18 8:00 ` [RFC PATCH 4/6] riscv/cmpxchg: Deduplicate xchg() asm functions Leonardo Bras 2023-03-18 8:00 ` Leonardo Bras 2023-03-18 8:00 ` [RFC PATCH 5/6] riscv/cmpxchg: Deduplicate xchg() macros Leonardo Bras 2023-03-18 8:00 ` Leonardo Bras 2023-03-18 8:01 ` [RFC PATCH 6/6] riscv/cmpxchg: Deduplicate arch_xchg() macros Leonardo Bras 2023-03-18 8:01 ` Leonardo Bras 2023-03-19 20:35 ` [RFC PATCH 0/6] Deduplicating RISCV cmpxchg.h macros Conor Dooley 2023-03-19 20:35 ` Conor Dooley 2023-03-21 6:30 ` Leonardo Brás [this message] 2023-03-21 6:30 ` Leonardo Brás 2023-03-21 7:48 ` Conor Dooley 2023-03-21 7:48 ` Conor Dooley 2023-03-21 17:01 ` Leonardo Bras Soares Passos 2023-03-21 17:01 ` Leonardo Bras Soares Passos 2023-03-21 19:48 ` Conor Dooley 2023-03-21 19:48 ` Conor Dooley 2023-03-22 3:42 ` Leonardo Bras Soares Passos 2023-03-22 3:42 ` Leonardo Bras Soares Passos 2023-03-22 7:56 ` Conor Dooley 2023-03-22 7:56 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4f35f41c143b02b6b815e7eb527ca3acd8b4aabe.camel@redhat.com \ --to=leobras@redhat.com \ --cc=aou@eecs.berkeley.edu \ --cc=conor@kernel.org \ --cc=guoren@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.