Re: [PATCH] Improve d-bus error message on iwctl

[Jimin Kim <dayo05 at daum.net>]

[-- Attachment #1: Type: text/plain, Size: 2021 bytes --]


Hi,

On 4/2/22 01:41, James Prestwood wrote:
> Hi,
>
>>>
>> Ok. Then how about changing the message to "Check yourself exists on 
>> netdev usergroup". I know this error is able to happen with other 
>> reason. But this error can showed by newbie or users who is not 
>> friendly with linux. And also, d-bus error message is not friendly 
>> for normal users. So Adding additional information on error messageis 
>> need.
>>
>
> Yes something like "check that user is in the netdev group" would be 
> better. We'll have to see what others think. Whether we take this 
> option or just choose to add something to the wiki (and I'll go ahead 
> and do this anyways).

  I've thought about that and d-bus error message is not user-friendly 
and this error can showed with normal using and figured out this caused 
by broken change commit. And also if error is not showed by this reason, 
this will be important issue. Thats why I didn't remove previous dbus 
error message.

  Wiki is good place to locate information. But many users don't know 
iwd wiki exists because this program has pre-installed to many linux 
distros. So I think show this short information is required.

> I've also CC'd the list back in, make sure you reply all so others can 
> see the coversation.
>
>>
>> Jimin Kim.
>>
>>
>
This is the new patch.

Jimin Kim.


---
  client/dbus-proxy.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/client/dbus-proxy.c b/client/dbus-proxy.c
index 0373a3df..8cad3ece 100644
--- a/client/dbus-proxy.c
+++ b/client/dbus-proxy.c
@@ -722,6 +722,7 @@ static void get_managed_objects_callback(struct 
l_dbus_message *message,
      if (dbus_message_has_error(message)) {
          display_error("Failed to retrieve IWD dbus objects, "
                              "quitting...\n");
+        display("Check yourself exists on netdev usergroup.\n");

          goto error;
      }
-- 
2.35.1



[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 4155 bytes --]