Re: [PATCH] Improve d-bus error message on iwctl

[James Prestwood <prestwoj at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]

Hi,

On Thu, 2022-03-31 at 17:10 +0900, Dayo wrote:
> I got error of 
> Rejected send message, 2 matched rules; type="method_call",
> sender=":1.137" (uid=1000 pid=14325 comm="client/iwctl")
> interface="org.freedesktop.DBus.ObjectManager"
> member="GetManagedObjects" error name="(unset)" requested_reply="0"
> destination="net.connman.iwd" (uid=0 pid=354 comm="/usr/lib/iwd/iwd")
> in execution of iwctl without sudo. But when I tried to search that,
> It has low information in google but I solve the issue as executing
> with sudo. So this is very small change but this will improve this
> software.
> 
> ps. I get issue in linux kernel 5.16 and later, including 5.17.x

This is actually result of removing  'at_console' from the dbus
configuration which we did a couple releases ago. The fix here is to
add your user to the netdev group if you don't want to run with root.
I'm not sure we want this debug print as-is for a few reasons. First
being that it should explain the netdev group requirement rather than
'root permission'. And second that this could be an error for any
number of reasons, not necissarily because of permissions.

https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=010b0e27f98442ad9366ecdcb09601f92334c293

> 
> 
> ---
>  client/dbus-proxy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/client/dbus-proxy.c b/client/dbus-proxy.c
> index 0373a3df..8cad3ece 100644
> --- a/client/dbus-proxy.c
> +++ b/client/dbus-proxy.c
> @@ -722,6 +722,7 @@ static void get_managed_objects_callback(struct
> l_dbus_message *message,
>      if (dbus_message_has_error(message)) {
>          display_error("Failed to retrieve IWD dbus objects, "
>                              "quitting...\n");
> +        display("Execute iwctl with root permission is the one way
> to solve this issue.\n");
>  
>          goto error;
>      }
> _______________________________________________
> iwd mailing list -- iwd(a)lists.01.org
> To unsubscribe send an email to iwd-leave(a)lists.01.org


[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 3318 bytes --]