[PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

[PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

[Kangjie Lu]

If ixgbevf_write_msg_read_ack fails, return its error code upstream

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
 drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
index cd3b81300cc7..d5ce49636548 100644
--- a/drivers/net/ethernet/intel/ixgbevf/vf.c
+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
@@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
 		vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
 	}
 
-	ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
-
-	return 0;
+	return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
+			IXGBE_VFMAILBOX_SIZE);
 }
 
 /**
-- 
2.17.1

[Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

[Kangjie Lu]

If ixgbevf_write_msg_read_ack fails, return its error code upstream

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
 drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
index cd3b81300cc7..d5ce49636548 100644
--- a/drivers/net/ethernet/intel/ixgbevf/vf.c
+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
@@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
 		vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
 	}
 
-	ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
-
-	return 0;
+	return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
+			IXGBE_VFMAILBOX_SIZE);
 }
 
 /**
-- 
2.17.1

RE: [Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> Behalf Of Kangjie Lu
> Sent: Friday, March 8, 2019 7:31 PM
> To: kjlu@umn.edu
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired-
> lan@lists.osuosl.org; pakki001@umn.edu; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of
> ixgbevf_write_msg_read_ack
> 
> If ixgbevf_write_msg_read_ack fails, return its error code upstream
> 
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

[Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Kangjie Lu
> Sent: Friday, March 8, 2019 7:31 PM
> To: kjlu at umn.edu
> Cc: netdev at vger.kernel.org; linux-kernel at vger.kernel.org; intel-wired-
> lan at lists.osuosl.org; pakki001 at umn.edu; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of
> ixgbevf_write_msg_read_ack
> 
> If ixgbevf_write_msg_read_ack fails, return its error code upstream
> 
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

[Intel-wired-lan] [PATCH] net: ixgbevf: fix a missing check of ixgbevf_write_msg_read_ack

[Mukesh Ojha]

On 3/9/2019 9:01 AM, Kangjie Lu wrote:
> If ixgbevf_write_msg_read_ack fails, return its error code upstream
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>   drivers/net/ethernet/intel/ixgbevf/vf.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
> index cd3b81300cc7..d5ce49636548 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/vf.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
> @@ -508,9 +508,8 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,
>   		vector_list[i++] = ixgbevf_mta_vector(hw, ha->addr);
>   	}
>   
> -	ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, IXGBE_VFMAILBOX_SIZE);
> -
> -	return 0;
> +	return ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,
> +			IXGBE_VFMAILBOX_SIZE);


Reviewed-by: Mukesh Ojha <mojha at codeaurora.org 
<mailto:mojha@codeaurora.org>>

Thanks,
Mukesh

>   }
>   
>   /**
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20190322/eecc7cca/attachment.html>