* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 12:31 [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items Geert Uytterhoeven
@ 2022-02-24 12:55 ` Conor.Dooley
2022-02-24 12:58 ` Geert Uytterhoeven
2022-02-24 13:44 ` Rob Herring
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Conor.Dooley @ 2022-02-24 12:55 UTC (permalink / raw)
To: geert, wsa, Daire.McNamara
Cc: robh+dt, krzysztof.kozlowski, linux-i2c, devicetree, linux-kernel
On 24/02/2022 12:31, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> make dt_binding_check:
>
> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
Hey Geert,
I've run dt_binding_check locally but I dont get a warning, is there
something I am missing?
Thanks,
Conor.
>
> Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml
> index c8e605fbb8a6b3d0..7bad4b946a349c8b 100644
> --- a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml
> @@ -16,8 +16,8 @@ properties:
> compatible:
> oneOf:
> - items:
> - - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs
> - - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core
> + - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs
> + - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core
> - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core
>
> reg:
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 12:55 ` Conor.Dooley
@ 2022-02-24 12:58 ` Geert Uytterhoeven
2022-02-24 13:15 ` Conor.Dooley
0 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2022-02-24 12:58 UTC (permalink / raw)
To: Conor Dooley
Cc: Wolfram Sang, Daire.McNamara, Rob Herring, Krzysztof Kozlowski,
Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Conor,
On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > make dt_binding_check:
> >
> > Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>
> Hey Geert,
> I've run dt_binding_check locally but I dont get a warning, is there
> something I am missing?
Interesting. Are you using the latest dtschema?
https://github.com/devicetree-org/dt-schema.git
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 12:58 ` Geert Uytterhoeven
@ 2022-02-24 13:15 ` Conor.Dooley
2022-02-24 13:34 ` Geert Uytterhoeven
0 siblings, 1 reply; 11+ messages in thread
From: Conor.Dooley @ 2022-02-24 13:15 UTC (permalink / raw)
To: geert
Cc: wsa, Daire.McNamara, robh+dt, krzysztof.kozlowski, linux-i2c,
devicetree, linux-kernel
On 24/02/2022 12:58, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Conor,
>
> On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
>> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> make dt_binding_check:
>>>
>>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>>
>> Hey Geert,
>> I've run dt_binding_check locally but I dont get a warning, is there
>> something I am missing?
>
> Interesting. Are you using the latest dtschema?
> https://github.com/devicetree-org/dt-schema.git
I was on v2021.12, but have now tried v2022.01 & master
(2022.2.dev1+gf677c85).
Is there something other than running "make dt_binding_check" in a fresh
checkout that I need to do?
Thanks,
Conor.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 13:15 ` Conor.Dooley
@ 2022-02-24 13:34 ` Geert Uytterhoeven
2022-02-24 13:43 ` Rob Herring
2022-02-24 13:49 ` Conor Dooley
0 siblings, 2 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2022-02-24 13:34 UTC (permalink / raw)
To: Conor Dooley
Cc: Wolfram Sang, Daire.McNamara, Rob Herring, Krzysztof Kozlowski,
Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Conor,
On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote:
> On 24/02/2022 12:58, Geert Uytterhoeven wrote:
> > On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
> >> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
> >>> make dt_binding_check:
> >>>
> >>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> >>
> >> Hey Geert,
> >> I've run dt_binding_check locally but I dont get a warning, is there
> >> something I am missing?
> >
> > Interesting. Are you using the latest dtschema?
> > https://github.com/devicetree-org/dt-schema.git
>
> I was on v2021.12, but have now tried v2022.01 & master
> (2022.2.dev1+gf677c85).
>
> Is there something other than running "make dt_binding_check" in a fresh
> checkout that I need to do?
You did update your installation after the fresh[1] checkout?
$ cd dt-schema
$ pip3 install -e .
[1] What about "git pull"? ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 13:34 ` Geert Uytterhoeven
@ 2022-02-24 13:43 ` Rob Herring
2022-02-24 13:51 ` Conor Dooley
2022-02-24 13:49 ` Conor Dooley
1 sibling, 1 reply; 11+ messages in thread
From: Rob Herring @ 2022-02-24 13:43 UTC (permalink / raw)
To: Geert Uytterhoeven, Conor Dooley
Cc: Wolfram Sang, Daire.McNamara, Krzysztof Kozlowski, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Thu, Feb 24, 2022 at 02:34:18PM +0100, Geert Uytterhoeven wrote:
> Hi Conor,
>
> On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote:
> > On 24/02/2022 12:58, Geert Uytterhoeven wrote:
> > > On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
> > >> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
> > >>> make dt_binding_check:
> > >>>
> > >>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> > >>
> > >> Hey Geert,
> > >> I've run dt_binding_check locally but I dont get a warning, is there
> > >> something I am missing?
> > >
> > > Interesting. Are you using the latest dtschema?
> > > https://github.com/devicetree-org/dt-schema.git
> >
> > I was on v2021.12, but have now tried v2022.01 & master
> > (2022.2.dev1+gf677c85).
> >
> > Is there something other than running "make dt_binding_check" in a fresh
> > checkout that I need to do?
>
> You did update your installation after the fresh[1] checkout?
>
> $ cd dt-schema
> $ pip3 install -e .
>
> [1] What about "git pull"? ;-)
yamllint is not installed. It's optional from the kbuild perspective.
Rob
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 13:43 ` Rob Herring
@ 2022-02-24 13:51 ` Conor Dooley
0 siblings, 0 replies; 11+ messages in thread
From: Conor Dooley @ 2022-02-24 13:51 UTC (permalink / raw)
To: Rob Herring, Geert Uytterhoeven, Conor Dooley
Cc: Wolfram Sang, Daire.McNamara, Krzysztof Kozlowski, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On 24/02/2022 13:43, Rob Herring wrote:
> On Thu, Feb 24, 2022 at 02:34:18PM +0100, Geert Uytterhoeven wrote:
>> Hi Conor,
>>
>> On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote:
>>> On 24/02/2022 12:58, Geert Uytterhoeven wrote:
>>>> On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
>>>>> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
>>>>>> make dt_binding_check:
>>>>>>
>>>>>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>>>>>
>>>>> Hey Geert,
>>>>> I've run dt_binding_check locally but I dont get a warning, is there
>>>>> something I am missing?
>>>>
>>>> Interesting. Are you using the latest dtschema?
>>>> https://github.com/devicetree-org/dt-schema.git
>>>
>>> I was on v2021.12, but have now tried v2022.01 & master
>>> (2022.2.dev1+gf677c85).
>>>
>>> Is there something other than running "make dt_binding_check" in a fresh
>>> checkout that I need to do?
>>
>> You did update your installation after the fresh[1] checkout?
>>
>> $ cd dt-schema
>> $ pip3 install -e .
>>
>> [1] What about "git pull"? ;-)
>
> yamllint is not installed. It's optional from the kbuild perspective.
Safe to say I won't forget yamllint next time I do an os reinstall..
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 13:34 ` Geert Uytterhoeven
2022-02-24 13:43 ` Rob Herring
@ 2022-02-24 13:49 ` Conor Dooley
1 sibling, 0 replies; 11+ messages in thread
From: Conor Dooley @ 2022-02-24 13:49 UTC (permalink / raw)
To: Geert Uytterhoeven, Conor Dooley
Cc: Wolfram Sang, Daire.McNamara, Rob Herring, Krzysztof Kozlowski,
Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On 24/02/2022 13:34, Geert Uytterhoeven wrote:
> Hi Conor,
>
> On Thu, Feb 24, 2022 at 2:15 PM <Conor.Dooley@microchip.com> wrote:
>> On 24/02/2022 12:58, Geert Uytterhoeven wrote:
>>> On Thu, Feb 24, 2022 at 1:55 PM <Conor.Dooley@microchip.com> wrote:
>>>> On 24/02/2022 12:31, Geert Uytterhoeven wrote:
>>>>> make dt_binding_check:
>>>>>
>>>>> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>>>>
>>>> Hey Geert,
>>>> I've run dt_binding_check locally but I dont get a warning, is there
>>>> something I am missing?
>>>
>>> Interesting. Are you using the latest dtschema?
>>> https://github.com/devicetree-org/dt-schema.git
>>
>> I was on v2021.12, but have now tried v2022.01 & master
>> (2022.2.dev1+gf677c85).
>>
>> Is there something other than running "make dt_binding_check" in a fresh
>> checkout that I need to do?
>
> You did update your installation after the fresh[1] checkout?
>
> $ cd dt-schema
> $ pip3 install -e .
>
> [1] What about "git pull"? ;-)
>
I went for the option of "pip3 install
git+https://github.com/devicetree-org/dt-schema.git@master"
If I alter check_dtschema_version to spit out the version, its as
expected. The checkout was of Linux not the dt-schema.
I have found the issue however, realised just before Rob pointed it out
that I missed yamllint when I reinstalled my OS recently.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 12:31 [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items Geert Uytterhoeven
2022-02-24 12:55 ` Conor.Dooley
@ 2022-02-24 13:44 ` Rob Herring
2022-03-01 7:52 ` Conor.Dooley
2022-03-01 15:03 ` Wolfram Sang
3 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-02-24 13:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Wolfram Sang, Conor Dooley, Daire McNamara, Krzysztof Kozlowski,
linux-i2c, devicetree, linux-kernel
On Thu, Feb 24, 2022 at 01:31:21PM +0100, Geert Uytterhoeven wrote:
> make dt_binding_check:
>
> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>
> Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 12:31 [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items Geert Uytterhoeven
2022-02-24 12:55 ` Conor.Dooley
2022-02-24 13:44 ` Rob Herring
@ 2022-03-01 7:52 ` Conor.Dooley
2022-03-01 15:03 ` Wolfram Sang
3 siblings, 0 replies; 11+ messages in thread
From: Conor.Dooley @ 2022-03-01 7:52 UTC (permalink / raw)
To: geert, wsa, Daire.McNamara
Cc: robh+dt, krzysztof.kozlowski, linux-i2c, devicetree, linux-kernel
On 24/02/2022 12:31, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> make dt_binding_check:
>
> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>
> Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
I assume its not required given Rob's, but FWIW:
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml
> index c8e605fbb8a6b3d0..7bad4b946a349c8b 100644
> --- a/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml
> @@ -16,8 +16,8 @@ properties:
> compatible:
> oneOf:
> - items:
> - - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs
> - - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core
> + - const: microchip,mpfs-i2c # Microchip PolarFire SoC compatible SoCs
> + - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core
> - const: microchip,corei2c-rtl-v7 # Microchip Fabric based i2c IP core
>
> reg:
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items
2022-02-24 12:31 [PATCH] dt-bindings: i2c: microchip,corei2c: Fix indentation of compatible items Geert Uytterhoeven
` (2 preceding siblings ...)
2022-03-01 7:52 ` Conor.Dooley
@ 2022-03-01 15:03 ` Wolfram Sang
3 siblings, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2022-03-01 15:03 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Conor Dooley, Daire McNamara, Rob Herring, Krzysztof Kozlowski,
linux-i2c, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
On Thu, Feb 24, 2022 at 01:31:21PM +0100, Geert Uytterhoeven wrote:
> make dt_binding_check:
>
> Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>
> Fixes: f1bd6661946b20d1 ("dt-bindings: i2c: add bindings for microchip mpfs i2c")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread