All of lore.kernel.org
 help / color / mirror / Atom feed
* [RAISIN] Allow-running-tests-as-non-root
@ 2017-03-01 21:10 Gémes Géza
  2017-03-02  1:11 ` Stefano Stabellini
  0 siblings, 1 reply; 2+ messages in thread
From: Gémes Géza @ 2017-03-01 21:10 UTC (permalink / raw)
  To: xen-devel, Stefano Stabellini, George Dunlap

[-- Attachment #1: Type: text/plain, Size: 90 bytes --]

Hi,

The attached patch allows running the raisin tests as non-root user.

Cheers,

Geza


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Allow-running-tests-as-non-root.patch --]
[-- Type: text/x-patch; name="0001-Allow-running-tests-as-non-root.patch", Size: 3428 bytes --]

>From 8a1227d96697a4d8be9130fd9b16404decbe7605 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?G=C3=A9za=20G=C3=A9mes?= <geza.gemes@gmail.com>
Date: Wed, 1 Mar 2017 18:39:51 +0100
Subject: [PATCH] Allow running tests as non-root
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Allow a user with sudo rights to run the tests

Signed-off-by: Géza Gémes <geza.gemes@gmail.com>
---
 lib/common-tests.sh | 50 ++++++++++++++++++++++++++++----------------------
 1 file changed, 28 insertions(+), 22 deletions(-)

diff --git a/lib/common-tests.sh b/lib/common-tests.sh
index 0e51539..d346af4 100644
--- a/lib/common-tests.sh
+++ b/lib/common-tests.sh
@@ -54,18 +54,18 @@ function busybox_rootfs() {
 
     tmpdir=`mktemp -d`
     $SUDO mount $dev $tmpdir
-    mkdir -p $tmpdir/bin
-    mkdir -p $tmpdir/sbin
-    mkdir -p $tmpdir/dev
-    mkdir -p $tmpdir/proc
-    mkdir -p $tmpdir/sys
-    mkdir -p $tmpdir/lib
-    mkdir -p $tmpdir/var
-    cp `which busybox` $tmpdir/bin
-    $tmpdir/bin/busybox --install $tmpdir/bin
+    $SUDO mkdir -p $tmpdir/bin
+    $SUDO mkdir -p $tmpdir/sbin
+    $SUDO mkdir -p $tmpdir/dev
+    $SUDO mkdir -p $tmpdir/proc
+    $SUDO mkdir -p $tmpdir/sys
+    $SUDO mkdir -p $tmpdir/lib
+    $SUDO mkdir -p $tmpdir/var
+    $SUDO cp `which busybox` $tmpdir/bin
+    $SUDO $tmpdir/bin/busybox --install $tmpdir/bin
 
     $SUDO umount $tmpdir
-    rmdir $tmpdir
+    $SUDO rmdir $tmpdir
 }
 
 function busybox_network_init() {
@@ -76,18 +76,20 @@ function busybox_network_init() {
     tmpdir=`mktemp -d`
 
     $SUDO mount $dev $tmpdir
-    rm -f $tmpdir/bin/init
-    cat >$tmpdir/bin/init <<EOF
+    $SUDO rm -f $tmpdir/bin/init
+    tmpinit=`mktemp`
+    cat >$tmpinit <<EOF
 #!/bin/sh
 mount -t proc proc /proc
 mount -t sysfs sysfs /sys
 ifconfig eth0 169.254.0.2 up
 /bin/sh
 EOF
-    chmod +x $tmpdir/bin/init
+    $SUDO mv $tmpinit $tmpdir/bin/init
+    $SUDO chmod +x $tmpdir/bin/init
 
     $SUDO umount $tmpdir
-    rmdir $tmpdir
+    $SUDO rmdir $tmpdir
 }
 
 function bootloader_init() {
@@ -100,10 +102,11 @@ function bootloader_init() {
     tmpdir=`mktemp -d`
 
     $SUDO mount $devp $tmpdir
-    mkdir -p $tmpdir/boot/grub
-    cp "`get_host_kernel`" $tmpdir/boot
-    cp "`get_host_initrd`" $tmpdir/boot || true
-    cat >$tmpdir/boot/grub/grub.cfg <<EOF
+    $SUDO mkdir -p $tmpdir/boot/grub
+    $SUDO cp "`get_host_kernel`" $tmpdir/boot
+    $SUDO cp "`get_host_initrd`" $tmpdir/boot || true
+    tmpgrubcfg=`mktemp`
+    cat >$tmpgrubcfg <<EOF
 set default="0"
 set timeout=0
 
@@ -111,16 +114,19 @@ menuentry 'Xen Guest' {
  set root=hd0,1
  linux `get_host_kernel` root=/dev/xvda1 console=ttyS0
 EOF
+    $SUDO mv $tmpgrubcfg $tmpdir/boot/grub/grub.cfg
     if [[ -e `get_host_initrd` ]]
     then
-        echo "initrd `get_host_initrd`" >> $tmpdir/boot/grub/grub.cfg
+        $SUDO echo "initrd `get_host_initrd`" >> $tmpdir/boot/grub/grub.cfg
     fi
-    echo "}" >> $tmpdir/boot/grub/grub.cfg
+    $SUDO echo "}" >> $tmpdir/boot/grub/grub.cfg
 
-    cat >$tmpdir/boot/grub/device.map <<EOF
+    tmpgrubdevmap=`mktemp`
+    cat >$tmpgrubdevmap <<EOF
 (hd0)   $dev
 (hd0,1) $devp
 EOF
+    $SUDO mv $tmpgrubdevmap $tmpdir/boot/grub/device.map
 
     if [[ $DISTRO = "Debian" ]]
     then
@@ -137,7 +143,7 @@ EOF
     fi
 
     $SUDO umount $tmpdir
-    rmdir $tmpdir
+    $SUDO rmdir $tmpdir
 }
 
 function check_guest_alive() {
-- 
2.7.4


[-- Attachment #3: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RAISIN] Allow-running-tests-as-non-root
  2017-03-01 21:10 [RAISIN] Allow-running-tests-as-non-root Gémes Géza
@ 2017-03-02  1:11 ` Stefano Stabellini
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2017-03-02  1:11 UTC (permalink / raw)
  To: Gémes Géza; +Cc: xen-devel, Stefano Stabellini, George Dunlap

[-- Attachment #1: Type: TEXT/PLAIN, Size: 3556 bytes --]

> From: Gémes Géza <geza.gemes@gmail.com>
> Date: Wed, 1 Mar 2017 18:39:51 +0100
> Subject: [PATCH] Allow running tests as non-root
> 
> Allow a user with sudo rights to run the tests
> 
> Signed-off-by: Gémes Géza <geza.gemes@gmail.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

I'll commit.

> ---
>  lib/common-tests.sh | 50 ++++++++++++++++++++++++++++----------------------
>  1 file changed, 28 insertions(+), 22 deletions(-)
> 
> diff --git a/lib/common-tests.sh b/lib/common-tests.sh
> index 0e51539..d346af4 100644
> --- a/lib/common-tests.sh
> +++ b/lib/common-tests.sh
> @@ -54,18 +54,18 @@ function busybox_rootfs() {
>  
>      tmpdir=`mktemp -d`
>      $SUDO mount $dev $tmpdir
> -    mkdir -p $tmpdir/bin
> -    mkdir -p $tmpdir/sbin
> -    mkdir -p $tmpdir/dev
> -    mkdir -p $tmpdir/proc
> -    mkdir -p $tmpdir/sys
> -    mkdir -p $tmpdir/lib
> -    mkdir -p $tmpdir/var
> -    cp `which busybox` $tmpdir/bin
> -    $tmpdir/bin/busybox --install $tmpdir/bin
> +    $SUDO mkdir -p $tmpdir/bin
> +    $SUDO mkdir -p $tmpdir/sbin
> +    $SUDO mkdir -p $tmpdir/dev
> +    $SUDO mkdir -p $tmpdir/proc
> +    $SUDO mkdir -p $tmpdir/sys
> +    $SUDO mkdir -p $tmpdir/lib
> +    $SUDO mkdir -p $tmpdir/var
> +    $SUDO cp `which busybox` $tmpdir/bin
> +    $SUDO $tmpdir/bin/busybox --install $tmpdir/bin
>  
>      $SUDO umount $tmpdir
> -    rmdir $tmpdir
> +    $SUDO rmdir $tmpdir
>  }
>  
>  function busybox_network_init() {
> @@ -76,18 +76,20 @@ function busybox_network_init() {
>      tmpdir=`mktemp -d`
>  
>      $SUDO mount $dev $tmpdir
> -    rm -f $tmpdir/bin/init
> -    cat >$tmpdir/bin/init <<EOF
> +    $SUDO rm -f $tmpdir/bin/init
> +    tmpinit=`mktemp`
> +    cat >$tmpinit <<EOF
>  #!/bin/sh
>  mount -t proc proc /proc
>  mount -t sysfs sysfs /sys
>  ifconfig eth0 169.254.0.2 up
>  /bin/sh
>  EOF
> -    chmod +x $tmpdir/bin/init
> +    $SUDO mv $tmpinit $tmpdir/bin/init
> +    $SUDO chmod +x $tmpdir/bin/init
>  
>      $SUDO umount $tmpdir
> -    rmdir $tmpdir
> +    $SUDO rmdir $tmpdir
>  }
>  
>  function bootloader_init() {
> @@ -100,10 +102,11 @@ function bootloader_init() {
>      tmpdir=`mktemp -d`
>  
>      $SUDO mount $devp $tmpdir
> -    mkdir -p $tmpdir/boot/grub
> -    cp "`get_host_kernel`" $tmpdir/boot
> -    cp "`get_host_initrd`" $tmpdir/boot || true
> -    cat >$tmpdir/boot/grub/grub.cfg <<EOF
> +    $SUDO mkdir -p $tmpdir/boot/grub
> +    $SUDO cp "`get_host_kernel`" $tmpdir/boot
> +    $SUDO cp "`get_host_initrd`" $tmpdir/boot || true
> +    tmpgrubcfg=`mktemp`
> +    cat >$tmpgrubcfg <<EOF
>  set default="0"
>  set timeout=0
>  
> @@ -111,16 +114,19 @@ menuentry 'Xen Guest' {
>   set root=hd0,1
>   linux `get_host_kernel` root=/dev/xvda1 console=ttyS0
>  EOF
> +    $SUDO mv $tmpgrubcfg $tmpdir/boot/grub/grub.cfg
>      if [[ -e `get_host_initrd` ]]
>      then
> -        echo "initrd `get_host_initrd`" >> $tmpdir/boot/grub/grub.cfg
> +        $SUDO echo "initrd `get_host_initrd`" >> $tmpdir/boot/grub/grub.cfg
>      fi
> -    echo "}" >> $tmpdir/boot/grub/grub.cfg
> +    $SUDO echo "}" >> $tmpdir/boot/grub/grub.cfg
>  
> -    cat >$tmpdir/boot/grub/device.map <<EOF
> +    tmpgrubdevmap=`mktemp`
> +    cat >$tmpgrubdevmap <<EOF
>  (hd0)   $dev
>  (hd0,1) $devp
>  EOF
> +    $SUDO mv $tmpgrubdevmap $tmpdir/boot/grub/device.map
>  
>      if [[ $DISTRO = "Debian" ]]
>      then
> @@ -137,7 +143,7 @@ EOF
>      fi
>  
>      $SUDO umount $tmpdir
> -    rmdir $tmpdir
> +    $SUDO rmdir $tmpdir
>  }
>  
>  function check_guest_alive() {
> -- 
> 2.7.4
> 

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-02  1:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-01 21:10 [RAISIN] Allow-running-tests-as-non-root Gémes Géza
2017-03-02  1:11 ` Stefano Stabellini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.