Re: [PATCH v14 4/6] dt-bindings: soc: mediatek: add gce-client-reg for MUTEX

From: moudy.ho <moudy.ho@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Rob Landley <rob@landley.net>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	 <linux-kernel@vger.kernel.org>,
	Alexandre Courbot <acourbot@chromium.org>, <tfiga@chromium.org>,
	<drinkcat@chromium.org>, <pihsun@chromium.org>,
	<hsinyi@google.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Maoguang Meng <maoguang.meng@mediatek.com>,
	daoyuan huang <daoyuan.huang@mediatek.com>,
	Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
	<menghui.lin@mediatek.com>, <sj.huang@mediatek.com>,
	<allen-kh.cheng@mediatek.com>, <randy.wu@mediatek.com>,
	<jason-jh.lin@mediatek.com>, <roy-cw.yeh@mediatek.com>,
	<river.cheng@mediatek.com>, <srv_heupstream@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v14 4/6] dt-bindings: soc: mediatek: add gce-client-reg for MUTEX
Date: Wed, 23 Mar 2022 11:10:20 +0800	[thread overview]
Message-ID: <4fa9707f09cfe6a07ddaa999dde0003fbe46d9b9.camel@mediatek.com> (raw)
In-Reply-To: <Yjj8eoXmsYRRvb1I@robh.at.kernel.org>

On Mon, 2022-03-21 at 17:30 -0500, Rob Herring wrote:
> On Thu, Mar 17, 2022 at 10:39:24PM +0800, Moudy Ho wrote:
> > In order to allow modules with latency requirements such as MDP3
> > to set registers through CMDQ, add the relevant GCE property.
> > 
> > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
> > ---
> >  .../devicetree/bindings/soc/mediatek/mediatek,mutex.yaml  | 8
> > ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > index f825af49f820..a4892979480c 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yam
> > l
> > @@ -60,6 +60,14 @@ properties:
> >        include/dt-bindings/gce/<chip>-gce.h of each chips.
> >      $ref: /schemas/types.yaml#/definitions/phandle-array
> >  
> > +  mediatek,gce-client-reg:
> > +    description: The register of client driver can be configured
> > by gce with
> > +      4 arguments defined in this property, such as phandle of
> > gce, subsys id,
> > +      register offset and size. Each GCE subsys id is mapping to a
> > client
> > +      defined in the header include/dt-bindings/gce/<chip>-gce.h.
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    maxItems: 1
> 
> items:
>   items:
>     - description: phandle of GCE
>     - description: GCE subsys id
>     - description: register offset
>     - description: register size
> 
Hi Rob,

Thanks for the review, I will follow the suggestions to make
corresponding corrections in the next version. Also, I'm sorry that I
left out the information about the dependent series that may cause YAML
checking fail.
ref: 
https://patchwork.kernel.org/project/linux-mediatek/list/?series=621899

Thanks,
Moudy
> > +
> >  required:
> >    - compatible
> >    - reg
> > -- 
> > 2.18.0
> > 
> > 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek