All of lore.kernel.org
 help / color / mirror / Atom feed
* READ_EIN/READ_EOUT
@ 2021-01-11 21:48 Mike Jones
  2021-01-12  8:08 ` READ_EIN/READ_EOUT zlukwins
  2021-01-12 22:54 ` READ_EIN/READ_EOUT Andrew Jeffery
  0 siblings, 2 replies; 6+ messages in thread
From: Mike Jones @ 2021-01-11 21:48 UTC (permalink / raw)
  To: OpenBMC Maillist

Within the PMBus standard are two commands for energy: READ_EIN, READ_EOUT.

These commands exist on both regulators and hot swap devices.

- Are these functions getting used?
 -And if so, to what purpose, examples of where to look in the layers for the usage, and any other helpful pointers

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: READ_EIN/READ_EOUT
  2021-01-11 21:48 READ_EIN/READ_EOUT Mike Jones
@ 2021-01-12  8:08 ` zlukwins
  2021-01-12 22:54 ` READ_EIN/READ_EOUT Andrew Jeffery
  1 sibling, 0 replies; 6+ messages in thread
From: zlukwins @ 2021-01-12  8:08 UTC (permalink / raw)
  To: Mike Jones, OpenBMC Maillist

Hi,


On 1/11/21 10:48 PM, Mike Jones wrote:
> Within the PMBus standard are two commands for energy: READ_EIN, READ_EOUT.
>
> These commands exist on both regulators and hot swap devices.
>
> - Are these functions getting used?
Right now these commands are not used. There is no hwmon implementation yet.
>   -And if so, to what purpose, examples of where to look in the layers for the usage, and any other helpful pointers

These commands are alternative for READ_PIN/READ_POUT. They could be 
used to calculate input/output power on your own. They allow you to 
implement your own algorithm (different averaging period, different 
sampling freq, etc.) for power calulcation


------------

Regards

Zbigniew Lukwinski


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: READ_EIN/READ_EOUT
  2021-01-11 21:48 READ_EIN/READ_EOUT Mike Jones
  2021-01-12  8:08 ` READ_EIN/READ_EOUT zlukwins
@ 2021-01-12 22:54 ` Andrew Jeffery
  2021-01-12 23:34   ` READ_EIN/READ_EOUT Mike
  1 sibling, 1 reply; 6+ messages in thread
From: Andrew Jeffery @ 2021-01-12 22:54 UTC (permalink / raw)
  To: Mike Jones, OpenBMC Maillist



On Tue, 12 Jan 2021, at 08:18, Mike Jones wrote:
> Within the PMBus standard are two commands for energy: READ_EIN, READ_EOUT.
> 
> These commands exist on both regulators and hot swap devices.
> 
> - Are these functions getting used?
>  -And if so, to what purpose, examples of where to look in the layers 
> for the usage, and any other helpful pointers

In theory you should only need to look in the kernel, but we also have a 
userspace project that is implementing a pmbus subsystem in userspace (which is 
unfortunate):

https://github.com/openbmc/phosphor-power

Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: READ_EIN/READ_EOUT
  2021-01-12 22:54 ` READ_EIN/READ_EOUT Andrew Jeffery
@ 2021-01-12 23:34   ` Mike
  2021-01-13  0:48     ` READ_EIN/READ_EOUT Andrew Jeffery
  0 siblings, 1 reply; 6+ messages in thread
From: Mike @ 2021-01-12 23:34 UTC (permalink / raw)
  To: Andrew Jeffery; +Cc: OpenBMC Maillist

I did not fine use of the commands there, so unless the command comes through an interface outside this code, it is not used.

But I am curious why sidestepping hwmon? Is thus a replacement or addition?

Sent from my iPhone

> On Jan 12, 2021, at 3:54 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> 
> 
> 
>> On Tue, 12 Jan 2021, at 08:18, Mike Jones wrote:
>> Within the PMBus standard are two commands for energy: READ_EIN, READ_EOUT.
>> 
>> These commands exist on both regulators and hot swap devices.
>> 
>> - Are these functions getting used?
>> -And if so, to what purpose, examples of where to look in the layers 
>> for the usage, and any other helpful pointers
> 
> In theory you should only need to look in the kernel, but we also have a 
> userspace project that is implementing a pmbus subsystem in userspace (which is 
> unfortunate):
> 
> https://github.com/openbmc/phosphor-power
> 
> Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: READ_EIN/READ_EOUT
  2021-01-12 23:34   ` READ_EIN/READ_EOUT Mike
@ 2021-01-13  0:48     ` Andrew Jeffery
  2021-01-13  1:04       ` READ_EIN/READ_EOUT Mike Jones
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Jeffery @ 2021-01-13  0:48 UTC (permalink / raw)
  To: Mike Jones; +Cc: OpenBMC Maillist



On Wed, 13 Jan 2021, at 10:04, Mike wrote:
> I did not fine use of the commands there, so unless the command comes 
> through an interface outside this code, it is not used.
> 
> But I am curious why sidestepping hwmon? Is thus a replacement or addition?

The rough justification is that developing a coherent kernel interface that 
catered to the various features offered by different regulators is hard.

I don't like the approach but I don't have the (regulator) experience or time 
to help out with the problem either, so we wound up with a userspace 
implementation.

Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: READ_EIN/READ_EOUT
  2021-01-13  0:48     ` READ_EIN/READ_EOUT Andrew Jeffery
@ 2021-01-13  1:04       ` Mike Jones
  0 siblings, 0 replies; 6+ messages in thread
From: Mike Jones @ 2021-01-13  1:04 UTC (permalink / raw)
  To: Andrew Jeffery; +Cc: OpenBMC Maillist

Makes sense.

I’m on the SMBus/PMBus standards committee, so if there are ever questions on the standard, feel free to reach out.

Mike

Sent from my iPad

> On Jan 12, 2021, at 5:48 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> 
> 
> 
>> On Wed, 13 Jan 2021, at 10:04, Mike wrote:
>> I did not fine use of the commands there, so unless the command comes 
>> through an interface outside this code, it is not used.
>> 
>> But I am curious why sidestepping hwmon? Is thus a replacement or addition?
> 
> The rough justification is that developing a coherent kernel interface that 
> catered to the various features offered by different regulators is hard.
> 
> I don't like the approach but I don't have the (regulator) experience or time 
> to help out with the problem either, so we wound up with a userspace 
> implementation.
> 
> Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-13  1:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 21:48 READ_EIN/READ_EOUT Mike Jones
2021-01-12  8:08 ` READ_EIN/READ_EOUT zlukwins
2021-01-12 22:54 ` READ_EIN/READ_EOUT Andrew Jeffery
2021-01-12 23:34   ` READ_EIN/READ_EOUT Mike
2021-01-13  0:48     ` READ_EIN/READ_EOUT Andrew Jeffery
2021-01-13  1:04       ` READ_EIN/READ_EOUT Mike Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.