[Buildroot] [PATCH v2] libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess

[Buildroot] [PATCH v2] libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess

[Sebastien Bourdelin]

Since the version 2.4.32, libdrm no longer requires dependencies on
the libpciaccess unless for the intel-dri.

For more information :
http://cgit.freedesktop.org/mesa/drm/commit/?id=be30d350b64c1a83473a9ffbedf8e2c680a65fcd

Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (PATCH v1)
---
Changes v1 -> v2:
  - bump to version 2.4.52
---
 package/libdrm/Config.in | 3 ---
 package/libdrm/libdrm.mk | 5 +----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
index 205f47c..4ac4e52 100644
--- a/package/libdrm/Config.in
+++ b/package/libdrm/Config.in
@@ -23,21 +23,18 @@ config BR2_PACKAGE_LIBDRM_INTEL
 config BR2_PACKAGE_LIBDRM_RADEON
 	bool "radeon"
 	select BR2_PACKAGE_LIBATOMIC_OPS
-	select BR2_PACKAGE_XLIB_LIBPCIACCESS
 	depends on BR2_i386 || BR2_x86_64
 	help
 	  install AMD/ATI graphics driver
 
 config BR2_PACKAGE_LIBDRM_NOUVEAU
 	bool "nouveau"
-	select BR2_PACKAGE_XLIB_LIBPCIACCESS
 	depends on BR2_i386 || BR2_x86_64
 	help
 	  install Nvidia graphics driver
 
 config BR2_PACKAGE_LIBDRM_VMWGFX
 	bool "vmwgfx"
-	select BR2_PACKAGE_XLIB_LIBPCIACCESS
 	depends on BR2_i386 || BR2_x86_64
 	help
 	  installs Vmware graphics driver
diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
index f5efaf1..71fce98 100644
--- a/package/libdrm/libdrm.mk
+++ b/package/libdrm/libdrm.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBDRM_VERSION = 2.4.46
+LIBDRM_VERSION = 2.4.52
 LIBDRM_SOURCE = libdrm-$(LIBDRM_VERSION).tar.bz2
 LIBDRM_SITE = http://dri.freedesktop.org/libdrm/
 LIBDRM_LICENSE = MIT
@@ -28,21 +28,18 @@ endif
 
 ifeq ($(BR2_PACKAGE_LIBDRM_RADEON),y)
 LIBDRM_CONF_OPT += --enable-radeon
-LIBDRM_DEPENDENCIES += xlib_libpciaccess
 else
 LIBDRM_CONF_OPT += --disable-radeon
 endif
 
 ifeq ($(BR2_PACKAGE_LIBDRM_NOUVEAU),y)
 LIBDRM_CONF_OPT += --enable-nouveau
-LIBDRM_DEPENDENCIES += xlib_libpciaccess
 else
 LIBDRM_CONF_OPT += --disable-nouveau
 endif
 
 ifeq ($(BR2_PACKAGE_LIBDRM_VMWGFX),y)
 LIBDRM_CONF_OPT += --enable-vmwgfx
-LIBDRM_DEPENDENCIES += xlib_libpciaccess
 else
 LIBDRM_CONF_OPT += --disable-vmwgfx
 endif
-- 
1.9.0

[Buildroot] [PATCH v2] libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess

[Thomas Petazzoni]

Dear Sebastien Bourdelin,

On Thu, 27 Feb 2014 17:25:07 -0500, Sebastien Bourdelin wrote:
> Since the version 2.4.32, libdrm no longer requires dependencies on
> the libpciaccess unless for the intel-dri.
> 
> For more information :
> http://cgit.freedesktop.org/mesa/drm/commit/?id=be30d350b64c1a83473a9ffbedf8e2c680a65fcd
> 
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (PATCH v1)
> ---
> Changes v1 -> v2:
>   - bump to version 2.4.52

Thanks a lot for your contribution!

However, the patch has two problems:

 *) You added a significant change (bumping the version number), but
 you kept the Reviewed-by tag of another person. This is typically
 considered as a bad practice: Arnout had endorsed your previous
 version, and maybe not this one.

 *) When your commit log title contains something like "do this *AND*
 do that", it's a strong indication that your patch is not correct, and
 should instead be split in two patches: one "doing this" and the other
 "doing that". In this case, the patch "doing that" could carry
 Arnout's Reviewed-by, since it wouldn't have changed since Arnout's
 review.

Would you mind resending an updated version that takes into account
those comments?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v2] libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess

[Bernd Kuhls]

Sebastien Bourdelin
<sebastien.bourdelin@savoirfairelinux.com>
wrote in
news:1393539908-14365-1-git-send-email-sebastien.bourdelin at savoirfairelinux
.com: 

> Since the version 2.4.32, libdrm no longer requires dependencies on
> the libpciaccess unless for the intel-dri.

Hi,

please have a look at this patch series addressing the same topic:

http://patchwork.ozlabs.org/patch/317523/
http://patchwork.ozlabs.org/patch/317522/
http://patchwork.ozlabs.org/patch/317524/

Regards, Bernd

[Buildroot] [PATCH v2] libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess

[Sebastien Bourdelin]

Hi Thomas, Bernd

On 02/27/2014 05:44 PM, Thomas Petazzoni wrote:
> Thanks a lot for your contribution!
>
> However, the patch has two problems:
>
>  *) You added a significant change (bumping the version number), but
>  you kept the Reviewed-by tag of another person. This is typically
>  considered as a bad practice: Arnout had endorsed your previous
>  version, and maybe not this one.
>
>  *) When your commit log title contains something like "do this *AND*
>  do that", it's a strong indication that your patch is not correct, and
>  should instead be split in two patches: one "doing this" and the other
>  "doing that". In this case, the patch "doing that" could carry
>  Arnout's Reviewed-by, since it wouldn't have changed since Arnout's
>  review.
>
> Would you mind resending an updated version that takes into account
> those comments?
>
> Thomas
Thanks for your advice Thomas, i'll keep it in mind.

On 02/27/2014 05:44 PM, Bernd Kuhls wrote:
> Hi,
>
> please have a look at this patch series addressing the same topic:
>
> http://patchwork.ozlabs.org/patch/317523/
> http://patchwork.ozlabs.org/patch/317522/
> http://patchwork.ozlabs.org/patch/317524/
>
> Regards, Bernd
Bernd i saw some of your patches but not this one sorry.
My patch is redundant with Bernd's patches, so you can burn mine :)

Regards.