[PATCH] xen: honor _PAGE_NX_BIT

[PATCH] xen: honor _PAGE_NX_BIT

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]


In p2m_type_to_flags() honor _PAGE_NX_BIT for grant type mappings.
This brings this code in line with PV and EPT.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
CC: Tim Deegan <tim@xen.org>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_p2m_nx.diff --]
[-- Type: text/plain, Size: 1138 bytes --]

diff -r c69ef56d8afc xen/arch/x86/mm/p2m-pt.c
--- a/xen/arch/x86/mm/p2m-pt.c	Tue Jul 03 11:44:28 2012 +0200
+++ b/xen/arch/x86/mm/p2m-pt.c	Fri Jul 13 15:33:58 2012 +0200
@@ -79,8 +79,8 @@ static unsigned long p2m_type_to_flags(p
     BUG_ON(t > p2m_populate_on_demand);
 #endif
 
-    switch(t)
-    {
+    /* Apply type permissions */
+    switch (t) {
     case p2m_invalid:
     case p2m_mmio_dm:
     case p2m_populate_on_demand:
@@ -89,14 +89,16 @@ static unsigned long p2m_type_to_flags(p
     case p2m_ram_paging_in:
     default:
         return flags;
+    case p2m_grant_map_ro:
+        return flags | P2M_BASE_FLAGS | _PAGE_NX_BIT;
     case p2m_ram_ro:
-    case p2m_grant_map_ro:
     case p2m_ram_logdirty:
     case p2m_ram_shared:
         return flags | P2M_BASE_FLAGS;
     case p2m_ram_rw:
+        return flags | P2M_BASE_FLAGS | _PAGE_RW;
     case p2m_grant_map_rw:
-        return flags | P2M_BASE_FLAGS | _PAGE_RW;
+        return flags | P2M_BASE_FLAGS | _PAGE_RW | _PAGE_NX_BIT;
     case p2m_mmio_direct:
         if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
             flags |= _PAGE_RW;

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] xen: honor _PAGE_NX_BIT

[Tim Deegan]

At 16:12 +0200 on 13 Jul (1342195923), Christoph Egger wrote:
> 
> In p2m_type_to_flags() honor _PAGE_NX_BIT for grant type mappings.
> This brings this code in line with PV and EPT.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> CC: Tim Deegan <tim@xen.org>

Applied, thanks.

Tim.