All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sd: do not set changed flag on all unit attention conditions
Date: Tue, 17 Jul 2012 11:28:13 +0200	[thread overview]
Message-ID: <5005302D.6010805@redhat.com> (raw)
In-Reply-To: <1342516317.3039.35.camel@dabdike.int.hansenpartnership.com>

Il 17/07/2012 11:11, James Bottomley ha scritto:
> We don't do stuff just because the standards allows it; just the
> opposite: we try to use the smallest implementations from the standards
> we can get away with just because the more things we do, the more
> exceptions and broken devices we come across.

Yes, I realize failing only on specific sense codes as I did it in the
patch is not going to work.  However, the other way round is not
problematic (explicitly allow some sense codes, fail on all others).

Another example is "target operating conditions have changed".  QEMU
cannot report such changes because scsi_error prints a warning (fine)
and then passes the unit attention upwards.  With removable drives, this
has the same problem as resizing.

Paolo

  reply	other threads:[~2012-07-17  9:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16 16:06 [PATCH] sd: do not set changed flag on all unit attention conditions Paolo Bonzini
2012-07-16 16:18 ` James Bottomley
2012-07-16 17:20   ` Paolo Bonzini
2012-07-17  7:45     ` James Bottomley
2012-07-17  8:34       ` Paolo Bonzini
2012-07-17  8:40         ` James Bottomley
2012-07-17  8:54           ` Paolo Bonzini
2012-07-17  9:11             ` James Bottomley
2012-07-17  9:28               ` Paolo Bonzini [this message]
2012-07-17 12:21                 ` James Bottomley
2012-07-17 12:31                   ` Paolo Bonzini
2012-07-17 13:32                     ` James Bottomley
2012-07-17 16:36               ` Christoph Hellwig
2012-07-17 16:47                 ` Paolo Bonzini
2012-07-17 16:50                   ` Christoph Hellwig
2012-07-17 18:45                   ` Mike Christie
2012-07-17 18:49                     ` Mike Christie
2012-07-17 21:12                       ` Paolo Bonzini
2012-07-17 21:59                 ` James Bottomley
2012-07-27 10:16                   ` Hannes Reinecke
2012-07-27 10:16                     ` Hannes Reinecke
2012-07-25 12:09               ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5005302D.6010805@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.