All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sd: do not set changed flag on all unit attention conditions
Date: Tue, 17 Jul 2012 23:12:11 +0200	[thread overview]
Message-ID: <5005D52B.30809@redhat.com> (raw)
In-Reply-To: <5005B39D.6030905@cs.wisc.edu>

Il 17/07/2012 20:49, Mike Christie ha scritto:
> > Not sure if we are talking about the same thing.
> > 
> > So can virtio-scsi send a UA with asc/ascq that indicates the lun
> > changed size? Other drivers do this. I updated Hannes's patches the
> > other day to support UAs like those in userspace.
> > 
> > I just saw the code in the patch where virtio-scsi gets that event.
> Was not done. I meant I saw that patch where virtio-scsi gets that
> virtio_scsi_event and kicks of a rescan based off of that.

Yes, it sends both (event + UA).  Right now Linux ignores the UA, and I
wanted virtio-scsi to match real hardware as much as possible so I
copied what aacraid does.  The event also has the advantage over UA that
it the revalidate is done immediately, not the next time the unit is
accessed.

Paolo

  reply	other threads:[~2012-07-17 21:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16 16:06 [PATCH] sd: do not set changed flag on all unit attention conditions Paolo Bonzini
2012-07-16 16:18 ` James Bottomley
2012-07-16 17:20   ` Paolo Bonzini
2012-07-17  7:45     ` James Bottomley
2012-07-17  8:34       ` Paolo Bonzini
2012-07-17  8:40         ` James Bottomley
2012-07-17  8:54           ` Paolo Bonzini
2012-07-17  9:11             ` James Bottomley
2012-07-17  9:28               ` Paolo Bonzini
2012-07-17 12:21                 ` James Bottomley
2012-07-17 12:31                   ` Paolo Bonzini
2012-07-17 13:32                     ` James Bottomley
2012-07-17 16:36               ` Christoph Hellwig
2012-07-17 16:47                 ` Paolo Bonzini
2012-07-17 16:50                   ` Christoph Hellwig
2012-07-17 18:45                   ` Mike Christie
2012-07-17 18:49                     ` Mike Christie
2012-07-17 21:12                       ` Paolo Bonzini [this message]
2012-07-17 21:59                 ` James Bottomley
2012-07-27 10:16                   ` Hannes Reinecke
2012-07-27 10:16                     ` Hannes Reinecke
2012-07-25 12:09               ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5005D52B.30809@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.