* [PATCH] connman: fix build with automake 1.12
@ 2012-07-11 15:39 Ross Burton
2012-07-11 22:00 ` Colin Walters
2012-07-18 0:35 ` Saul Wold
0 siblings, 2 replies; 4+ messages in thread
From: Ross Burton @ 2012-07-11 15:39 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/recipes-connectivity/connman/connman.inc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 12378e9..bb6f532 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -20,7 +20,7 @@ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \
${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
"
-INC_PR = "r11"
+INC_PR = "r12"
TIST = "--enable-tist"
TIST_powerpc = ""
@@ -72,6 +72,10 @@ do_install_append() {
# We don't need to package an empty directory
rmdir ${D}${libdir}/connman/scripts
+
+ # Automake 1.12 won't install empty directories, but we need the
+ # plugins directory to be present for ownership
+ mkdir -p ${D}${libdir}/connman/plugins
}
# These used to be plugins, but now they are core
--
1.7.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] connman: fix build with automake 1.12
2012-07-11 15:39 [PATCH] connman: fix build with automake 1.12 Ross Burton
@ 2012-07-11 22:00 ` Colin Walters
2012-07-12 21:17 ` Burton, Ross
2012-07-18 0:35 ` Saul Wold
1 sibling, 1 reply; 4+ messages in thread
From: Colin Walters @ 2012-07-11 22:00 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, 2012-07-11 at 16:39 +0100, Ross Burton wrote:
> + # Automake 1.12 won't install empty directories, but we need the
> + # plugins directory to be present for ownership
> + mkdir -p ${D}${libdir}/connman/plugins
> }
Did you consider patching upstream to do this in install-data-local
rule? That way everyone gets the fix (Debian/Gentoo/Fedora etc.), not
just you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] connman: fix build with automake 1.12
2012-07-11 22:00 ` Colin Walters
@ 2012-07-12 21:17 ` Burton, Ross
0 siblings, 0 replies; 4+ messages in thread
From: Burton, Ross @ 2012-07-12 21:17 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 11 July 2012 23:00, Colin Walters <walters@verbum.org> wrote:
> On Wed, 2012-07-11 at 16:39 +0100, Ross Burton wrote:
>
>> + # Automake 1.12 won't install empty directories, but we need the
>> + # plugins directory to be present for ownership
>> + mkdir -p ${D}${libdir}/connman/plugins
>> }
>
> Did you consider patching upstream to do this in install-data-local
> rule? That way everyone gets the fix (Debian/Gentoo/Fedora etc.), not
> just you.
Yes, and I also considered that this surely can't be restricted to
connman and automake should have some clean way of forcing an empty
directory to exist. I'm also pretty certain the automake maintainers
response would be "do it in install-data-local", so this should go to
connman...
Ross
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] connman: fix build with automake 1.12
2012-07-11 15:39 [PATCH] connman: fix build with automake 1.12 Ross Burton
2012-07-11 22:00 ` Colin Walters
@ 2012-07-18 0:35 ` Saul Wold
1 sibling, 0 replies; 4+ messages in thread
From: Saul Wold @ 2012-07-18 0:35 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 07/11/2012 08:39 AM, Ross Burton wrote:
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-connectivity/connman/connman.inc | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 12378e9..bb6f532 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -20,7 +20,7 @@ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \
> ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
> "
>
> -INC_PR = "r11"
> +INC_PR = "r12"
>
> TIST = "--enable-tist"
> TIST_powerpc = ""
> @@ -72,6 +72,10 @@ do_install_append() {
>
> # We don't need to package an empty directory
> rmdir ${D}${libdir}/connman/scripts
> +
> + # Automake 1.12 won't install empty directories, but we need the
> + # plugins directory to be present for ownership
> + mkdir -p ${D}${libdir}/connman/plugins
> }
>
> # These used to be plugins, but now they are core
>
Merged this change into OE-Core, other connman changes are pending with
some clean up requests.
Thanks
Sau!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-18 0:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-11 15:39 [PATCH] connman: fix build with automake 1.12 Ross Burton
2012-07-11 22:00 ` Colin Walters
2012-07-12 21:17 ` Burton, Ross
2012-07-18 0:35 ` Saul Wold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.