From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> To: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> Cc: Shlomo Pongartz <shlomop-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH net/for-next V1 1/1] IB/ipoib: break linkage to neighbouring system Date: Thu, 19 Jul 2012 19:20:41 +0300 [thread overview] Message-ID: <500833D9.8000001@mellanox.com> (raw) In-Reply-To: <alpine.DEB.2.00.1207191023130.29808-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org> On 7/19/2012 6:24 PM, Christoph Lameter wrote: > On Thu, 19 Jul 2012, Shlomo Pongartz wrote: > >> The garbage collection and stale times follow the default ipv4/6 neigh.default.gc_yyy >> sysctl values, for example >> >> net.ipv4.neigh.default.gc_interval = 30 >> net.ipv4.neigh.default.gc_stale_time = 60 >> >> If given access to these values from IPoIB, we will be happy >> to integrate them into that logic > > It looks like the values are hardcoded right now. Two points here, 1s, they are indeed hard-coded since there's no define/enum that holds their default values (or maybe we should add one now?), see this code snippest from net/ipv4/arp.c > .gc_interval = 30 * HZ, > .gc_thresh1 = 128, > .gc_thresh2 = 512, > .gc_thresh3 = 1024, 2nd, and even more interesting, the little challenge here is how to integrate with the sysctl's that allow for changing these values, the mechanism that uses neigh_sysctl_table in net/core/neighbour.c isn't exported to the rest of the world. And there's no point to define new sysctl entries just for managing the IPoIB neighbours, ideas welcome. >> Please clarify what do you mean by group expiration. > > If you have neighbor expiration periods of 4 hrs and it is necessary to > run the expiration logic then please expire all the neighbor entries due a > certain period after that as well to avoid running the expiration again in > the next minute or so. This is still a bit unclear here... do you mean to say that at a certain point in time, **all** entries need to be deleted irrelevant of their (jiffies) age? why? > I guess the fuzz factor needs to scale depending on the expiration period. > > and this is what happens now, the factor is 0.5, entry would be deleted when if (60m <= unused < 90s) holds Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> To: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org> Cc: Shlomo Pongartz <shlomop-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH net/for-next V1 1/1] IB/ipoib: break linkage to neighbouring system Date: Thu, 19 Jul 2012 19:20:41 +0300 [thread overview] Message-ID: <500833D9.8000001@mellanox.com> (raw) In-Reply-To: <alpine.DEB.2.00.1207191023130.29808-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org> On 7/19/2012 6:24 PM, Christoph Lameter wrote: > On Thu, 19 Jul 2012, Shlomo Pongartz wrote: > >> The garbage collection and stale times follow the default ipv4/6 neigh.default.gc_yyy >> sysctl values, for example >> >> net.ipv4.neigh.default.gc_interval = 30 >> net.ipv4.neigh.default.gc_stale_time = 60 >> >> If given access to these values from IPoIB, we will be happy >> to integrate them into that logic > > It looks like the values are hardcoded right now. Two points here, 1s, they are indeed hard-coded since there's no define/enum that holds their default values (or maybe we should add one now?), see this code snippest from net/ipv4/arp.c > .gc_interval = 30 * HZ, > .gc_thresh1 = 128, > .gc_thresh2 = 512, > .gc_thresh3 = 1024, 2nd, and even more interesting, the little challenge here is how to integrate with the sysctl's that allow for changing these values, the mechanism that uses neigh_sysctl_table in net/core/neighbour.c isn't exported to the rest of the world. And there's no point to define new sysctl entries just for managing the IPoIB neighbours, ideas welcome. >> Please clarify what do you mean by group expiration. > > If you have neighbor expiration periods of 4 hrs and it is necessary to > run the expiration logic then please expire all the neighbor entries due a > certain period after that as well to avoid running the expiration again in > the next minute or so. This is still a bit unclear here... do you mean to say that at a certain point in time, **all** entries need to be deleted irrelevant of their (jiffies) age? why? > I guess the fuzz factor needs to scale depending on the expiration period. > > and this is what happens now, the factor is 0.5, entry would be deleted when if (60m <= unused < 90s) holds Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-19 16:20 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-19 13:18 [PATCH net/for-next V1 0/1] IB/ipoib: break linkage to neighbouring system Or Gerlitz [not found] ` <1342703938-29904-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2012-07-19 13:18 ` [PATCH net/for-next V1 1/1] " Or Gerlitz [not found] ` <1342703938-29904-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2012-07-19 13:30 ` Or Gerlitz 2012-07-19 14:42 ` Christoph Lameter [not found] ` <alpine.DEB.2.00.1207190938190.28115-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org> 2012-07-19 15:02 ` Shlomo Pongartz [not found] ` <50082183.5000402-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2012-07-19 15:24 ` Christoph Lameter [not found] ` <alpine.DEB.2.00.1207191023130.29808-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org> 2012-07-19 16:20 ` Or Gerlitz [this message] 2012-07-19 16:20 ` Or Gerlitz [not found] ` <500833D9.8000001-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2012-07-19 17:08 ` David Miller [not found] ` <20120719.100850.1932622478297549573.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> 2012-07-22 5:29 ` Or Gerlitz 2012-07-22 5:29 ` Or Gerlitz [not found] ` <500B8FBE.4030600-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2012-07-24 14:24 ` Christoph Lameter 2012-07-24 14:23 ` Christoph Lameter 2012-07-19 15:40 ` David Miller [not found] ` <20120719.084016.1751501566918893035.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> 2012-07-19 15:54 ` Or Gerlitz 2012-07-20 15:49 ` Or Gerlitz [not found] ` <CAJZOPZ+kRcBjJgB_HaMqeuB5E-SLSqskgoaLZ_hvVx4KffHgpA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2012-07-23 16:58 ` Or Gerlitz 2012-07-23 16:58 ` Or Gerlitz 2012-07-23 17:17 ` Eric Dumazet 2012-07-23 18:37 ` Or Gerlitz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=500833D9.8000001@mellanox.com \ --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \ --cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \ --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \ --cc=erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=shlomop-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.