All of lore.kernel.org
 help / color / mirror / Atom feed
From: wwang <wei_wang@realsil.com.cn>
To: Rusty Russell <rusty@ozlabs.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver
Date: Mon, 23 Jul 2012 10:00:35 +0800	[thread overview]
Message-ID: <500CB043.6000904@realsil.com.cn> (raw)
In-Reply-To: <87sjcnas8f.fsf@rustcorp.com.au>

Hi Rusty:

Thank you.

I will fix it and resend all of the three patches

BR,
wwang


于 2012年07月20日 13:58, Rusty Russell 写道:
> On Thu, 19 Jul 2012 17:55:10 +0800, <wei_wang@realsil.com.cn> wrote:
>> From: Wei WANG <wei_wang@realsil.com.cn>
>>
>> Realtek PCI-E card reader driver adapts requests from upper-level
>> sdmmc/memstick layer to the real physical card reader.
>> +static int msi_en = 1;
>> +module_param(msi_en, int, S_IRUGO | S_IWUSR);
>> +MODULE_PARM_DESC(msi_en, "Enable MSI");
>> +
>> +static int adma_mode = 1;
>> +module_param(adma_mode, int, S_IRUGO | S_IWUSR);
>> +MODULE_PARM_DESC(adma_mode, "ADMA Mode");
> These seem like they should be bool?
>
> Cheers,
> Rusty.


  reply	other threads:[~2012-07-23  2:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-19  9:55 [PATCH 2/3] drivers/misc: Add realtek pci card reader driver wei_wang
2012-07-19 12:57 ` Oliver Neukum
2012-07-20  5:58 ` Rusty Russell
2012-07-23  2:00   ` wwang [this message]
2012-07-20 10:09 wei_wang
2012-07-26 13:17 ` Rusty Russell
2012-07-23  9:42 wei_wang
2012-07-23 11:24 ` Borislav Petkov
2012-07-25  3:02 wei_wang
2012-07-26 19:05 ` Bjørn Mork
2012-07-31  7:42 wei_wang
2012-07-31  7:42 ` wei_wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500CB043.6000904@realsil.com.cn \
    --to=wei_wang@realsil.com.cn \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.