From: Rusty Russell <rusty@ozlabs.org>
To: wei_wang@realsil.com.cn, gregkh@linuxfoundation.org,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org
Cc: Wei WANG <wei_wang@realsil.com.cn>
Subject: Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver
Date: Thu, 26 Jul 2012 22:47:51 +0930 [thread overview]
Message-ID: <87pq7ioe4g.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1342778966-30270-1-git-send-email-wei_wang@realsil.com.cn>
On Fri, 20 Jul 2012 18:09:26 +0800, <wei_wang@realsil.com.cn> wrote:
> +static int msi_en = 1;
> +module_param(msi_en, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(msi_en, "Enable MSI");
Should this be a bool, and a module_param(msi_en, bool, S_IRUGO | S_IWUSR);?
> +static int adma_mode = 1;
> +module_param(adma_mode, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(adma_mode, "ADMA Mode");
This too?
> + /* Data transferred in ADMA mode or not */
> + int adma_mode;
And this?
Cheers,
Rusty.
next prev parent reply other threads:[~2012-07-26 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 10:09 [PATCH 2/3] drivers/misc: Add realtek pci card reader driver wei_wang
2012-07-26 13:17 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-31 7:42 wei_wang
2012-07-31 7:42 ` wei_wang
2012-07-25 3:02 wei_wang
2012-07-26 19:05 ` Bjørn Mork
2012-07-23 9:42 wei_wang
2012-07-23 11:24 ` Borislav Petkov
2012-07-19 9:55 wei_wang
2012-07-19 12:57 ` Oliver Neukum
2012-07-20 5:58 ` Rusty Russell
2012-07-23 2:00 ` wwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq7ioe4g.fsf@rustcorp.com.au \
--to=rusty@ozlabs.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.