All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: tegra: fix PCIe resource calculation
@ 2012-07-25 18:02 ` Stephen Warren
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2012-07-25 18:02 UTC (permalink / raw)
  To: Rob Herring, arm-DgEjT+Ai2ygdnm+yROfE0A
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA, Stephen Warren

From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Commit 0acc43c "ARM: tegra: use fixed PCI i/o mapping" re-numbered the
resource array entries that the driver used, but missed one location. This
causes request_resource() to fail, and the driver to panic.

Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Rob, I'm not sure if you can squash this into your PCIE commit, or if
we need to apply it on top?

 arch/arm/mach-tegra/pcie.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c
index 576347a..3463fb5 100644
--- a/arch/arm/mach-tegra/pcie.c
+++ b/arch/arm/mach-tegra/pcie.c
@@ -406,7 +406,7 @@ static int tegra_pcie_setup(int nr, struct pci_sys_data *sys)
 	pp->res[1].name = pp->prefetch_space_name;
 	if (pp->index == 0) {
 		pp->res[1].start = PREFETCH_MEM_BASE_0;
-		pp->res[1].end = pp->res[2].start + PREFETCH_MEM_SIZE_0 - 1;
+		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_0 - 1;
 	} else {
 		pp->res[1].start = PREFETCH_MEM_BASE_1;
 		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_1 - 1;
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ARM: tegra: fix PCIe resource calculation
@ 2012-07-25 18:02 ` Stephen Warren
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2012-07-25 18:02 UTC (permalink / raw)
  To: linux-arm-kernel

From: Stephen Warren <swarren@nvidia.com>

Commit 0acc43c "ARM: tegra: use fixed PCI i/o mapping" re-numbered the
resource array entries that the driver used, but missed one location. This
causes request_resource() to fail, and the driver to panic.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
Rob, I'm not sure if you can squash this into your PCIE commit, or if
we need to apply it on top?

 arch/arm/mach-tegra/pcie.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c
index 576347a..3463fb5 100644
--- a/arch/arm/mach-tegra/pcie.c
+++ b/arch/arm/mach-tegra/pcie.c
@@ -406,7 +406,7 @@ static int tegra_pcie_setup(int nr, struct pci_sys_data *sys)
 	pp->res[1].name = pp->prefetch_space_name;
 	if (pp->index == 0) {
 		pp->res[1].start = PREFETCH_MEM_BASE_0;
-		pp->res[1].end = pp->res[2].start + PREFETCH_MEM_SIZE_0 - 1;
+		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_0 - 1;
 	} else {
 		pp->res[1].start = PREFETCH_MEM_BASE_1;
 		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_1 - 1;
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: tegra: fix PCIe resource calculation
  2012-07-25 18:02 ` Stephen Warren
@ 2012-07-26 12:57     ` Rob Herring
  -1 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2012-07-26 12:57 UTC (permalink / raw)
  To: Stephen Warren
  Cc: arm-DgEjT+Ai2ygdnm+yROfE0A,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA, Stephen Warren

On 07/25/2012 01:02 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Commit 0acc43c "ARM: tegra: use fixed PCI i/o mapping" re-numbered the
> resource array entries that the driver used, but missed one location. This
> causes request_resource() to fail, and the driver to panic.
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Rob, I'm not sure if you can squash this into your PCIE commit, or if
> we need to apply it on top?

I'm rebasing the branch and will incorporate it. Thanks for testing.

Rob

> 
>  arch/arm/mach-tegra/pcie.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c
> index 576347a..3463fb5 100644
> --- a/arch/arm/mach-tegra/pcie.c
> +++ b/arch/arm/mach-tegra/pcie.c
> @@ -406,7 +406,7 @@ static int tegra_pcie_setup(int nr, struct pci_sys_data *sys)
>  	pp->res[1].name = pp->prefetch_space_name;
>  	if (pp->index == 0) {
>  		pp->res[1].start = PREFETCH_MEM_BASE_0;
> -		pp->res[1].end = pp->res[2].start + PREFETCH_MEM_SIZE_0 - 1;
> +		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_0 - 1;
>  	} else {
>  		pp->res[1].start = PREFETCH_MEM_BASE_1;
>  		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_1 - 1;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] ARM: tegra: fix PCIe resource calculation
@ 2012-07-26 12:57     ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2012-07-26 12:57 UTC (permalink / raw)
  To: linux-arm-kernel

On 07/25/2012 01:02 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Commit 0acc43c "ARM: tegra: use fixed PCI i/o mapping" re-numbered the
> resource array entries that the driver used, but missed one location. This
> causes request_resource() to fail, and the driver to panic.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Rob, I'm not sure if you can squash this into your PCIE commit, or if
> we need to apply it on top?

I'm rebasing the branch and will incorporate it. Thanks for testing.

Rob

> 
>  arch/arm/mach-tegra/pcie.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c
> index 576347a..3463fb5 100644
> --- a/arch/arm/mach-tegra/pcie.c
> +++ b/arch/arm/mach-tegra/pcie.c
> @@ -406,7 +406,7 @@ static int tegra_pcie_setup(int nr, struct pci_sys_data *sys)
>  	pp->res[1].name = pp->prefetch_space_name;
>  	if (pp->index == 0) {
>  		pp->res[1].start = PREFETCH_MEM_BASE_0;
> -		pp->res[1].end = pp->res[2].start + PREFETCH_MEM_SIZE_0 - 1;
> +		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_0 - 1;
>  	} else {
>  		pp->res[1].start = PREFETCH_MEM_BASE_1;
>  		pp->res[1].end = pp->res[1].start + PREFETCH_MEM_SIZE_1 - 1;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-26 12:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-25 18:02 [PATCH] ARM: tegra: fix PCIe resource calculation Stephen Warren
2012-07-25 18:02 ` Stephen Warren
     [not found] ` <1343239358-3239-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-07-26 12:57   ` Rob Herring
2012-07-26 12:57     ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.