All of lore.kernel.org
 help / color / mirror / Atom feed
From: "zumeng.chen" <zchen@windriver.com>
To: Kevin Hilman <khilman@ti.com>
Cc: Igor Grinberg <grinberg@compulab.co.il>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	Zumeng Chen <zumeng.chen@windriver.com>
Subject: Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO
Date: Fri, 27 Jul 2012 06:40:26 +0800	[thread overview]
Message-ID: <5011C75A.3080201@windriver.com> (raw)
In-Reply-To: <87ipdambgg.fsf@ti.com>

On 2012年07月27日 05:58, Kevin Hilman wrote:
> "zumeng.chen"<zchen@windriver.com>  writes:
>
>> On 2012年07月27日 03:30, Kevin Hilman wrote:
>>> + Zumeng Chen
>>>
>>> Igor Grinberg<grinberg@compulab.co.il>   writes:
>>>
>>>> Hi Kevin,
>>>>
>>>> I've just noticed that the patch has been modified by Arnd in a way
>>>> that of course will trigger GPIO use without being requested.
>>>> I'm sorry, I was not available by that time Arnd changed the patch.
>>> Your right, your original patch isn't the problem.  I found the root
>>> cause.
>>>
>>> The real problem is actually introduced by the merge of your patch from
>>> the arm-soc/cleanup branch, and this one from Zumeng Chen: commit
>>> 16aced80f6 (ARM: OMAP3530evm: set pendown_state and debounce time for
>>> ads7846) from the arm-soc/boards branch.
>>>
>>> However, looking closer at the one from Zumeng, that one is clearly not
>>> right.  It unconditionally adds a *board-specific* ->get_pendown_state
>>> function to the pdata that is common to *all* boards.  That's just wrong
>>> and has the side-effect of making ->get_pendown_state() wrong on every
>>> board except the OMAP3EVM.  Oops.
>>>
>>> So, IMO, in addition to $SUBJECT patch, in order to get the touchscreen
>>> GPIO working on non OMAP3EVM boards, we also need something like this as
>>> well.
>> Definitely, thanks Kevin.
>>> Igor, Zumeng, could you try this out on your boards anc confirm if it's
>>> working?  I currently don't have a board setup with a touchscreen in my
>>> board farm.
>> Acked
> Did you test this on your board?
No, I just read/compiled it.
>   If so, could you respond with a
> Tested-by tag?  Thanks
NP, Kevin, I'll test it after being office, and
it's about ten o'clock this morning.

Regards,
Zumeng
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: zchen@windriver.com (zumeng.chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO
Date: Fri, 27 Jul 2012 06:40:26 +0800	[thread overview]
Message-ID: <5011C75A.3080201@windriver.com> (raw)
In-Reply-To: <87ipdambgg.fsf@ti.com>

On 2012?07?27? 05:58, Kevin Hilman wrote:
> "zumeng.chen"<zchen@windriver.com>  writes:
>
>> On 2012?07?27? 03:30, Kevin Hilman wrote:
>>> + Zumeng Chen
>>>
>>> Igor Grinberg<grinberg@compulab.co.il>   writes:
>>>
>>>> Hi Kevin,
>>>>
>>>> I've just noticed that the patch has been modified by Arnd in a way
>>>> that of course will trigger GPIO use without being requested.
>>>> I'm sorry, I was not available by that time Arnd changed the patch.
>>> Your right, your original patch isn't the problem.  I found the root
>>> cause.
>>>
>>> The real problem is actually introduced by the merge of your patch from
>>> the arm-soc/cleanup branch, and this one from Zumeng Chen: commit
>>> 16aced80f6 (ARM: OMAP3530evm: set pendown_state and debounce time for
>>> ads7846) from the arm-soc/boards branch.
>>>
>>> However, looking closer at the one from Zumeng, that one is clearly not
>>> right.  It unconditionally adds a *board-specific* ->get_pendown_state
>>> function to the pdata that is common to *all* boards.  That's just wrong
>>> and has the side-effect of making ->get_pendown_state() wrong on every
>>> board except the OMAP3EVM.  Oops.
>>>
>>> So, IMO, in addition to $SUBJECT patch, in order to get the touchscreen
>>> GPIO working on non OMAP3EVM boards, we also need something like this as
>>> well.
>> Definitely, thanks Kevin.
>>> Igor, Zumeng, could you try this out on your boards anc confirm if it's
>>> working?  I currently don't have a board setup with a touchscreen in my
>>> board farm.
>> Acked
> Did you test this on your board?
No, I just read/compiled it.
>   If so, could you respond with a
> Tested-by tag?  Thanks
NP, Kevin, I'll test it after being office, and
it's about ten o'clock this morning.

Regards,
Zumeng

  reply	other threads:[~2012-07-26 22:40 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 23:18 [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO Kevin Hilman
2012-07-11 23:18 ` Kevin Hilman
2012-07-23 12:53 ` Igor Grinberg
2012-07-23 12:53   ` Igor Grinberg
2012-07-23 13:18   ` Igor Grinberg
2012-07-23 13:18     ` Igor Grinberg
2012-07-26 19:30     ` Kevin Hilman
2012-07-26 19:30       ` Kevin Hilman
2012-07-26 21:19       ` zumeng.chen
2012-07-26 21:19         ` zumeng.chen
2012-07-26 21:58         ` Kevin Hilman
2012-07-26 21:58           ` Kevin Hilman
2012-07-26 22:40           ` zumeng.chen [this message]
2012-07-26 22:40             ` zumeng.chen
2012-07-27  5:02           ` Zumeng Chen
2012-07-27  5:02             ` Zumeng Chen
2012-07-27 15:30       ` Igor Grinberg
2012-07-27 15:30         ` Igor Grinberg
2012-07-27 17:46         ` Kevin Hilman
2012-07-27 17:46           ` Kevin Hilman
2012-07-27 19:04           ` Igor Grinberg
2012-07-27 19:04             ` Igor Grinberg
2012-07-28  0:28             ` Kevin Hilman
2012-07-28  0:28               ` Kevin Hilman
2012-08-06 20:22               ` [PATCH] Revert "ARM: OMAP3530evm: set pendown_state and debounce time for ads7846" Igor Grinberg
2012-08-06 20:22                 ` Igor Grinberg
2012-08-06 20:52                 ` Kevin Hilman
2012-08-06 20:52                   ` Kevin Hilman
2012-08-07  1:44                   ` Zumeng Chen
2012-08-07  1:44                     ` Zumeng Chen
2012-08-07  5:58                   ` Igor Grinberg
2012-08-07  5:58                     ` Igor Grinberg
2012-08-07 10:58                   ` Tony Lindgren
2012-08-07 10:58                     ` Tony Lindgren
2012-08-07  1:42                 ` Zumeng Chen
2012-08-07  1:42                   ` Zumeng Chen
2012-08-07  6:05                   ` Igor Grinberg
2012-08-07  6:05                     ` Igor Grinberg
2012-07-27 18:58       ` [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO Igor Grinberg
2012-07-27 18:58         ` Igor Grinberg
2012-07-27 19:05         ` Kevin Hilman
2012-07-27 19:05           ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5011C75A.3080201@windriver.com \
    --to=zchen@windriver.com \
    --cc=arnd@arndb.de \
    --cc=grinberg@compulab.co.il \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=zumeng.chen@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.