All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "sebastian.reichel@collabora.com" <sebastian.reichel@collabora.com>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"brendanhiggins@google.com" <brendanhiggins@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v12 00/11] Support ROHM BD99954 charger IC
Date: Sun, 10 May 2020 18:51:53 +0000	[thread overview]
Message-ID: <501265638c16ffa06a77be37e1feeb2c9cb732bb.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20200510160445.6fg2v7jug2vlepkv@earth.universe>

Thanks a lot Sebastian and Mark!

On Sun, 2020-05-10 at 18:04 +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, May 08, 2020 at 06:38:17PM +0300, Matti Vaittinen wrote:
> > Please note that this series should be applied to two trees.
> > Patches
> > 1-4 (or 1-5 as suggested by Sebastian) should go to regulator tree.
> > Perhaps Mark can provide an immutable branch to Sebastian? Rest of
> > the
> > patches can then go to power-supply tree.
> 
> Thanks, I merged the pull-request from Mark and queued patches 5-11.
> 

I think it's fair to point out also for Sebastian that Mark spotted a
compile time warning from linear_ranges when it is compiled as a
module. This is only occurring when linear_ranges is compiled as a
module. And that requires CONFIG_REGULATOR to be n and linear_ranges
test to be m. I guess this is unlikely as I think enabling
linear_ranges test code is not common for setups that are not using
linear ranges - but for sure some test setup hits this somewhere.

Problem is that linear_ranges can be compiled as module (it's tristated
in Kconfig) but does not declare MODULE_LICENCE macro.

I sent this incremental patch which should fix the issue:
https://lore.kernel.org/lkml/20200509151519.GA7100@localhost.localdomain/

 - but does applying it to either power-supply or regulator cause a
conflict?

I just wanted to point this out - sorry for the trouble! And please let
me know if you wish me to send some other fix. I will gladly do so and
correct my bugs :)

--Matti


      reply	other threads:[~2020-05-10 18:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 15:38 [PATCH v12 00/11] Support ROHM BD99954 charger IC Matti Vaittinen
2020-05-08 15:39 ` [PATCH v12 01/11] lib: add linear ranges helpers Matti Vaittinen
2020-05-08 15:40 ` [PATCH v12 02/11] lib/test_linear_ranges: add a test for the 'linear_ranges' Matti Vaittinen
2020-05-08 17:17   ` Mark Brown
2020-05-08 18:42     ` Vaittinen, Matti
2020-05-11 10:13       ` Mark Brown
2020-05-09 15:17     ` Vaittinen, Matti
2020-05-08 15:41 ` [PATCH v12 03/11] power: supply: bd70528: rename linear_range to avoid collision Matti Vaittinen
2020-05-08 15:43 ` [PATCH v12 04/11] regulator: use linear_ranges helper Matti Vaittinen
2020-05-08 15:44 ` [PATCH v12 05/11] power: supply: bd70528: use linear ranges Matti Vaittinen
2020-05-08 15:46 ` [PATCH v12 06/11] dt-bindings: battery: add new battery parameters Matti Vaittinen
2020-05-08 15:47 ` [PATCH v12 07/11] power: supply: add " Matti Vaittinen
2020-05-08 15:48 ` [PATCH v12 08/11] dt_bindings: ROHM BD99954 Charger Matti Vaittinen
2020-05-08 15:49 ` [PATCH v12 09/11] power: supply: Support ROHM bd99954 charger Matti Vaittinen
2020-05-08 15:50   ` Matti Vaittinen
2020-05-08 15:59   ` Vaittinen, Matti
2020-05-08 17:44     ` sre
2020-05-08 15:51 ` [PATCH v12 10/11] power: supply: Fix Kconfig help text indentiation Matti Vaittinen
2020-05-08 15:52 ` [PATCH v12 11/11] power: supply: KConfig cleanup default n Matti Vaittinen
2020-05-08 17:13 ` [PATCH v12 00/11] Support ROHM BD99954 charger IC Mark Brown
2020-05-08 17:20 ` Mark Brown
2020-05-10  0:32   ` Sebastian Reichel
2020-05-10 16:04 ` Sebastian Reichel
2020-05-10 18:51   ` Vaittinen, Matti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501265638c16ffa06a77be37e1feeb2c9cb732bb.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=brendanhiggins@google.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.