* [Qemu-devel] [PATCH] SCSI update to the correct sense code for media removal prevention
@ 2012-07-29 21:52 Ronnie Sahlberg
2012-07-29 21:52 ` [Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors Ronnie Sahlberg
0 siblings, 1 reply; 3+ messages in thread
From: Ronnie Sahlberg @ 2012-07-29 21:52 UTC (permalink / raw)
To: qemu-devel, pbonzini
List, Paolo
Please find a trivial patch that changes the sense code for errors when trying, and failing, to eject media using the START_STOP_UNIT command when the medium is locked down by a previous PREVENT_ALLOW_MEDIUM_REMOVAL command.
MMC Annex F lists MEDIUM_REMOVAL_PREVENTED as the recommended sense code for this error.
This now passes the test that a SCSI target retports the corre3ct sense code(s) for medium removal protection :
iscsi-test --dataloss --test="*prevent*eject*" iscsi://127.0.0.1:32601/iqn.qemu.scsi-test/3
0381_preventallow_eject:
========================
Try to set PREVENTALLOW ... [OK]
Try to eject the media ... Eject failed. [OK]
Load the media again in case it was ejected ... [OK]
Clear the PREVENTALLOW again ... [OK]
TEST T0381_preventallow_eject [OK]
regards
ronnie sahlberg
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors
2012-07-29 21:52 [Qemu-devel] [PATCH] SCSI update to the correct sense code for media removal prevention Ronnie Sahlberg
@ 2012-07-29 21:52 ` Ronnie Sahlberg
2012-07-30 7:35 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Ronnie Sahlberg @ 2012-07-29 21:52 UTC (permalink / raw)
To: qemu-devel, pbonzini; +Cc: Ronnie Sahlberg
Change the sense codes for failures to eject a device that is locked
by PREVENT_ALLOW_MEDIUM_REMOVAL from
the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific
MEDIUM_REMOVAL_PREVENTED.
The second sense code is more accurate, and is also listed in MMC annex F
for the recommended sense codes for MMC devices while the first sense code is not.
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
---
hw/scsi-bus.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index dc74063..9929d3c 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1089,7 +1089,7 @@ const struct SCSISense sense_code_NO_MEDIUM = {
/* LUN not ready, medium removal prevented */
const struct SCSISense sense_code_NOT_READY_REMOVAL_PREVENTED = {
- .key = NOT_READY, .asc = 0x53, .ascq = 0x00
+ .key = NOT_READY, .asc = 0x53, .ascq = 0x02
};
/* Hardware error, internal target failure */
@@ -1129,7 +1129,7 @@ const struct SCSISense sense_code_INCOMPATIBLE_FORMAT = {
/* Illegal request, medium removal prevented */
const struct SCSISense sense_code_ILLEGAL_REQ_REMOVAL_PREVENTED = {
- .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x00
+ .key = ILLEGAL_REQUEST, .asc = 0x53, .ascq = 0x02
};
/* Command aborted, I/O process terminated */
--
1.7.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors
2012-07-29 21:52 ` [Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors Ronnie Sahlberg
@ 2012-07-30 7:35 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2012-07-30 7:35 UTC (permalink / raw)
To: Ronnie Sahlberg; +Cc: qemu-devel
Il 29/07/2012 23:52, Ronnie Sahlberg ha scritto:
> Change the sense codes for failures to eject a device that is locked
> by PREVENT_ALLOW_MEDIUM_REMOVAL from
> the generic MEDIA_LOAD_OR_EJECT_FAILED to the more specific
> MEDIUM_REMOVAL_PREVENTED.
>
> The second sense code is more accurate, and is also listed in MMC annex F
> for the recommended sense codes for MMC devices while the first sense code is not.
>
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
> hw/scsi-bus.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied. Can you redo these two MMC patches also for ATAPI?
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-30 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-29 21:52 [Qemu-devel] [PATCH] SCSI update to the correct sense code for media removal prevention Ronnie Sahlberg
2012-07-29 21:52 ` [Qemu-devel] [PATCH] SCSI: Update the sense code for PREVENT REMOVAL errors Ronnie Sahlberg
2012-07-30 7:35 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.