[U-Boot] [PATCH] km/common: remove printfs for i2c deblocking code

[U-Boot] [PATCH] km/common: remove printfs for i2c deblocking code

[Gerlando Falauto]

From: Holger Brunck <holger.brunck@keymile.com>

This code will also be used before reallocation and during this time we
are not allowed to do these printings.

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
---
 board/keymile/common/common.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
index 1013f42..a90f112 100644
--- a/board/keymile/common/common.c
+++ b/board/keymile/common/common.c
@@ -151,7 +151,6 @@ int i2c_make_abort(void)
 			sda_state = get_sda();
 			if (scl_state && sda_state) {
 				ret = 0;
-				printf("[INFO] i2c abort after %d clocks\n", i);
 				break;
 			}
 		}
@@ -159,8 +158,6 @@ int i2c_make_abort(void)
 	if (ret == 0)
 		for (i = 0; i < 5; i++)
 			i2c_write_start_seq();
-	else
-		printf("[ERROR] i2c abort failed\n");
 
 	/* respect stop setup time */
 	udelay(DELAY_ABORT_SEQ);
-- 
1.7.1

[U-Boot] [PATCH] km/common: remove printfs for i2c deblocking code

[Prafulla Wadaskar]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Gerlando Falauto
> Sent: 27 July 2012 20:28
> To: u-boot at lists.denx.de
> Cc: Holger Brunck
> Subject: [U-Boot] [PATCH] km/common: remove printfs for i2c deblocking
> code
> 
> From: Holger Brunck <holger.brunck@keymile.com>
> 
> This code will also be used before reallocation and during this time
> we
> are not allowed to do these printings.
> 
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> ---
>  board/keymile/common/common.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/board/keymile/common/common.c
> b/board/keymile/common/common.c
> index 1013f42..a90f112 100644
> --- a/board/keymile/common/common.c
> +++ b/board/keymile/common/common.c
> @@ -151,7 +151,6 @@ int i2c_make_abort(void)
>  			sda_state = get_sda();
>  			if (scl_state && sda_state) {
>  				ret = 0;
> -				printf("[INFO] i2c abort after %d clocks\n", i);
>  				break;
>  			}
>  		}
> @@ -159,8 +158,6 @@ int i2c_make_abort(void)
>  	if (ret == 0)
>  		for (i = 0; i < 5; i++)
>  			i2c_write_start_seq();
> -	else
> -		printf("[ERROR] i2c abort failed\n");
> 
>  	/* respect stop setup time */
>  	udelay(DELAY_ABORT_SEQ);
> --

Acked-By: Prafulla Wadaskar <Prafulla@marvell.com>

Regards...
Prafulla . . .

[U-Boot] [PATCH] km/common: remove printfs for i2c deblocking code

[Heiko Schocher]

Hello Gerlando,

On 27.07.2012 16:58, Gerlando Falauto wrote:
> From: Holger Brunck<holger.brunck@keymile.com>
>
> This code will also be used before reallocation and during this time we
> are not allowed to do these printings.
>
> Signed-off-by: Holger Brunck<holger.brunck@keymile.com>
> ---
>   board/keymile/common/common.c |    3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)

Acked-by: Heiko Schocher<hs@denx.de>

@Prafulla: Is it OK for you, if I pick this patch up to my i2c tree?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH] km/common: remove printfs for i2c deblocking code

[Prafulla Wadaskar]

> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: 30 July 2012 14:53
> To: Gerlando Falauto
> Cc: u-boot at lists.denx.de; Holger Brunck; Prafulla Wadaskar
> Subject: Re: [U-Boot] [PATCH] km/common: remove printfs for i2c
> deblocking code
> 
> Hello Gerlando,
> 
> On 27.07.2012 16:58, Gerlando Falauto wrote:
> > From: Holger Brunck<holger.brunck@keymile.com>
> >
> > This code will also be used before reallocation and during this time
> we
> > are not allowed to do these printings.
> >
> > Signed-off-by: Holger Brunck<holger.brunck@keymile.com>
> > ---
> >   board/keymile/common/common.c |    3 ---
> >   1 files changed, 0 insertions(+), 3 deletions(-)
> 
> Acked-by: Heiko Schocher<hs@denx.de>
> 
> @Prafulla: Is it OK for you, if I pick this patch up to my i2c tree?
> 

Hi Heiko
Yes, I am okay with it, please pick it.

Regards...
Prafulla . . .