Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

[Laszlo Ersek]

(in reply to
<http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02637.html> --
In-Reply-To set, but that may not be enough for the web archive)

Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead
of calling closesocket(s->fd), like in eoc handling) in
net_socket_cleanup().

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

[Stefan Hajnoczi]

On Tue, Jul 31, 2012 at 12:41 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> (in reply to
> <http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02637.html> --
> In-Reply-To set, but that may not be enough for the web archive)
>
> Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead
> of calling closesocket(s->fd), like in eoc handling) in
> net_socket_cleanup().

The reason I didn't change close(2) to closesocket() is because
-netdev socket,fd= can pass arbitrary file descriptors.  I suspect
only real socket objects will work but we basically don't know what
the passed file descriptor is.  This is the reason why I didn't feel
100% happy converting it to closesocket().

> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!

Stefan

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

[Paolo Bonzini]

Il 31/07/2012 15:04, Stefan Hajnoczi ha scritto:
>> > Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead
>> > of calling closesocket(s->fd), like in eoc handling) in
>> > net_socket_cleanup().
> The reason I didn't change close(2) to closesocket() is because
> -netdev socket,fd= can pass arbitrary file descriptors.  I suspect
> only real socket objects will work but we basically don't know what
> the passed file descriptor is.  This is the reason why I didn't feel
> 100% happy converting it to closesocket().
> 

-netdev socket,fd= is probably not usable from Windows, so no problem
using close().

Paolo

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

[Stefan Hajnoczi]

On Fri, Jul 20, 2012 at 2:25 PM, Stefan Hajnoczi
<stefanha@linux.vnet.ibm.com> wrote:
> The socket backend does not support the listen= option with -netdev.  The
> problem is how the socket NetClientState lifecycle is implemented: the socket
> backend waits for an incoming client connection before creating a
> NetClientState.  The guest -device wants a peer= on startup, so QEMU fails with
> an error about the non-existent peer.
>
> This series makes -netdev socket,listen= work by creating the NetClientState
> right away.  This allows -device peer= to find the socket backend.
>
> This code was written by Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>.  I have only
> cleaned up and tested it.  The following work:
>  * -net socket,listen=:1234 -net nic,model=virtio
>  * -netdev socket,listen=:1234,id=netdev0 -device virtio-net-pci,netdev=netdev0
>
> Zhi Yong Wu (2):
>   net: fix the coding style
>   net: add the support for -netdev socket, listen
>
>  net/socket.c |   82 +++++++++++++++++++++++++++++++++++-----------------------
>  1 file changed, 50 insertions(+), 32 deletions(-)

Merged into the net tree:
https://github.com/stefanha/qemu/tree/net

Stefan

[Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

[Stefan Hajnoczi]

The socket backend does not support the listen= option with -netdev.  The
problem is how the socket NetClientState lifecycle is implemented: the socket
backend waits for an incoming client connection before creating a
NetClientState.  The guest -device wants a peer= on startup, so QEMU fails with
an error about the non-existent peer.

This series makes -netdev socket,listen= work by creating the NetClientState
right away.  This allows -device peer= to find the socket backend.

This code was written by Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>.  I have only
cleaned up and tested it.  The following work:
 * -net socket,listen=:1234 -net nic,model=virtio
 * -netdev socket,listen=:1234,id=netdev0 -device virtio-net-pci,netdev=netdev0

Zhi Yong Wu (2):
  net: fix the coding style
  net: add the support for -netdev socket, listen

 net/socket.c |   82 +++++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 50 insertions(+), 32 deletions(-)

-- 
1.7.10.4