Re: [PATCH] Cleanup: Remove misplaced config.h include

Re: [PATCH] Cleanup: Remove misplaced config.h include

[David Goulet]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Merged! Thx

Mathieu Desnoyers:
> config.h should _always_ be included first, before system headers,
> to ensure coherent size_t across the file.
> 
> We force the config.h inclusion by the compiler, so this is not an
> issue (configure.ac: DEFAULT_INCLUDES="-I\$(top_srcdir)
> -I\$(top_builddir) -I\$(top_builddir)/src
> -I\$(top_builddir)/include -include config.h"), but let's remove
> this misleading line of code.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> 
> --- diff --git a/src/common/hashtable/rculfhash.c
> b/src/common/hashtable/rculfhash.c index 776f9f3..423d186 100644 
> --- a/src/common/hashtable/rculfhash.c +++
> b/src/common/hashtable/rculfhash.c @@ -157,7 +157,6 @@ #include
> <stdint.h> #include <string.h>
> 
> -#include "config.h" #include <urcu.h> #include <urcu-call-rcu.h> 
> #include <urcu/arch.h>
> 
-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJQISpMAAoJEELoaioR9I02IkMH/ilFqFAfZEUcKcheR6ZI0Nco
DrL8gyfVIJYcxQFUyduqSsc1vSOtqzlyF3OvyyfHgJBo1HilODrqRBJP5/ZBflDz
DgKkk46c2e3lrSm8pfjHgRDVPiPhTd+axyVjZ/dyGvrMvcPcjLH/QS/tEF1ziXP6
urVW4FT515fXUUYRPyd5K+ooWArlxwQTxExwpayHUqI8VmHHs9fqxjOB7YnkRhyl
vpoQSzyiHsjCPvk1YJoTeC1p5BJmy8YckkwUhNgxgiuuPUMDfhWMoUC76oj2AAR0
TM7m9NgjpdAOEr5TAXFhFJVb8FNaH7nuymiXD/o0aF0/k9ko5vBP5Tdo6RV3xGI=
=c0ji
-----END PGP SIGNATURE-----

[PATCH] Cleanup: Remove misplaced config.h include

[Mathieu Desnoyers]

config.h should _always_ be included first, before system headers, to
ensure coherent size_t across the file.

We force the config.h inclusion by the compiler, so this is not an issue
(configure.ac: DEFAULT_INCLUDES="-I\$(top_srcdir) -I\$(top_builddir)
-I\$(top_builddir)/src -I\$(top_builddir)/include -include config.h"),
but let's remove this misleading line of code.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
diff --git a/src/common/hashtable/rculfhash.c b/src/common/hashtable/rculfhash.c
index 776f9f3..423d186 100644
--- a/src/common/hashtable/rculfhash.c
+++ b/src/common/hashtable/rculfhash.c
@@ -157,7 +157,6 @@
 #include <stdint.h>
 #include <string.h>
 
-#include "config.h"
 #include <urcu.h>
 #include <urcu-call-rcu.h>
 #include <urcu/arch.h>

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com