All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: Laxman Dewangan
	<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ARM: tegra: more regulator fixes for Harmony
Date: Wed, 08 Aug 2012 16:44:16 -0600	[thread overview]
Message-ID: <5022EBC0.5060102@wwwdotorg.org> (raw)
In-Reply-To: <1344037521-6157-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On 08/03/2012 05:45 PM, Stephen Warren wrote:
> Commit 3d55c29 "ARM: tegra: harmony: add regulator supply name and its
> input supply" was supposed to fix all the problems with regulators on
> Harmony. However, it appears that I only tested it when booting using
> board files, not when booting using device tree. This change fixes two
> problems with regulators when booting using device tree:
> 
> 1) That patch only created the vdd_sys regulator when booting using a
>    board file. Since this is the root of the whole regulator tree, this
>    caused no regulators to successfully initialize when booting using
>    device tree. The registration of vdd_sys is moved to fix this.
> 
> 2) When booting use DT, the regulator core sets has_full_constraints,
>    which in turn causes the core to turn off any regulators not marked
>    as always on. Some of the affected regulators are required for basic
>    system operation. To solve this, add always on constraints to all
>    relevant regulators. This doesn't affect booting using a board file
>    since nothing sets has_full_constraints in that case.
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> This is a fix for v3.6.

Arnd, Olof, I don't see this in the arm-soc fixes tree, although do see
you've applied a bunch of patches since I posted this. Did it drop
through the cracks?

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: more regulator fixes for Harmony
Date: Wed, 08 Aug 2012 16:44:16 -0600	[thread overview]
Message-ID: <5022EBC0.5060102@wwwdotorg.org> (raw)
In-Reply-To: <1344037521-6157-1-git-send-email-swarren@wwwdotorg.org>

On 08/03/2012 05:45 PM, Stephen Warren wrote:
> Commit 3d55c29 "ARM: tegra: harmony: add regulator supply name and its
> input supply" was supposed to fix all the problems with regulators on
> Harmony. However, it appears that I only tested it when booting using
> board files, not when booting using device tree. This change fixes two
> problems with regulators when booting using device tree:
> 
> 1) That patch only created the vdd_sys regulator when booting using a
>    board file. Since this is the root of the whole regulator tree, this
>    caused no regulators to successfully initialize when booting using
>    device tree. The registration of vdd_sys is moved to fix this.
> 
> 2) When booting use DT, the regulator core sets has_full_constraints,
>    which in turn causes the core to turn off any regulators not marked
>    as always on. Some of the affected regulators are required for basic
>    system operation. To solve this, add always on constraints to all
>    relevant regulators. This doesn't affect booting using a board file
>    since nothing sets has_full_constraints in that case.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> This is a fix for v3.6.

Arnd, Olof, I don't see this in the arm-soc fixes tree, although do see
you've applied a bunch of patches since I posted this. Did it drop
through the cracks?

  parent reply	other threads:[~2012-08-08 22:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 23:45 [PATCH] ARM: tegra: more regulator fixes for Harmony Stephen Warren
2012-08-03 23:45 ` Stephen Warren
     [not found] ` <1344037521-6157-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-08 22:44   ` Stephen Warren [this message]
2012-08-08 22:44     ` Stephen Warren
     [not found]     ` <5022EBC0.5060102-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-08-09 13:17       ` Arnd Bergmann
2012-08-09 13:17         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5022EBC0.5060102@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.