From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Sven.Schmitt@volkswagen.de
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
Date: Thu, 09 Aug 2012 13:39:32 +0200 [thread overview]
Message-ID: <5023A174.7080301@pengutronix.de> (raw)
In-Reply-To: <50239D47.8020100@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2099 bytes --]
On 08/09/2012 01:21 PM, Marc Kleine-Budde wrote:
> I've found something confusing when I wanted to use more than one
It's not confusing, it's a bug. Good catch.
> sja1000 attached to a platform bus with interrupt sharing. The flag for
> the sja1000 resources I wanted to set first was the
> IORESOURCE_IRQ_SHAREABLE* flag because of the other IORESOURCE_IRQ_XXX
> flags. But this flag is ignored by the sja1000_platform driver because
> it has another position. If I use the generic IRQF_SHARED** flag
> everything works fine. Does it make sense to patch the driver in a way
> like that:
>
> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
> 2012-08-09 10:38:57.405381025 +0200
> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
> 2012-08-09 10:57:22.693364557 +0200
> @@ -109,6 +109,8 @@
> priv = netdev_priv(dev);
>
> dev->irq = res_irq->start;
> + if(res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
> + priv->irq_flags |= IRQF_SHARED;
Please adjust to kernel coding style, space between if and opening bracket.
> priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
> IRQF_SHARED);
Please remove the IRQF_SHARED here, as IRQF_SHARED is wrong here and
means something different.
> priv->reg_base = addr;
> /* The CAN clock frequency is half the oscillator clock
> frequency */
If you have a look at the history of the file, it shows that this flag
was added Yegor Yefremov <yegor_sub1@visionsystems.de> in commit
abde89d can: sja1000: allow shared interrupt definition
Please resend your patch, with the problems fixed, use git send-email
for this, add Yegor on Cc and Sign your work [1]. If this is too
complicated for you, I'll fix it myself.
Marc
[1]
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L298
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-08-09 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6C5A3B79888A804CAB605257CD26D37703955B43@vwagwox00032.vw.vwg>
2012-08-09 11:21 ` Fwd: [Socketcan-users] sja1000_platform interrupt sharing Marc Kleine-Budde
2012-08-09 11:39 ` Marc Kleine-Budde [this message]
2012-08-09 12:46 AW: " Schmitt, Sven (EVM/8)
2012-08-09 12:56 ` Yegor Yefremov
2012-08-09 13:01 ` Marc Kleine-Budde
2012-08-09 13:13 ` Yegor Yefremov
2012-08-09 14:00 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5023A174.7080301@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Sven.Schmitt@volkswagen.de \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.