All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: yegor_sub1@visionsystems.de
Cc: "Schmitt, Sven (EVM/8)" <Sven.Schmitt@volkswagen.de>,
	linux-can@vger.kernel.org
Subject: Re: Fwd: [Socketcan-users] sja1000_platform interrupt sharing
Date: Thu, 09 Aug 2012 15:01:50 +0200	[thread overview]
Message-ID: <5023B4BE.5000104@pengutronix.de> (raw)
In-Reply-To: <5023B38B.80702@visionsystems.de>

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

On 08/09/2012 02:56 PM, Yegor Yefremov wrote:
> Am 09.08.2012 14:46, schrieb Schmitt, Sven (EVM/8):
>> Second try:
>>
>> Signed-off-by: Sven Schmitt <sven.schmitt@volkswagen.de>
>>
>> --- linux-3.5/drivers/net/can/sja1000/sja1000_platform.c.orig
>> +++ linux-3.5/drivers/net/can/sja1000/sja1000_platform.c
>> @@ -109,7 +109,9 @@ static int sp_probe(struct platform_devi
>>  	priv = netdev_priv(dev);
>>  
>>  	dev->irq = res_irq->start;
>> -	priv->irq_flags = res_irq->flags & (IRQF_TRIGGER_MASK |
>> IRQF_SHARED);
>> +	priv->irq_flags &= IRQF_TRIGGER_MASK;
>> +	if (res_irq->flags & IORESOURCE_IRQ_SHAREABLE)
>> +		priv->irq_flags |= IRQF_SHARED;
>>  	priv->reg_base = addr;
>>  	/* The CAN clock frequency is half the oscillator clock
>> frequency */
>>  	priv->can.clock.freq = pdata->osc_freq / 2;
>>
>>
>> note: patch is compile tested only.
>>
>> Sven
> 
> O.K. Nice catch. I just picked the wrong header file
> include/linux/interrupt.h, it should be include/linux/ioport.h. Now
> I'll have to change my board file as well.

A quick serach showed no mainline board using shared irq, have I missed one?

> You can add my
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

You mean Acked-by?

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2012-08-09 13:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-09 12:46 AW: Fwd: [Socketcan-users] sja1000_platform interrupt sharing Schmitt, Sven (EVM/8)
2012-08-09 12:56 ` Yegor Yefremov
2012-08-09 13:01   ` Marc Kleine-Budde [this message]
2012-08-09 13:13     ` Yegor Yefremov
2012-08-09 14:00       ` Marc Kleine-Budde
2012-08-09 13:05 ` AW: " Marc Kleine-Budde
     [not found] ` <1236253306.453.1344517522410.JavaMail.trustmail@VW2BWOSEVG02>
2012-08-09 13:23   ` AW: " Schmitt, Sven (EVM/8)
2012-08-10  8:21 ` Marc Kleine-Budde
2012-08-10  8:23   ` AW: " Schmitt, Sven (EVM/8)
     [not found] <6C5A3B79888A804CAB605257CD26D37703955B43@vwagwox00032.vw.vwg>
2012-08-09 11:21 ` Marc Kleine-Budde
2012-08-09 11:39   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5023B4BE.5000104@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=Sven.Schmitt@volkswagen.de \
    --cc=linux-can@vger.kernel.org \
    --cc=yegor_sub1@visionsystems.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.