All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Stigge <stigge@antcom.de>
To: artem.bityutskiy@linux.intel.com
Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
	linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
	kevin.wells@nxp.com, srinivas.bakki@nxp.com,
	aletes.xgr@gmail.com, dwmw2@infradead.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: lpc32xx_slc: Adjust to pl08x DMA interface changes
Date: Thu, 16 Aug 2012 10:46:48 +0200	[thread overview]
Message-ID: <502CB378.1020708@antcom.de> (raw)
In-Reply-To: <1345027069.3393.124.camel@sauron.fi.intel.com>

Hi,

On 08/15/2012 12:37 PM, Artem Bityutskiy wrote:
> On Thu, 2012-07-12 at 14:22 +0200, Roland Stigge wrote:
>> This patch adjusts the LPC32xx SLC NAND driver to the new pl08x
>> DMA interface, fixing the compile error resulting from changed
>> pl08x structures.
>> 
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
> 
> This patch breaks compilation:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko]
> undefined!
> 
> Please, send a fix. The defconfig I used is attached.

Thanks for the note. The issue happens on compiling lpc32xx_slc and
lpc32xx_mlc as a module. Caused by pl08x_filter_id not being exported.
Looking at other dma drivers, they have an EXPORT_SYMBOL() for this,
see also

drivers/dma/coh901318.c
drivers/dma/sirf-dma.c

Will post a respective adjustment for drivers/dma/amba-pl08x.c separately.

Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: artem.bityutskiy@linux.intel.com
Cc: srinivas.bakki@nxp.com, linux@arm.linux.org.uk, arnd@arndb.de,
	linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
	linux-mtd@lists.infradead.org, aletes.xgr@gmail.com,
	dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: lpc32xx_slc: Adjust to pl08x DMA interface changes
Date: Thu, 16 Aug 2012 10:46:48 +0200	[thread overview]
Message-ID: <502CB378.1020708@antcom.de> (raw)
In-Reply-To: <1345027069.3393.124.camel@sauron.fi.intel.com>

Hi,

On 08/15/2012 12:37 PM, Artem Bityutskiy wrote:
> On Thu, 2012-07-12 at 14:22 +0200, Roland Stigge wrote:
>> This patch adjusts the LPC32xx SLC NAND driver to the new pl08x
>> DMA interface, fixing the compile error resulting from changed
>> pl08x structures.
>> 
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
> 
> This patch breaks compilation:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko]
> undefined!
> 
> Please, send a fix. The defconfig I used is attached.

Thanks for the note. The issue happens on compiling lpc32xx_slc and
lpc32xx_mlc as a module. Caused by pl08x_filter_id not being exported.
Looking at other dma drivers, they have an EXPORT_SYMBOL() for this,
see also

drivers/dma/coh901318.c
drivers/dma/sirf-dma.c

Will post a respective adjustment for drivers/dma/amba-pl08x.c separately.

Roland

WARNING: multiple messages have this Message-ID (diff)
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mtd: lpc32xx_slc: Adjust to pl08x DMA interface changes
Date: Thu, 16 Aug 2012 10:46:48 +0200	[thread overview]
Message-ID: <502CB378.1020708@antcom.de> (raw)
In-Reply-To: <1345027069.3393.124.camel@sauron.fi.intel.com>

Hi,

On 08/15/2012 12:37 PM, Artem Bityutskiy wrote:
> On Thu, 2012-07-12 at 14:22 +0200, Roland Stigge wrote:
>> This patch adjusts the LPC32xx SLC NAND driver to the new pl08x
>> DMA interface, fixing the compile error resulting from changed
>> pl08x structures.
>> 
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
> 
> This patch breaks compilation:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko]
> undefined!
> 
> Please, send a fix. The defconfig I used is attached.

Thanks for the note. The issue happens on compiling lpc32xx_slc and
lpc32xx_mlc as a module. Caused by pl08x_filter_id not being exported.
Looking at other dma drivers, they have an EXPORT_SYMBOL() for this,
see also

drivers/dma/coh901318.c
drivers/dma/sirf-dma.c

Will post a respective adjustment for drivers/dma/amba-pl08x.c separately.

Roland

  reply	other threads:[~2012-08-16  8:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 12:22 [PATCH] ARM: LPC32xx: Adjust to pl08x DMA interface changes Roland Stigge
2012-07-12 12:22 ` Roland Stigge
2012-07-12 12:22 ` [PATCH 1/2] mtd: lpc32xx_slc: " Roland Stigge
2012-07-12 12:22   ` Roland Stigge
2012-07-13 12:52   ` Alexandre Pereira da Silva
2012-07-13 12:52     ` Alexandre Pereira da Silva
2012-07-13 12:52     ` Alexandre Pereira da Silva
2012-08-15 10:37   ` Artem Bityutskiy
2012-08-15 10:37     ` Artem Bityutskiy
2012-08-15 10:37     ` Artem Bityutskiy
2012-08-16  8:46     ` Roland Stigge [this message]
2012-08-16  8:46       ` Roland Stigge
2012-08-16  8:46       ` Roland Stigge
2012-08-16 14:26     ` Roland Stigge
2012-08-16 14:26       ` Roland Stigge
2012-08-16 14:26       ` Roland Stigge
2012-07-12 12:22 ` [PATCH 2/2] mtd: lpc32xx_mlc: " Roland Stigge
2012-07-12 12:22   ` Roland Stigge
2012-07-13 12:51   ` Alexandre Pereira da Silva
2012-07-13 12:51     ` Alexandre Pereira da Silva
2012-07-13 12:51     ` Alexandre Pereira da Silva
2012-07-13 12:51 ` [PATCH] ARM: LPC32xx: " Alexandre Pereira da Silva
2012-07-13 12:51   ` Alexandre Pereira da Silva
2012-07-13 12:51   ` Alexandre Pereira da Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502CB378.1020708@antcom.de \
    --to=stigge@antcom.de \
    --cc=aletes.xgr@gmail.com \
    --cc=arnd@arndb.de \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=kevin.wells@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=srinivas.bakki@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.