[RFC PATCH 0/1] kernel.bbclass: remove default module_autoload and module_conf values

[RFC PATCH 0/1] kernel.bbclass: remove default module_autoload and module_conf values

[Bruce Ashfield]

Richard,

This is just what the subject implies, a RFC patch. While working
on some updates and docs, I (once gain) ran across the module_autoload
and module_conf default values in kernel.bbclass.

I've always wondered if that was the best place for these, since the
kernel.bbclass builds many different kernel versions. 

I've simply removed them here, without relocating them to any other
recipe, since I can't see that they are really all that useful for
most targest.

This is a RFC, because I haven't done any research into what this
may or may not break outside of oe-core and reference boards.

Cheers,

Bruce

The following changes since commit fb53d69d9c726e6a663ea276cc440676e20f8326:

  documentation/dev-manual/dev-manual-intro.xml: typo fixed. (2012-07-26 18:53:04 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib zedd/kernel-rfc
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-rfc

Bruce Ashfield (1):
  kernel.bbclass: remove default module_autoload and module_conf values

 meta/classes/kernel.bbclass |   19 -------------------
 1 files changed, 0 insertions(+), 19 deletions(-)

-- 
1.7.5.4

[PATCH 1/1] kernel.bbclass: remove default module_autoload and module_conf values

[Bruce Ashfield]

kernel.bbclass is a common class for many different kernel versions,
and as such the default module_autoload and module_conf values that
it contains are not relevant, or out of date for most builds.

Individual kernel recipes or distros can better specify these
values to meet their needs.

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
 meta/classes/kernel.bbclass |   19 -------------------
 1 files changed, 0 insertions(+), 19 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index ab984e3..c647e9b 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -293,25 +293,6 @@ if [ x"$D" = "x" ]; then
 fi
 }
 
-# autoload defaults (alphabetically sorted)
-module_autoload_hidp = "hidp"
-module_autoload_ipv6 = "ipv6"
-module_autoload_ipsec = "ipsec"
-module_autoload_ircomm-tty = "ircomm-tty"
-module_autoload_rfcomm = "rfcomm"
-module_autoload_sa1100-rtc = "sa1100-rtc"
-# sa1100-rtc was renamed in 2.6.23 onwards
-module_autoload_rtc-sa1100 = "rtc-sa1100"
-
-# alias defaults (alphabetically sorted)
-module_conf_af_packet = "alias net-pf-17 af_packet"
-module_conf_bluez = "alias net-pf-31 bluez"
-module_conf_bnep = "alias bt-proto-4 bnep"
-module_conf_hci_uart = "alias tty-ldisc-15 hci_uart"
-module_conf_l2cap = "alias bt-proto-0 l2cap"
-module_conf_sco = "alias bt-proto-2 sco"
-module_conf_rfcomm = "alias bt-proto-3 rfcomm"
-
 python populate_packages_prepend () {
     def extract_modinfo(file):
         import tempfile, re, subprocess
-- 
1.7.5.4

Re: [PATCH 1/1] kernel.bbclass: remove default module_autoload and module_conf values

[Darren Hart]

On 07/26/2012 11:04 AM, Bruce Ashfield wrote:
> kernel.bbclass is a common class for many different kernel versions,
> and as such the default module_autoload and module_conf values that
> it contains are not relevant, or out of date for most builds.
> 
> Individual kernel recipes or distros can better specify these
> values to meet their needs.
> 
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>

This makes sense to me. None of the below are likely to prevent boot and
seem to be more along the lines of MACHINE policy.

--
Darren

> ---
>  meta/classes/kernel.bbclass |   19 -------------------
>  1 files changed, 0 insertions(+), 19 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index ab984e3..c647e9b 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -293,25 +293,6 @@ if [ x"$D" = "x" ]; then
>  fi
>  }
>  
> -# autoload defaults (alphabetically sorted)
> -module_autoload_hidp = "hidp"
> -module_autoload_ipv6 = "ipv6"
> -module_autoload_ipsec = "ipsec"
> -module_autoload_ircomm-tty = "ircomm-tty"
> -module_autoload_rfcomm = "rfcomm"
> -module_autoload_sa1100-rtc = "sa1100-rtc"
> -# sa1100-rtc was renamed in 2.6.23 onwards
> -module_autoload_rtc-sa1100 = "rtc-sa1100"
> -
> -# alias defaults (alphabetically sorted)
> -module_conf_af_packet = "alias net-pf-17 af_packet"
> -module_conf_bluez = "alias net-pf-31 bluez"
> -module_conf_bnep = "alias bt-proto-4 bnep"
> -module_conf_hci_uart = "alias tty-ldisc-15 hci_uart"
> -module_conf_l2cap = "alias bt-proto-0 l2cap"
> -module_conf_sco = "alias bt-proto-2 sco"
> -module_conf_rfcomm = "alias bt-proto-3 rfcomm"
> -
>  python populate_packages_prepend () {
>      def extract_modinfo(file):
>          import tempfile, re, subprocess
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel

Re: [PATCH 1/1] kernel.bbclass: remove default module_autoload and module_conf values

[Khem Raj]

On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote:

>> kernel.bbclass is a common class for many different kernel versions,
>> and as such the default module_autoload and module_conf values that
>> it contains are not relevant, or out of date for most builds.
>> 
>> Individual kernel recipes or distros can better specify these
>> values to meet their needs.
>> 
>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> 
> This makes sense to me. None of the below are likely to prevent boot and
> seem to be more along the lines of MACHINE policy.
> 

This needs some soak time. For folks who are unknowingly depending on this.

Re: [PATCH 1/1] kernel.bbclass: remove default module_autoload and module_conf values

[Bruce Ashfield]

On Wed, Aug 1, 2012 at 7:15 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote:
>
>>> kernel.bbclass is a common class for many different kernel versions,
>>> and as such the default module_autoload and module_conf values that
>>> it contains are not relevant, or out of date for most builds.
>>>
>>> Individual kernel recipes or distros can better specify these
>>> values to meet their needs.
>>>
>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>>
>> This makes sense to me. None of the below are likely to prevent boot and
>> seem to be more along the lines of MACHINE policy.
>>
>
> This needs some soak time. For folks who are unknowingly depending on this.

Is there a good place to stage this to get more eyes on it ? I'm willing to help
make sure no one is broken, but I'm @ 6 days and got a few comments, but
nothing much .. so if we can do more, I'm all ears!

Cheers,

Bruce

>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [PATCH 1/1] kernel.bbclass: remove default module_autoload and module_conf values

[Khem Raj]

On Wed, Aug 1, 2012 at 7:58 PM, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
> On Wed, Aug 1, 2012 at 7:15 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote:
>>
>>>> kernel.bbclass is a common class for many different kernel versions,
>>>> and as such the default module_autoload and module_conf values that
>>>> it contains are not relevant, or out of date for most builds.
>>>>
>>>> Individual kernel recipes or distros can better specify these
>>>> values to meet their needs.
>>>>
>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>>>
>>> This makes sense to me. None of the below are likely to prevent boot and
>>> seem to be more along the lines of MACHINE policy.
>>>
>>
>> This needs some soak time. For folks who are unknowingly depending on this.
>
> Is there a good place to stage this to get more eyes on it ? I'm willing to help
> make sure no one is broken, but I'm @ 6 days and got a few comments, but
> nothing much .. so if we can do more, I'm all ears!
>

Well I fixed my case :)

> Cheers,
>
> Bruce
>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [PATCH 1/1] kernel.bbclass: remove default module_autoload and module_conf values

[Bruce Ashfield]

On Wed, Aug 1, 2012 at 11:12 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Wed, Aug 1, 2012 at 7:58 PM, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>> On Wed, Aug 1, 2012 at 7:15 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>> On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote:
>>>
>>>>> kernel.bbclass is a common class for many different kernel versions,
>>>>> and as such the default module_autoload and module_conf values that
>>>>> it contains are not relevant, or out of date for most builds.
>>>>>
>>>>> Individual kernel recipes or distros can better specify these
>>>>> values to meet their needs.
>>>>>
>>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>>>>
>>>> This makes sense to me. None of the below are likely to prevent boot and
>>>> seem to be more along the lines of MACHINE policy.
>>>>
>>>
>>> This needs some soak time. For folks who are unknowingly depending on this.
>>
>> Is there a good place to stage this to get more eyes on it ? I'm willing to help
>> make sure no one is broken, but I'm @ 6 days and got a few comments, but
>> nothing much .. so if we can do more, I'm all ears!
>>
>
> Well I fixed my case :)

Ha! You should have just said that (I'm dense at times) :P So it's
working as designed, let it soak!

Cheers,

Bruce

>
>> Cheers,
>>
>> Bruce
>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>>
>> --
>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end"
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [RFC PATCH 0/1] kernel.bbclass: remove default module_autoload and module_conf values

[Saul Wold]

On 07/26/2012 11:04 AM, Bruce Ashfield wrote:
> Richard,
>
> This is just what the subject implies, a RFC patch. While working
> on some updates and docs, I (once gain) ran across the module_autoload
> and module_conf default values in kernel.bbclass.
>
> I've always wondered if that was the best place for these, since the
> kernel.bbclass builds many different kernel versions.
>
> I've simply removed them here, without relocating them to any other
> recipe, since I can't see that they are really all that useful for
> most targest.
>
> This is a RFC, because I haven't done any research into what this
> may or may not break outside of oe-core and reference boards.
>
> Cheers,
>
> Bruce
>
> The following changes since commit fb53d69d9c726e6a663eaOn 07/26/2012 11:04 AM, Bruce Ashfield wrote:> Richard,
>
> This is just what the subject implies, a RFC patch. While working
> on some updates and docs, I (once gain) ran across the module_autoload
> and module_conf default values in kernel.bbclass.
>
> I've always wondered if that was the best place for these, since the
> kernel.bbclass builds many different kernel versions.
>
> I've simply removed them here, without relocating them to any other
> recipe, since I can't see that they are really all that useful for
> most targest.
>
> This is a RFC, because I haven't done any research into what this
> may or may not break outside of oe-core and reference boards.
>
> Cheers,
>
> Bruce
>
> The following changes since commit fb53d69d9c726e6a663ea276cc440676e20f8326:
>
>    documentation/dev-manual/dev-manual-intro.xml: typo fixed. (2012-07-26 18:53:04 +0100)
>
> are available in the git repository at:
>    git://git.pokylinux.org/poky-contrib zedd/kernel-rfc
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-rfc
>
> Bruce Ashfield (1):
>    kernel.bbclass: remove default module_autoload and module_conf values
>
>   meta/classes/kernel.bbclass |   19 -------------------
>   1 files changed, 0 insertions(+), 19 deletions(-)
>276cc440676e20f8326:
>
>    documentation/dev-manual/dev-manual-intro.xml: typo fixed. (2012-07-26 18:53:04 +0100)
>
> are available in the git repository at:
>    git://git.pokylinux.org/poky-contrib zedd/kernel-rfc
>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-rfc
>
> Bruce Ashfield (1):
>    kernel.bbclass: remove default module_autoload and module_conf values
>
>   meta/classes/kernel.bbclass |   19 -------------------
>   1 files changed, 0 insertions(+), 19 deletions(-)
>
It's soaked and merged into OE-Core now!

Thanks	
	Sau!