[PATCH] libxpm-native: add dependency on gettext-native

[PATCH] libxpm-native: add dependency on gettext-native

[Jesse Zhang]

libxpm needs xgettext. There can be failures if gettext doesn't get built first
and it's not available from the host.

The target version doesn't have issues since it will get the dependency
indirectly.

Jesse Zhang (1):
  libxpm-native: add dependency on gettext-native

 meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.7

[PATCH] libxpm-native: add dependency on gettext-native

[Jesse Zhang]

libxpm needs xgettext to build po files. Add explicit dependency on
gettext-native.

Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
---
 meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
index 9eaa212..6830216 100644
--- a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
+++ b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
@@ -10,7 +10,8 @@ protocol."
 LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5"
 DEPENDS += "libxext libsm libxt"
-PR = "r0"
+DEPENDS_virtclass-native = "gettext-native"
+PR = "r1"
 PE = "1"
 
 XORG_PN = "libXpm"
-- 
1.7.7

Re: [PATCH] libxpm-native: add dependency on gettext-native

[Saul Wold]

On 08/02/2012 06:57 PM, Jesse Zhang wrote:
> libxpm needs xgettext. There can be failures if gettext doesn't get built first
> and it's not available from the host.
>
> The target version doesn't have issues since it will get the dependency
> indirectly.
>
> Jesse Zhang (1):
>    libxpm-native: add dependency on gettext-native
>
>   meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
Merged into OE-Core

Thanks
	Sau!

Re: [PATCH] libxpm-native: add dependency on gettext-native

[Mark Hatle]

On 8/16/12 12:51 PM, Saul Wold wrote:
> On 08/02/2012 06:57 PM, Jesse Zhang wrote:
>> libxpm needs xgettext. There can be failures if gettext doesn't get built first
>> and it's not available from the host.
>>
>> The target version doesn't have issues since it will get the dependency
>> indirectly.
>>
>> Jesse Zhang (1):
>>     libxpm-native: add dependency on gettext-native
>>
>>    meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
>>    1 files changed, 2 insertions(+), 1 deletions(-)
>>
> Merged into OE-Core

I'm not finding this patch in the git repository.  I don't think it was actually 
merged.

--Mark

> Thanks
> 	Sau!
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Re: [PATCH] libxpm-native: add dependency on gettext-native

[Saul Wold]

On 08/02/2012 06:57 PM, Jesse Zhang wrote:
> libxpm needs xgettext to build po files. Add explicit dependency on
> gettext-native.
>
> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
> ---
>   meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
> index 9eaa212..6830216 100644
> --- a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
> +++ b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
> @@ -10,7 +10,8 @@ protocol."
>   LICENSE = "BSD"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5"
>   DEPENDS += "libxext libsm libxt"
> -PR = "r0"
> +DEPENDS_virtclass-native = "gettext-native"

Is there a reason you don't do an inherit gettext here to ensure other 
bits are set?  Also for the native, you maybe able to use the 
gettext-minimal-native if there is reason you can't use the inherit.

Sau!

> +PR = "r1"
>   PE = "1"
>
>   XORG_PN = "libXpm"
>

Re: [PATCH] libxpm-native: add dependency on gettext-native

[Jesse Zhang]

Hi Saul,

On 08/21/2012 05:16 AM, Saul Wold wrote:
> On 08/02/2012 06:57 PM, Jesse Zhang wrote:
>> libxpm needs xgettext to build po files. Add explicit dependency on
>> gettext-native.
>>
>> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
>> ---
>>   meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>> index 9eaa212..6830216 100644
>> --- a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>> +++ b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>> @@ -10,7 +10,8 @@ protocol."
>>   LICENSE = "BSD"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5"
>>   DEPENDS += "libxext libsm libxt"
>> -PR = "r0"
>> +DEPENDS_virtclass-native = "gettext-native"
> 
> Is there a reason you don't do an inherit gettext here to ensure other bits are set?

Actually I don't know what's the preferred way to do this. What is
required by libxpm is the xgettext command; using DEPENDS will be enough
to make it available, but I didn't know the other solution.

> Also for the native, you maybe able to use the gettext-minimal-native if there is reason you can't use the inherit.

gettext-minimal-native is already pulled in through the implicit
dependency chain. But clearly it doesn't provide xgettext?

jesse

> 
>> +PR = "r1"
>>   PE = "1"
>>
>>   XORG_PN = "libXpm"
>>
> 
> 

Re: [PATCH] libxpm-native: add dependency on gettext-native

[Saul Wold]

On 08/20/2012 06:35 PM, Jesse Zhang wrote:
> Hi Saul,
>
> On 08/21/2012 05:16 AM, Saul Wold wrote:
>> On 08/02/2012 06:57 PM, Jesse Zhang wrote:
>>> libxpm needs xgettext to build po files. Add explicit dependency on
>>> gettext-native.
>>>
>>> Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
>>> ---
>>>    meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb |    3 ++-
>>>    1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>>> index 9eaa212..6830216 100644
>>> --- a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>>> +++ b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
>>> @@ -10,7 +10,8 @@ protocol."
>>>    LICENSE = "BSD"
>>>    LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5"
>>>    DEPENDS += "libxext libsm libxt"
>>> -PR = "r0"
>>> +DEPENDS_virtclass-native = "gettext-native"
>>
>> Is there a reason you don't do an inherit gettext here to ensure other bits are set?
>
> Actually I don't know what's the preferred way to do this. What is
> required by libxpm is the xgettext command; using DEPENDS will be enough
> to make it available, but I didn't know the other solution.
>
Ok, well I am telling you there is another, more correct, way to do this 
using the inherit gettext, so please try using inherit gettext and see 
if that works correctly.  The meta/classes/gettext.bbclass in 
conjunction with native.bbclass correctly set the DEPENDS to use 
gettext-native.

Also, on another note, please modify your patch subject to just say 
libxpm, this initial confused a couple of us thinking that libxpm was a 
native specific recipe.

Sau!


>> Also for the native, you maybe able to use the gettext-minimal-native if there is reason you can't use the inherit.
>
> gettext-minimal-native is already pulled in through the implicit
> dependency chain. But clearly it doesn't provide xgettext?
>
> jesse
>
>>
>>> +PR = "r1"
>>>    PE = "1"
>>>
>>>    XORG_PN = "libXpm"
>>>
>>
>>
>
>

[PATCH v2 0/1] libxpm: inherit gettext

[Jesse Zhang]

Hi Saul,

Thanks for the advice. I've changed it to use "inherit gettext" instead.

The following changes since commit 054d95edad8d79ef1c6b30681395d50f3c6335b4:

  poky.conf: restore Ubuntu 12.04 LTS to tested distro list (2012-08-23 17:23:40 +0100)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib szhang/xpm
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=szhang/xpm

Jesse Zhang (1):
  libxpm: inherit gettext

 meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
1.7.11.4

[PATCH 1/1] libxpm: inherit gettext

[Jesse Zhang]

libxpm requires the xgettext command to build.

Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
---
 meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
index 9eaa212..f84a239 100644
--- a/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
+++ b/meta/recipes-graphics/xorg-lib/libxpm_3.5.10.bb
@@ -1,5 +1,8 @@
 require xorg-lib-common.inc
 
+# libxpm requires xgettext to build
+inherit gettext
+
 SUMMARY = "Xpm: X Pixmap extension library"
 
 DESCRIPTION = "libXpm provides support and common operation for the XPM \
@@ -10,7 +13,7 @@ protocol."
 LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=3e07763d16963c3af12db271a31abaa5"
 DEPENDS += "libxext libsm libxt"
-PR = "r0"
+PR = "r1"
 PE = "1"
 
 XORG_PN = "libXpm"
-- 
1.7.11.4