From: "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Felix Kuehling <felix.kuehling@amd.com>
Cc: rcampbell@nvidia.com, willy@infradead.org, david@redhat.com,
apopple@nvidia.com, amd-gfx@lists.freedesktop.org,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
jglisse@redhat.com, dri-devel@lists.freedesktop.org,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only
Date: Mon, 4 Apr 2022 14:22:45 -0500 [thread overview]
Message-ID: <5030bcfd-3931-d8e8-4eaa-7a3127cbd6ad@amd.com> (raw)
In-Reply-To: <20220404173858.GQ2120790@nvidia.com>
On 4/4/2022 12:38 PM, Jason Gunthorpe wrote:
> On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote:
>
>>> In general I find the vm_normal_lru_page vs vm_normal_page
>>> API highly confusing. An explicit check for zone device pages
>>> in the dozen or so spots that care has a much better documentation
>>> value, especially if accompanied by comments where it isn't entirely
>>> obvious.
>> OK. We can do that. It would solve the function naming problem, and we'd
>> have more visibility of device page handling in more places in the kernel,
>> which has educational value.
> Personally I find the 'is page XYZ' pretty confusing, like I don't
> know half of what the PageKsm annotations are for..
>
> Testing against a specific property the code goes on to use right away
> seems more descriptive to me.
Hi Jason,
Are you referring to test for properties such as is_lru_page,
is_numa_page, is_lockable_page, etc?
Otherwise, could you provide an example?
Regards,
Alex Sierra
>
> Jason
WARNING: multiple messages have this Message-ID (diff)
From: "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
Felix Kuehling <felix.kuehling@amd.com>
Cc: Christoph Hellwig <hch@lst.de>,
david@redhat.com, linux-mm@kvack.org, rcampbell@nvidia.com,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only
Date: Mon, 4 Apr 2022 14:22:45 -0500 [thread overview]
Message-ID: <5030bcfd-3931-d8e8-4eaa-7a3127cbd6ad@amd.com> (raw)
In-Reply-To: <20220404173858.GQ2120790@nvidia.com>
On 4/4/2022 12:38 PM, Jason Gunthorpe wrote:
> On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote:
>
>>> In general I find the vm_normal_lru_page vs vm_normal_page
>>> API highly confusing. An explicit check for zone device pages
>>> in the dozen or so spots that care has a much better documentation
>>> value, especially if accompanied by comments where it isn't entirely
>>> obvious.
>> OK. We can do that. It would solve the function naming problem, and we'd
>> have more visibility of device page handling in more places in the kernel,
>> which has educational value.
> Personally I find the 'is page XYZ' pretty confusing, like I don't
> know half of what the PageKsm annotations are for..
>
> Testing against a specific property the code goes on to use right away
> seems more descriptive to me.
Hi Jason,
Are you referring to test for properties such as is_lru_page,
is_numa_page, is_lockable_page, etc?
Otherwise, could you provide an example?
Regards,
Alex Sierra
>
> Jason
next prev parent reply other threads:[~2022-04-04 19:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 21:25 [PATCH v2 0/3] split vm_normal_pages for LRU and non-LRU handling Alex Sierra
2022-03-30 21:25 ` Alex Sierra
2022-03-30 21:25 ` [PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only Alex Sierra
2022-03-30 21:25 ` Alex Sierra
2022-03-31 8:53 ` Christoph Hellwig
2022-03-31 8:53 ` Christoph Hellwig
2022-03-31 8:55 ` David Hildenbrand
2022-03-31 8:55 ` David Hildenbrand
2022-03-31 8:57 ` Christoph Hellwig
2022-03-31 8:57 ` Christoph Hellwig
2022-04-01 20:08 ` Felix Kuehling
2022-04-01 20:08 ` Felix Kuehling
2022-04-04 17:38 ` Jason Gunthorpe
2022-04-04 17:38 ` Jason Gunthorpe
2022-04-04 19:22 ` Sierra Guiza, Alejandro (Alex) [this message]
2022-04-04 19:22 ` Sierra Guiza, Alejandro (Alex)
2022-03-30 21:25 ` [PATCH v2 2/3] tools: add more gup configs to hmm_gup selftests Alex Sierra
2022-03-30 21:25 ` Alex Sierra
2022-03-30 21:25 ` [PATCH v2 3/3] tools: add selftests to hmm for COW in device memory Alex Sierra
2022-03-30 21:25 ` Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5030bcfd-3931-d8e8-4eaa-7a3127cbd6ad@amd.com \
--to=alex.sierra@amd.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.