From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> To: Damien Cassou <damien.cassou@lifl.fr> Cc: kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] drivers/video/bf537-lq035.c: use devm_ functions Date: Thu, 23 Aug 2012 20:36:48 +0000 [thread overview] Message-ID: <50369460.7010303@gmx.de> (raw) In-Reply-To: <1343742860-16213-6-git-send-email-damien.cassou@lifl.fr> On 07/31/2012 01:54 PM, Damien Cassou wrote: > From: Damien Cassou <damien.cassou@lifl.fr> > > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remove > function. > > Signed-off-by: Damien Cassou <damien.cassou@lifl.fr> Applied. Thanks, Florian Tobias Schandinat > > --- > drivers/video/bf537-lq035.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/video/bf537-lq035.c b/drivers/video/bf537-lq035.c > index befbc80..7347aa1 100644 > --- a/drivers/video/bf537-lq035.c > +++ b/drivers/video/bf537-lq035.c > @@ -760,18 +760,20 @@ static int __devinit bfin_lq035_probe(struct platform_device *pdev) > bfin_lq035_fb.flags = FBINFO_DEFAULT; > > > - bfin_lq035_fb.pseudo_palette = kzalloc(sizeof(u32) * 16, GFP_KERNEL); > + bfin_lq035_fb.pseudo_palette = devm_kzalloc(&pdev->dev, > + sizeof(u32) * 16, > + GFP_KERNEL); > if (bfin_lq035_fb.pseudo_palette == NULL) { > pr_err("failed to allocate pseudo_palette\n"); > ret = -ENOMEM; > - goto out_palette; > + goto out_table; > } > > if (fb_alloc_cmap(&bfin_lq035_fb.cmap, NBR_PALETTE, 0) < 0) { > pr_err("failed to allocate colormap (%d entries)\n", > NBR_PALETTE); > ret = -EFAULT; > - goto out_cmap; > + goto out_table; > } > > if (register_framebuffer(&bfin_lq035_fb) < 0) { > @@ -804,9 +806,6 @@ out_lcd: > unregister_framebuffer(&bfin_lq035_fb); > out_reg: > fb_dealloc_cmap(&bfin_lq035_fb.cmap); > -out_cmap: > - kfree(bfin_lq035_fb.pseudo_palette); > -out_palette: > out_table: > dma_free_coherent(NULL, TOTAL_VIDEO_MEM_SIZE, fb_buffer, 0); > fb_buffer = NULL; > @@ -834,7 +833,6 @@ static int __devexit bfin_lq035_remove(struct platform_device *pdev) > free_dma(CH_PPI); > > > - kfree(bfin_lq035_fb.pseudo_palette); > fb_dealloc_cmap(&bfin_lq035_fb.cmap); > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> To: Damien Cassou <damien.cassou@lifl.fr> Cc: kernel-janitors@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] drivers/video/bf537-lq035.c: use devm_ functions Date: Thu, 23 Aug 2012 20:36:48 +0000 [thread overview] Message-ID: <50369460.7010303@gmx.de> (raw) In-Reply-To: <1343742860-16213-6-git-send-email-damien.cassou@lifl.fr> On 07/31/2012 01:54 PM, Damien Cassou wrote: > From: Damien Cassou <damien.cassou@lifl.fr> > > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remove > function. > > Signed-off-by: Damien Cassou <damien.cassou@lifl.fr> Applied. Thanks, Florian Tobias Schandinat > > --- > drivers/video/bf537-lq035.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/video/bf537-lq035.c b/drivers/video/bf537-lq035.c > index befbc80..7347aa1 100644 > --- a/drivers/video/bf537-lq035.c > +++ b/drivers/video/bf537-lq035.c > @@ -760,18 +760,20 @@ static int __devinit bfin_lq035_probe(struct platform_device *pdev) > bfin_lq035_fb.flags = FBINFO_DEFAULT; > > > - bfin_lq035_fb.pseudo_palette = kzalloc(sizeof(u32) * 16, GFP_KERNEL); > + bfin_lq035_fb.pseudo_palette = devm_kzalloc(&pdev->dev, > + sizeof(u32) * 16, > + GFP_KERNEL); > if (bfin_lq035_fb.pseudo_palette = NULL) { > pr_err("failed to allocate pseudo_palette\n"); > ret = -ENOMEM; > - goto out_palette; > + goto out_table; > } > > if (fb_alloc_cmap(&bfin_lq035_fb.cmap, NBR_PALETTE, 0) < 0) { > pr_err("failed to allocate colormap (%d entries)\n", > NBR_PALETTE); > ret = -EFAULT; > - goto out_cmap; > + goto out_table; > } > > if (register_framebuffer(&bfin_lq035_fb) < 0) { > @@ -804,9 +806,6 @@ out_lcd: > unregister_framebuffer(&bfin_lq035_fb); > out_reg: > fb_dealloc_cmap(&bfin_lq035_fb.cmap); > -out_cmap: > - kfree(bfin_lq035_fb.pseudo_palette); > -out_palette: > out_table: > dma_free_coherent(NULL, TOTAL_VIDEO_MEM_SIZE, fb_buffer, 0); > fb_buffer = NULL; > @@ -834,7 +833,6 @@ static int __devexit bfin_lq035_remove(struct platform_device *pdev) > free_dma(CH_PPI); > > > - kfree(bfin_lq035_fb.pseudo_palette); > fb_dealloc_cmap(&bfin_lq035_fb.cmap); > > > >
next prev parent reply other threads:[~2012-08-23 20:36 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-31 13:54 [PATCH 0/5] use devm_ functions Damien Cassou 2012-07-31 13:54 ` Damien Cassou 2012-07-31 13:54 ` [PATCH 5/5] drivers/video/ep93xx-fb.c: " Damien Cassou 2012-07-31 13:54 ` Damien Cassou 2012-08-23 20:35 ` Florian Tobias Schandinat 2012-08-23 20:35 ` Florian Tobias Schandinat 2012-07-31 13:54 ` [PATCH 4/5] drivers/video/da8xx-fb.c: " Damien Cassou 2012-07-31 13:54 ` Damien Cassou 2012-07-31 15:47 ` Sachin Kamat 2012-07-31 15:59 ` Sachin Kamat 2012-07-31 16:01 ` Damien Cassou 2012-07-31 16:01 ` Damien Cassou 2012-07-31 13:54 ` [PATCH 3/5] drivers/video/cobalt_lcdfb.c: " Damien Cassou 2012-07-31 13:54 ` Damien Cassou 2012-08-23 20:36 ` Florian Tobias Schandinat 2012-07-31 13:54 ` [PATCH 2/5] drivers/video/bfin-t350mcqb-fb.c: " Damien Cassou 2012-07-31 13:54 ` Damien Cassou 2012-07-31 13:57 ` Mike Frysinger 2012-07-31 13:57 ` Mike Frysinger 2012-07-31 16:18 ` Damien Cassou 2012-07-31 16:18 ` Damien Cassou 2012-07-31 13:54 ` [PATCH 1/5] drivers/video/bf537-lq035.c: " Damien Cassou 2012-07-31 13:54 ` Damien Cassou 2012-08-23 20:36 ` Florian Tobias Schandinat [this message] 2012-08-23 20:36 ` Florian Tobias Schandinat 2012-07-31 16:39 [PATCH 0/5] " Damien Cassou 2012-07-31 16:39 ` Damien Cassou 2012-07-31 16:39 ` [PATCH 3/5] drivers/video/mbx/mbxfb.c: " Damien Cassou 2012-07-31 16:39 ` Damien Cassou 2012-08-23 20:37 ` Florian Tobias Schandinat 2012-07-31 16:39 ` [PATCH 2/5] drivers/video/gbefb.c: " Damien Cassou 2012-07-31 16:39 ` Damien Cassou 2012-08-23 20:37 ` Florian Tobias Schandinat 2012-09-13 19:06 ` Geert Uytterhoeven 2012-09-13 19:06 ` Geert Uytterhoeven 2012-09-20 21:58 ` Florian Tobias Schandinat 2012-10-11 0:38 ` [PATCH] gbefb: fix compile error Florian Tobias Schandinat 2012-07-31 16:39 ` [PATCH 1/5] drivers/video/fsl-diu-fb.c: use devm_ functions Damien Cassou 2012-07-31 16:39 ` Damien Cassou 2012-08-23 20:38 ` Florian Tobias Schandinat 2012-07-31 16:39 ` [PATCH 4/5] drivers/video/exynos/exynos_mipi_dsi.c: " Damien Cassou 2012-07-31 16:39 ` Damien Cassou 2012-07-31 16:39 ` [PATCH 5/5] drivers/video/exynos/exynos_dp_core.c: " Damien Cassou 2012-07-31 16:39 ` Damien Cassou 2012-07-31 23:21 ` Jingoo Han 2012-07-31 23:21 ` Jingoo Han 2012-08-01 3:59 ` Sachin Kamat 2012-08-01 4:11 ` Sachin Kamat 2012-08-01 4:30 ` Jingoo Han 2012-08-01 4:30 ` Jingoo Han 2012-08-01 4:38 ` Sachin Kamat 2012-08-01 4:50 ` Sachin Kamat 2012-08-01 4:57 ` Jingoo Han 2012-08-01 4:57 ` Jingoo Han 2012-08-01 5:13 ` Julia Lawall 2012-08-01 5:13 ` Julia Lawall 2012-08-01 5:08 ` Jingoo Han 2012-08-01 5:08 ` Jingoo Han 2012-08-01 16:36 ` Damien Cassou 2012-08-01 16:36 ` Damien Cassou 2012-08-03 15:40 [PATCH 0/5] " Damien Cassou 2012-08-03 15:40 ` Damien Cassou 2012-08-03 15:40 ` [PATCH 1/5] drivers/video/epson1355fb.c: " Damien Cassou 2012-08-03 15:40 ` Damien Cassou 2012-08-23 20:40 ` Florian Tobias Schandinat 2012-08-03 15:40 ` [PATCH 3/5] drivers/video/jz4740_fb.c: " Damien Cassou 2012-08-03 15:40 ` Damien Cassou 2012-08-23 20:41 ` Florian Tobias Schandinat 2012-09-02 15:19 ` Lars-Peter Clausen 2012-09-02 15:19 ` Lars-Peter Clausen 2012-08-03 15:40 ` [PATCH 2/5] drivers/video/bf54x-lq043fb.c: " Damien Cassou 2012-08-03 15:40 ` Damien Cassou 2012-08-23 20:41 ` Florian Tobias Schandinat 2012-08-03 15:40 ` [PATCH 5/5] drivers/video/msm/mddi_client_nt35399.c: " Damien Cassou 2012-08-03 15:40 ` Damien Cassou 2012-08-06 9:06 ` Dan Carpenter 2012-08-06 9:06 ` Dan Carpenter 2012-08-09 17:38 ` David Brown 2012-08-09 17:38 ` David Brown 2012-08-23 20:42 ` Florian Tobias Schandinat 2012-08-03 15:40 ` [PATCH 4/5] drivers/video/msm/mddi_client_dummy.c: " Damien Cassou 2012-08-03 15:40 ` Damien Cassou 2012-08-09 17:39 ` David Brown 2012-08-09 17:39 ` David Brown 2012-08-09 17:57 ` David Brown 2012-08-09 17:57 ` David Brown 2012-08-28 8:42 ` Damien Cassou 2012-08-28 8:42 ` Damien Cassou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=50369460.7010303@gmx.de \ --to=florianschandinat@gmx.de \ --cc=damien.cassou@lifl.fr \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.