Re: [PATCH v2] rt2x00: add MediaTek/RaLink Rt3352 WiSoC

From: Daniel Golle <dgolle@allnet.de>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"users@rt2x00.serialmonkey.com" <users@rt2x00.serialmonkey.com>,
	"gwingerde@gmail.com" <gwingerde@gmail.com>,
	"heinold@inf.fu-berlin.de" <heinold@inf.fu-berlin.de>
Subject: Re: [PATCH v2] rt2x00: add MediaTek/RaLink Rt3352 WiSoC
Date: Tue, 28 Aug 2012 15:52:08 +0300	[thread overview]
Message-ID: <503CBEF8.7010505@allnet.de> (raw)
In-Reply-To: <20120828124214.GA8426@redhat.com>

Hi Stanislaw,

On 28/08/12 15:42, Stanislaw Gruszka wrote:
> Thanks. Could you also provide information what was the source
> (registers programming) you based when writing this patch?
The vendor-driver Allnet got for that board (which is not publicly available and
we can't release its source)

>> +	if (rt2x00_rt(rt2x00dev, RT3352)) {
>> +		rt2800_bbp_write(rt2x00dev, 27, 0x0);
>> +		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
>> +		rt2800_bbp_write(rt2x00dev, 27, 0x20);
>> +		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> 
> Writes two times to the same registers are intended?
Yes, as this is how it is done in the vendor driver, to me it looks like
register 27 acts as a switch selecting the destination for the value written to
register 62 or something like that.

Thank you!

Daniel