All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Daniel Golle <dgolle@allnet.de>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
	users@rt2x00.serialmonkey.com, gwingerde@gmail.com,
	heinold@inf.fu-berlin.de
Subject: Re: [PATCH v2] rt2x00: add MediaTek/RaLink Rt3352 WiSoC
Date: Tue, 28 Aug 2012 14:42:15 +0200	[thread overview]
Message-ID: <20120828124214.GA8426@redhat.com> (raw)
In-Reply-To: <20120824152542.GA32145@earthship.home>

Hi

On Fri, Aug 24, 2012 at 06:25:42PM +0300, Daniel Golle wrote:
> On Wed, Aug 22, 2012 at 12:51:10PM +0200, Stanislaw Gruszka wrote:
> > Please address my comments from previous patch.
> 
> I fixed the CodingStyle issues you mentioned and simplified the initilization of
> the TX_SW_CFG{0,1,2} registers similarly to other SoCs.

Thanks. Could you also provide information what was the source
(registers programming) you based when writing this patch?

> +	if (rt2x00_rt(rt2x00dev, RT3352)) {
> +		rt2800_bbp_write(rt2x00dev, 27, 0x0);
> +		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
> +		rt2800_bbp_write(rt2x00dev, 27, 0x20);
> +		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);

Writes two times to the same registers are intended?

Stanislaw

  reply	other threads:[~2012-08-28 12:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 23:53 [PATCH v1] rt2x00: add MediaTek/RaLink Rt3352 WiSoC Daniel Golle
2012-08-22 10:51 ` Stanislaw Gruszka
2012-08-24 15:25   ` [PATCH v2] " Daniel Golle
2012-08-28 12:42     ` Stanislaw Gruszka [this message]
2012-08-28 12:52       ` Daniel Golle
2012-09-07 18:54         ` John W. Linville
2012-09-09 11:24           ` Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120828124214.GA8426@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=dgolle@allnet.de \
    --cc=gwingerde@gmail.com \
    --cc=heinold@inf.fu-berlin.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.