From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com,
qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND
Date: Thu, 30 Aug 2012 15:55:36 -0700 [thread overview]
Message-ID: <503FEF68.1080002@redhat.com> (raw)
In-Reply-To: <6dfa5019b22f1d72b1b02ba14efc9766fcb6e0a9.1346351079.git.jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On 08/30/2012 11:47 AM, Jeff Cody wrote:
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> qerror.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/qerror.h b/qerror.h
> index d0a76a4..7396184 100644
> --- a/qerror.h
> +++ b/qerror.h
> @@ -219,6 +219,9 @@ void assert_no_error(Error *err);
> #define QERR_TOO_MANY_FILES \
> ERROR_CLASS_GENERIC_ERROR, "Too many open files"
>
> +#define QERR_TOP_NOT_FOUND \
> + ERROR_CLASS_GENERIC_ERROR, "Top image file %s not found"
> +
Are you sure this patch is needed, or should you be using error_setg()?
http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg04980.html
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-08-30 22:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 18:47 [Qemu-devel] [RFC v2 PATCH 0/6] Live block commit Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images Jeff Cody
2012-09-06 13:23 ` Kevin Wolf
2012-09-06 14:58 ` Eric Blake
2012-09-06 14:59 ` Jeff Cody
2012-09-07 10:19 ` Kevin Wolf
2012-09-07 15:17 ` Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality Jeff Cody
2012-09-06 14:00 ` Kevin Wolf
2012-09-06 20:37 ` Jeff Cody
2012-09-06 21:16 ` Eric Blake
2012-09-07 15:56 ` Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb Jeff Cody
2012-09-07 16:27 ` Paolo Bonzini
2012-09-07 17:04 ` Jeff Cody
2012-09-07 17:09 ` Paolo Bonzini
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND Jeff Cody
2012-08-30 22:55 ` Eric Blake [this message]
2012-08-31 14:42 ` Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 5/6] block: helper function, to find the base image of a chain Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit' Jeff Cody
2012-08-30 23:06 ` Eric Blake
2012-08-31 14:42 ` Jeff Cody
2012-09-06 14:29 ` Kevin Wolf
2012-09-06 21:00 ` Jeff Cody
2012-08-30 21:31 ` [Qemu-devel] [RFC v2 PATCH 0/6] Live block commit Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503FEF68.1080002@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=supriyak@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.