* [PATCH] wic: Use custom kernel path if provided
@ 2022-02-15 16:54 Bill Pittman
2022-03-02 18:15 ` Bill Pittman
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Bill Pittman @ 2022-02-15 16:54 UTC (permalink / raw)
To: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
If the custom kernel path is provided in options, then
use that path instead of the default path.
Signed-off-by: Bill Pittman <bill.pittman@ni.com>
---
scripts/wic | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/wic b/scripts/wic
index a741aed364..29a157bf37 100755
--- a/scripts/wic
+++ b/scripts/wic
@@ -159,6 +159,9 @@ def wic_create_subcommand(options, usage_str):
"(Use -e/--image-name to specify it)")
native_sysroot = options.native_sysroot
+ if options.kernel_dir:
+ kernel_dir = options.kernel_dir
+
if not options.vars_dir and (not native_sysroot or not os.path.isdir(native_sysroot)):
logger.info("Building wic-tools...\n")
subprocess.check_call(["bitbake", "wic-tools"])
--
2.25.1
INTERNAL - NI CONFIDENTIAL
[-- Attachment #2: Type: text/html, Size: 1799 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] wic: Use custom kernel path if provided
2022-02-15 16:54 [PATCH] wic: Use custom kernel path if provided Bill Pittman
@ 2022-03-02 18:15 ` Bill Pittman
2022-03-02 22:06 ` [OE-core] " Andrei Gherzan
2022-03-02 23:02 ` [OE-core] " Richard Purdie
2 siblings, 0 replies; 6+ messages in thread
From: Bill Pittman @ 2022-03-02 18:15 UTC (permalink / raw)
To: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
Hey all,
Gentle ping on this patch, any comments?
Thanks,
Bill
________________________________
From: Bill Pittman
Sent: Tuesday, February 15, 2022 10:54 AM
To: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Subject: [PATCH] wic: Use custom kernel path if provided
If the custom kernel path is provided in options, then
use that path instead of the default path.
INTERNAL - NI CONFIDENTIAL
[-- Attachment #2: Type: text/html, Size: 1977 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] wic: Use custom kernel path if provided
2022-02-15 16:54 [PATCH] wic: Use custom kernel path if provided Bill Pittman
2022-03-02 18:15 ` Bill Pittman
@ 2022-03-02 22:06 ` Andrei Gherzan
[not found] ` <SN6PR04MB49098B84F7D5490D734B7EB1EC089@SN6PR04MB4909.namprd04.prod.outlook.com>
2022-03-02 23:02 ` [OE-core] " Richard Purdie
2 siblings, 1 reply; 6+ messages in thread
From: Andrei Gherzan @ 2022-03-02 22:06 UTC (permalink / raw)
To: Bill Pittman; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
Feb 15, 2022 16:54:28 Bill Pittman <bill.pittman@ni.com>:
> If the custom kernel path is provided in options, then
> use that path instead of the default path.
Just to understand this a bit, what is your usecase here?
--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640
[-- Attachment #2: Type: text/html, Size: 952 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH] wic: Use custom kernel path if provided
2022-02-15 16:54 [PATCH] wic: Use custom kernel path if provided Bill Pittman
2022-03-02 18:15 ` Bill Pittman
2022-03-02 22:06 ` [OE-core] " Andrei Gherzan
@ 2022-03-02 23:02 ` Richard Purdie
[not found] ` <SN6PR04MB4909394161091073345E1ACBEC089@SN6PR04MB4909.namprd04.prod.outlook.com>
2 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2022-03-02 23:02 UTC (permalink / raw)
To: Bill Pittman, openembedded-core
On Tue, 2022-02-15 at 16:54 +0000, Bill Pittman wrote:
> If the custom kernel path is provided in options, then
> use that path instead of the default path.
>
> Signed-off-by: Bill Pittman <bill.pittman@ni.com>
> ---
> scripts/wic | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/wic b/scripts/wic
> index a741aed364..29a157bf37 100755
> --- a/scripts/wic
> +++ b/scripts/wic
> @@ -159,6 +159,9 @@ def wic_create_subcommand(options, usage_str):
> "(Use -e/--image-name to specify it)")
> native_sysroot = options.native_sysroot
>
> + if options.kernel_dir:
> + kernel_dir = options.kernel_dir
> +
> if not options.vars_dir and (not native_sysroot or not
> os.path.isdir(native_sysroot)):
> logger.info("Building wic-tools...\n")
> subprocess.check_call(["bitbake", "wic-tools"])
The concern with these kinds of changes is I can't really test it or tell if it
is the right thing to do and I worry about it regressing in the future.
Is there part of the test coverage we should be improving too? wic does have
fairly good coverage from oe-selftest -r wic
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-07 16:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 16:54 [PATCH] wic: Use custom kernel path if provided Bill Pittman
2022-03-02 18:15 ` Bill Pittman
2022-03-02 22:06 ` [OE-core] " Andrei Gherzan
[not found] ` <SN6PR04MB49098B84F7D5490D734B7EB1EC089@SN6PR04MB4909.namprd04.prod.outlook.com>
2022-03-07 16:37 ` Bill Pittman
2022-03-02 23:02 ` [OE-core] " Richard Purdie
[not found] ` <SN6PR04MB4909394161091073345E1ACBEC089@SN6PR04MB4909.namprd04.prod.outlook.com>
2022-03-07 16:38 ` Bill Pittman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.