From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Lee Jones <lee.jones@linaro.org> Cc: Philipp Zabel <p.zabel@pengutronix.de>, David Airlie <airlied@linux.ie>, Fabio Estevam <festevam@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, NXP Linux Team <linux-imx@nxp.com>, Daniel Vetter <daniel@ffwll.ch>, Shawn Guo <shawnguo@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de> Subject: Re: [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused Date: Fri, 6 Nov 2020 09:44:35 +0100 [thread overview] Message-ID: <5056c156-9f6c-8e0d-54e8-5317fdd46c12@pengutronix.de> (raw) In-Reply-To: <20201106074151.GU4488@dell> On 11/6/20 8:41 AM, Lee Jones wrote: > On Thu, 05 Nov 2020, Ahmad Fatoum wrote: > >> Hello Lee, >> >> On 11/5/20 3:45 PM, Lee Jones wrote: >>> In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided >>> as a container for state->crtcs[i].new_state, but is not utilised in >>> this use-case. We cannot simply delete the variable, so here we tell >>> the compiler that we're intentionally discarding the read value. >> >> for_each_oldnew_crtc_in_state already (void) casts the drm_crtc and the old >> drm_crtc_state to silence unused-but-set-variable warning. Should we maybe >> (void) cast the new crtc_state as well? > > From what I saw, it only void casts the ones which aren't assigned. How do you mean? I wonder if #define for_each_oldnew_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ for ((__i) = 0; \ (__i) < (__state)->dev->mode_config.num_crtc; \ (__i)++) \ for_each_if ((__state)->crtcs[__i].ptr && \ ((crtc) = (__state)->crtcs[__i].ptr, \ (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ (old_crtc_state) = (__state)->crtcs[__i].old_state, \ (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, \ - (new_crtc_state) = (__state)->crtcs[__i].new_state, 1)) + (new_crtc_state) = (__state)->crtcs[__i].new_state, \ + (void)(new_crtc_state), 1)) wouldn't be better. > >>> Fixes the following W=1 kernel build warning(s): >>> >>> drivers/gpu/drm/imx/ipuv3-plane.c: In function ‘ipu_planes_assign_pre’: >>> drivers/gpu/drm/imx/ipuv3-plane.c:746:42: warning: variable ‘crtc_state’ set but not used [-Wunused-but-set-variable] >>> >>> Cc: Philipp Zabel <p.zabel@pengutronix.de> >>> Cc: David Airlie <airlied@linux.ie> >>> Cc: Daniel Vetter <daniel@ffwll.ch> >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> Cc: Sascha Hauer <s.hauer@pengutronix.de> >>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> >>> Cc: Fabio Estevam <festevam@gmail.com> >>> Cc: NXP Linux Team <linux-imx@nxp.com> >>> Cc: dri-devel@lists.freedesktop.org >>> Signed-off-by: Lee Jones <lee.jones@linaro.org> >>> --- >>> drivers/gpu/drm/imx/ipuv3-plane.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c >>> index 8a4235d9d9f1e..acc0a3ce4992f 100644 >>> --- a/drivers/gpu/drm/imx/ipuv3-plane.c >>> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c >>> @@ -743,7 +743,7 @@ bool ipu_plane_atomic_update_pending(struct drm_plane *plane) >>> int ipu_planes_assign_pre(struct drm_device *dev, >>> struct drm_atomic_state *state) >>> { >>> - struct drm_crtc_state *old_crtc_state, *crtc_state; >>> + struct drm_crtc_state *old_crtc_state, __always_unused *crtc_state; >>> struct drm_plane_state *plane_state; >>> struct ipu_plane_state *ipu_state; >>> struct ipu_plane *ipu_plane; >>> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Lee Jones <lee.jones@linaro.org> Cc: David Airlie <airlied@linux.ie>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de> Subject: Re: [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused Date: Fri, 6 Nov 2020 09:44:35 +0100 [thread overview] Message-ID: <5056c156-9f6c-8e0d-54e8-5317fdd46c12@pengutronix.de> (raw) In-Reply-To: <20201106074151.GU4488@dell> On 11/6/20 8:41 AM, Lee Jones wrote: > On Thu, 05 Nov 2020, Ahmad Fatoum wrote: > >> Hello Lee, >> >> On 11/5/20 3:45 PM, Lee Jones wrote: >>> In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided >>> as a container for state->crtcs[i].new_state, but is not utilised in >>> this use-case. We cannot simply delete the variable, so here we tell >>> the compiler that we're intentionally discarding the read value. >> >> for_each_oldnew_crtc_in_state already (void) casts the drm_crtc and the old >> drm_crtc_state to silence unused-but-set-variable warning. Should we maybe >> (void) cast the new crtc_state as well? > > From what I saw, it only void casts the ones which aren't assigned. How do you mean? I wonder if #define for_each_oldnew_crtc_in_state(__state, crtc, old_crtc_state, new_crtc_state, __i) \ for ((__i) = 0; \ (__i) < (__state)->dev->mode_config.num_crtc; \ (__i)++) \ for_each_if ((__state)->crtcs[__i].ptr && \ ((crtc) = (__state)->crtcs[__i].ptr, \ (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ (old_crtc_state) = (__state)->crtcs[__i].old_state, \ (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, \ - (new_crtc_state) = (__state)->crtcs[__i].new_state, 1)) + (new_crtc_state) = (__state)->crtcs[__i].new_state, \ + (void)(new_crtc_state), 1)) wouldn't be better. > >>> Fixes the following W=1 kernel build warning(s): >>> >>> drivers/gpu/drm/imx/ipuv3-plane.c: In function ‘ipu_planes_assign_pre’: >>> drivers/gpu/drm/imx/ipuv3-plane.c:746:42: warning: variable ‘crtc_state’ set but not used [-Wunused-but-set-variable] >>> >>> Cc: Philipp Zabel <p.zabel@pengutronix.de> >>> Cc: David Airlie <airlied@linux.ie> >>> Cc: Daniel Vetter <daniel@ffwll.ch> >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> Cc: Sascha Hauer <s.hauer@pengutronix.de> >>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> >>> Cc: Fabio Estevam <festevam@gmail.com> >>> Cc: NXP Linux Team <linux-imx@nxp.com> >>> Cc: dri-devel@lists.freedesktop.org >>> Signed-off-by: Lee Jones <lee.jones@linaro.org> >>> --- >>> drivers/gpu/drm/imx/ipuv3-plane.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c >>> index 8a4235d9d9f1e..acc0a3ce4992f 100644 >>> --- a/drivers/gpu/drm/imx/ipuv3-plane.c >>> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c >>> @@ -743,7 +743,7 @@ bool ipu_plane_atomic_update_pending(struct drm_plane *plane) >>> int ipu_planes_assign_pre(struct drm_device *dev, >>> struct drm_atomic_state *state) >>> { >>> - struct drm_crtc_state *old_crtc_state, *crtc_state; >>> + struct drm_crtc_state *old_crtc_state, __always_unused *crtc_state; >>> struct drm_plane_state *plane_state; >>> struct ipu_plane_state *ipu_state; >>> struct ipu_plane *ipu_plane; >>> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-06 8:44 UTC|newest] Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-05 14:44 [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU Lee Jones 2020-11-05 14:44 ` Lee Jones 2020-11-05 14:44 ` Lee Jones 2020-11-05 14:44 ` [PATCH 01/19] gpu: host1x: bus: Add missing description for 'driver' Lee Jones 2020-11-05 14:44 ` Lee Jones 2020-11-05 16:45 ` Thierry Reding 2020-11-05 16:45 ` Thierry Reding 2020-11-05 21:13 ` Sam Ravnborg 2020-11-05 21:13 ` Sam Ravnborg 2020-11-05 14:45 ` [PATCH 02/19] gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 19:17 ` Ahmad Fatoum 2020-11-05 19:17 ` Ahmad Fatoum 2020-11-06 7:41 ` Lee Jones 2020-11-06 7:41 ` Lee Jones 2020-11-06 8:44 ` Ahmad Fatoum [this message] 2020-11-06 8:44 ` Ahmad Fatoum 2020-11-06 8:49 ` Lee Jones 2020-11-06 8:49 ` Lee Jones 2020-11-05 14:45 ` [PATCH 04/19] gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 17:06 ` Tomi Valkeinen 2020-11-05 17:06 ` Tomi Valkeinen 2020-11-05 14:45 ` [PATCH 05/19] gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` [PATCH 06/19] gpu: drm: scheduler: sched_main: Provide missing description for 'sched' paramter Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-10 21:12 ` Alex Deucher 2020-11-10 21:12 ` Alex Deucher 2020-11-05 14:45 ` [PATCH 07/19] gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc headers Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-10 21:13 ` Alex Deucher 2020-11-10 21:13 ` Alex Deucher 2020-11-05 14:45 ` [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 16:53 ` Tomi Valkeinen 2020-11-05 16:53 ` Tomi Valkeinen 2020-11-05 18:07 ` Lee Jones 2020-11-05 18:07 ` Lee Jones 2020-11-06 14:03 ` Tomi Valkeinen 2020-11-06 14:03 ` Tomi Valkeinen 2020-11-06 14:32 ` Lee Jones 2020-11-06 14:32 ` Lee Jones 2020-11-06 4:26 ` Laurent Pinchart 2020-11-06 4:26 ` Laurent Pinchart 2020-11-05 14:45 ` [PATCH 09/19] gpu: drm: selftests: test-drm_framebuffer: Remove set but unused variable 'fb' Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` [PATCH 10/19] gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of kernel-doc abuses Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` [PATCH 11/19] gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 16:46 ` Thierry Reding 2020-11-05 16:46 ` Thierry Reding 2020-11-05 21:16 ` Sam Ravnborg 2020-11-05 21:16 ` Sam Ravnborg 2020-11-05 14:45 ` [PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd' Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 21:21 ` Sam Ravnborg 2020-11-05 21:21 ` Sam Ravnborg 2020-11-05 14:45 ` [PATCH 13/19] gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-06 19:17 ` Lyude Paul 2020-11-06 19:17 ` Lyude Paul 2020-11-06 19:25 ` Lee Jones 2020-11-06 19:25 ` Lee Jones 2020-11-09 15:19 ` Ville Syrjälä 2020-11-09 15:19 ` Ville Syrjälä 2020-11-09 16:12 ` Lee Jones 2020-11-09 16:12 ` Lee Jones 2020-11-09 16:13 ` Lee Jones 2020-11-09 16:13 ` Lee Jones 2020-11-09 16:20 ` Ville Syrjälä 2020-11-09 16:20 ` Ville Syrjälä 2020-11-09 16:40 ` Lee Jones 2020-11-09 16:40 ` Lee Jones 2020-11-09 17:03 ` Ville Syrjälä 2020-11-09 17:03 ` Ville Syrjälä 2020-11-09 17:17 ` Lee Jones 2020-11-09 17:17 ` Lee Jones 2020-11-05 14:45 ` [PATCH 15/19] gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-10 21:14 ` Alex Deucher 2020-11-10 21:14 ` Alex Deucher 2020-11-10 21:14 ` Alex Deucher 2020-11-10 21:20 ` Lee Jones 2020-11-10 21:20 ` Lee Jones 2020-11-10 21:20 ` Lee Jones 2020-11-05 14:45 ` [PATCH 16/19] gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant kernel-doc header Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 16:47 ` Thierry Reding 2020-11-05 16:47 ` Thierry Reding 2020-11-05 21:17 ` Sam Ravnborg 2020-11-05 21:17 ` Sam Ravnborg 2020-11-06 7:43 ` Lee Jones 2020-11-06 7:43 ` Lee Jones 2020-11-06 16:11 ` Sam Ravnborg 2020-11-06 16:11 ` Sam Ravnborg 2020-11-06 16:54 ` Lee Jones 2020-11-06 16:54 ` Lee Jones 2020-11-05 14:45 ` [PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-10 21:50 ` Alex Deucher 2020-11-10 21:50 ` Alex Deucher 2020-11-10 21:50 ` Alex Deucher 2020-11-05 14:45 ` [PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-10 21:48 ` Alex Deucher 2020-11-10 21:48 ` Alex Deucher 2020-11-10 21:48 ` Alex Deucher 2020-11-05 14:45 ` [PATCH 19/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_start_aux_transaction' Lee Jones 2020-11-05 14:45 ` Lee Jones 2020-11-05 16:38 ` [PATCH 00/19] [Set 1] Rid W=1 warnings from GPU Sam Ravnborg 2020-11-05 16:38 ` Sam Ravnborg 2020-11-05 16:38 ` Sam Ravnborg 2020-11-05 18:12 ` Lee Jones 2020-11-05 18:12 ` Lee Jones 2020-11-05 18:12 ` Lee Jones 2020-11-05 16:48 ` Thierry Reding 2020-11-05 16:48 ` Thierry Reding 2020-11-05 16:48 ` Thierry Reding 2020-11-05 18:10 ` Lee Jones 2020-11-05 18:10 ` Lee Jones 2020-11-05 18:10 ` Lee Jones 2020-11-05 18:14 ` Daniel Vetter 2020-11-05 18:14 ` Daniel Vetter 2020-11-05 18:14 ` Daniel Vetter 2020-11-05 18:24 ` Lee Jones 2020-11-05 18:24 ` Lee Jones 2020-11-05 18:24 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5056c156-9f6c-8e0d-54e8-5317fdd46c12@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.