From: vaxon <gvaxon@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] mplayer: Fix external libdvdread and libdvdnav support
Date: Thu, 27 Sep 2012 00:59:13 +0400 [thread overview]
Message-ID: <50636CA1.3070401@gmail.com> (raw)
In-Reply-To: <20120926224604.2cb082f2@skate>
On 09/27/2012 12:46 AM, Thomas Petazzoni wrote:
> Dear Valentine Barshak,
>
> On Wed, 26 Sep 2012 23:34:51 +0400, Valentine Barshak wrote:
>
>> +ifeq ($(BR2_PACKAGE_LIBDVDREAD),y)
>> +MPLAYER_CONF_OPTS += \
>> + --enable-dvdread \
>> + --disable-dvdread-internal \
>> + --with-dvdread-config=$(STAGING_DIR)/usr/bin/dvdread-config
>> +MPLAYER_DEPENDENCIES += libdvdread
>> +endif
>
> Don't we want a:
>
> else
> MPLAYER_CONF_OPTS += --disable-dvdread --disable-dvdread-internal
> endif
Not really, these options are set to "auto" by default and will be
disabled when mplayer fails to find libcdio, which internal dvdread
depends on.
I did not manually disable it. In case libcdio is added later mplayer
would use it for internal dvdread when libdvdread is disabled.
Thanks,
Val.
>
>> +ifeq ($(BR2_PACKAGE_LIBDVDNAV),y)
>> +MPLAYER_CONF_OPTS += \
>> + --enable-dvdnav \
>> + --with-dvdnav-config=$(STAGING_DIR)/usr/bin/dvdnav-config
>> +MPLAYER_DEPENDENCIES += libdvdnav
>> +endif
>
> else
> MPLAYER_CONF_OPTS += --disable-dvdnav
> endif
>
> Thanks,
>
> Thomas
>
next prev parent reply other threads:[~2012-09-26 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 19:31 [Buildroot] [PATCH 0/3] Fix libdvdread and libdvdnav support Valentine Barshak
2012-09-26 19:33 ` [Buildroot] [PATCH 1/3] libdvdread: Fix dvdread-config Valentine Barshak
2012-09-26 19:33 ` [Buildroot] [PATCH 2/3] libdvdnav: Fix dvdnav-config Valentine Barshak
2012-09-26 20:46 ` Thomas Petazzoni
2012-09-26 21:05 ` vaxon
2012-09-26 19:34 ` [Buildroot] [PATCH 3/3] mplayer: Fix external libdvdread and libdvdnav support Valentine Barshak
2012-09-26 20:46 ` Thomas Petazzoni
2012-09-26 20:59 ` vaxon [this message]
[not found] ` <50636C68.5030601@gmail.com>
2012-09-27 12:25 ` Valentine Barshak
2012-09-27 12:37 ` Thomas Petazzoni
2012-09-27 18:09 ` Valentine Barshak
2012-10-04 21:27 ` [Buildroot] [PATCH 0/3] Fix " Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50636CA1.3070401@gmail.com \
--to=gvaxon@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.