All of lore.kernel.org
 help / color / mirror / Atom feed
From: vaxon <gvaxon@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] libdvdnav: Fix dvdnav-config
Date: Thu, 27 Sep 2012 01:05:55 +0400	[thread overview]
Message-ID: <50636E33.9030101@gmail.com> (raw)
In-Reply-To: <20120926224634.7bddf310@skate>

On 09/27/2012 12:46 AM, Thomas Petazzoni wrote:
> Dear Valentine Barshak,
>
> On Wed, 26 Sep 2012 23:33:51 +0400, Valentine Barshak wrote:
>
>> +ifneq ($(BR2_HAVE_DEVFILES),y)
>> +LIBDVDNAV_POST_INSTALL_TARGET_HOOKS += LIBDVDNAV_TARGET_CLEANUP
>> +endif
>
> We generally prefer positive logic:
>
> ifeq ($(BR2_HAVE_DEVFILES),)
> ...
> endif

The ifneq(($BR2_HAVE_DEVFILES),y) was copy-pasted from other .mk file 
and it seems to be used much more often than ifeq($(BR2_HAVE_DEVFILES),).

Thanks,
Val.

>
> Thomas
>

  reply	other threads:[~2012-09-26 21:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 19:31 [Buildroot] [PATCH 0/3] Fix libdvdread and libdvdnav support Valentine Barshak
2012-09-26 19:33 ` [Buildroot] [PATCH 1/3] libdvdread: Fix dvdread-config Valentine Barshak
2012-09-26 19:33 ` [Buildroot] [PATCH 2/3] libdvdnav: Fix dvdnav-config Valentine Barshak
2012-09-26 20:46   ` Thomas Petazzoni
2012-09-26 21:05     ` vaxon [this message]
2012-09-26 19:34 ` [Buildroot] [PATCH 3/3] mplayer: Fix external libdvdread and libdvdnav support Valentine Barshak
2012-09-26 20:46   ` Thomas Petazzoni
2012-09-26 20:59     ` vaxon
     [not found]     ` <50636C68.5030601@gmail.com>
2012-09-27 12:25       ` Valentine Barshak
2012-09-27 12:37         ` Thomas Petazzoni
2012-09-27 18:09           ` Valentine Barshak
2012-10-04 21:27 ` [Buildroot] [PATCH 0/3] Fix " Peter Korsgaard
2012-09-27 18:13 [Buildroot] [PATCH 0/3] Fix libdvdread and libdvdnav support v2 Valentine Barshak
2012-09-27 18:17 ` [Buildroot] [PATCH 2/3] libdvdnav: Fix dvdnav-config Valentine Barshak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50636E33.9030101@gmail.com \
    --to=gvaxon@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.