[PATCH] ARM: dts: qcom: pm8226: Add VADC node

[PATCH] ARM: dts: qcom: pm8226: Add VADC node

[Rayyan Ansari]

Add a node for the voltage ADC (VADC) found in PM8226.

Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
 arch/arm/boot/dts/qcom-pm8226.dtsi | 33 ++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
index b3d0f7b5874d..a651b4c941b8 100644
--- a/arch/arm/boot/dts/qcom-pm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
@@ -40,6 +40,39 @@ smbb: charger@1000 {
 			chg_otg: otg-vbus { };
 		};
 
+		pm8226_vadc: adc@3100 {
+			compatible = "qcom,spmi-vadc";
+			reg = <0x3100>;
+			interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			#io-channel-cells = <1>;
+
+			adc-chan@7 {
+				reg = <VADC_VSYS>;
+				qcom,pre-scaling = <1 3>;
+				label = "vph_pwr";
+			};
+			adc-chan@8 {
+				reg = <VADC_DIE_TEMP>;
+				label = "die_temp";
+			};
+			adc-chan@9 {
+				reg = <VADC_REF_625MV>;
+				label = "ref_625mv";
+			};
+			adc-chan@a {
+				reg = <VADC_REF_1250MV>;
+				label = "ref_1250mv";
+			};
+			adc-chan@e {
+				reg = <VADC_GND_REF>;
+			};
+			adc-chan@f {
+				reg = <VADC_VDD_VADC>;
+			};
+		};
+
 		pm8226_mpps: mpps@a000 {
 			compatible = "qcom,pm8226-mpp", "qcom,spmi-mpp";
 			reg = <0xa000>;
-- 
2.34.1

Re: [PATCH] ARM: dts: qcom: pm8226: Add VADC node

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]

Hi Rayyan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20220207]
[cannot apply to robh/for-next v5.17-rc3 v5.17-rc2 v5.17-rc1 v5.17-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rayyan-Ansari/ARM-dts-qcom-pm8226-Add-VADC-node/20220208-020443
base:    b3c0a155ef77550d48f6eb7c6fdd6075764a5622
config: arm-defconfig (https://download.01.org/0day-ci/archive/20220208/202202081342.ByimNFQM-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bd11e7f38ea0011e6e2d404f5d4f6bb3cbc05aba
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Rayyan-Ansari/ARM-dts-qcom-pm8226-Add-VADC-node/20220208-020443
        git checkout bd11e7f38ea0011e6e2d404f5d4f6bb3cbc05aba
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/qcom-pm8226.dtsi:52.12-13 syntax error
   FATAL ERROR: Unable to parse input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

Re: [PATCH] ARM: dts: qcom: pm8226: Add VADC node

[Rayyan Ansari]

On 2022-02-07 17:49, Rayyan Ansari wrote:
> Add a node for the voltage ADC (VADC) found in PM8226.
> 
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
>  arch/arm/boot/dts/qcom-pm8226.dtsi | 33 ++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index b3d0f7b5874d..a651b4c941b8 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -40,6 +40,39 @@ smbb: charger@1000 {
>  			chg_otg: otg-vbus { };
>  		};
> 
> +		pm8226_vadc: adc@3100 {
> +			compatible = "qcom,spmi-vadc";
> +			reg = <0x3100>;
> +			interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#io-channel-cells = <1>;
> +
> +			adc-chan@7 {
> +				reg = <VADC_VSYS>;
> +				qcom,pre-scaling = <1 3>;
> +				label = "vph_pwr";
> +			};
> +			adc-chan@8 {
> +				reg = <VADC_DIE_TEMP>;
> +				label = "die_temp";
> +			};
> +			adc-chan@9 {
> +				reg = <VADC_REF_625MV>;
> +				label = "ref_625mv";
> +			};
> +			adc-chan@a {
> +				reg = <VADC_REF_1250MV>;
> +				label = "ref_1250mv";
> +			};
> +			adc-chan@e {
> +				reg = <VADC_GND_REF>;
> +			};
> +			adc-chan@f {
> +				reg = <VADC_VDD_VADC>;
> +			};
> +		};
> +
>  		pm8226_mpps: mpps@a000 {
>  			compatible = "qcom,pm8226-mpp", "qcom,spmi-mpp";
>  			reg = <0xa000>;

Ignore this patch, I forgot to include a header.