All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@uclinux.org>
To: Thomas Huth <huth@tuxfamily.org>,
	Laurent Vivier <laurent@vivier.eu>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCHv2] m68k: change default system clock for m5208evb
Date: Thu, 29 Sep 2016 22:39:55 +1000	[thread overview]
Message-ID: <5082bb5b-1fba-c70f-89fc-2177165d4ffc@uclinux.org> (raw)
In-Reply-To: <d1ddd6de-5b17-cad0-f6a1-79ca89896949@tuxfamily.org>

Hi Thomas,

On 29/09/16 17:56, Thomas Huth wrote:
> On 29.09.2016 09:50, Laurent Vivier wrote:
>>
>>
>> Le 28/09/2016 à 02:06, Greg Ungerer a écrit :
>>> The shipping default setting for the Freescale M5208EVB board is to run
>>> the CPU at 166.67MHz. The current qemu emulation code for this board is
>>> defaulting to 66MHz. This results in time appearing to run way to slowly.
>>> So a "sleep 5" in a standard ColdFire Linux build takes almost 15
>>> seconds in real time to actually complete.
>>>
>>> Change the hard coded default to match the default hardware setting.
>>>
>>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>>
>> This solution is as good as another, so:
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
> Fine for me, too, so:
>
> Reviewed-by: Thomas Huth <huth@tuxfamily.org>

Thanks for the review.

Regards
Greg


> By the way, we still do not have a m68k maintainer yet ... Laurent,
> maybe you could finally send a pull request for that patch here:
> https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg00805.html ?
>
> Meanwhile, Peter, could you please take this patch here from Greg
> directly? Or should it go via qemu-trivial instead?
>
>  Thomas
>
>
>>> ---
>>>  hw/m68k/mcf5208.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> v2: more accurately set frequency (166666666 instead of 166000000)
>>>
>>> diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
>>> index 9240ebf..3438314 100644
>>> --- a/hw/m68k/mcf5208.c
>>> +++ b/hw/m68k/mcf5208.c
>>> @@ -21,7 +21,7 @@
>>>  #include "elf.h"
>>>  #include "exec/address-spaces.h"
>>>
>>> -#define SYS_FREQ 66000000
>>> +#define SYS_FREQ 166666666
>>>
>>>  #define PCSR_EN         0x0001
>>>  #define PCSR_RLD        0x0002
>>>
>>
>
>

  parent reply	other threads:[~2016-09-29 12:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28  0:06 [Qemu-devel] [PATCHv2] m68k: change default system clock for m5208evb Greg Ungerer
2016-09-29  7:50 ` Laurent Vivier
2016-09-29  7:56   ` Thomas Huth
2016-09-29  8:02     ` Laurent Vivier
2016-09-29 12:39     ` Greg Ungerer [this message]
2016-09-29 12:27   ` Greg Ungerer
2016-09-29 15:57 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5082bb5b-1fba-c70f-89fc-2177165d4ffc@uclinux.org \
    --to=gerg@uclinux.org \
    --cc=huth@tuxfamily.org \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.