From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp
Date: Mon, 22 Oct 2012 07:26:53 +0200 [thread overview]
Message-ID: <5084D91D.9040003@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1210191757380.2689@kaball.uk.xensource.com>
On 10/19/12 19:02, Stefano Stabellini wrote:
> On Wed, 17 Oct 2012, Gerd Hoffmann wrote:
>> Currently it is inconstent, PixelFormat->amask is left unset whereas
>> abits and amax and ashift are filled. As an alpha channel doesn't make
>> sense for the vga framebuffer leave all alpha fields clear.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Actually the alpha mask was left to 0 on purpose to ignore it.
> At the same time we set amax, ashift and abits to signal the presence of
> an alpha byte in the pixel format.
Hmm? I still don't see t he point of the current mix. Either the byte
is alpha or it is unused ...
cheers,
Gerd
next prev parent reply other threads:[~2012-10-22 5:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 13:29 [Qemu-devel] [PATCH 00/14] pixman patch series Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 01/14] console: remove DisplayAllocator Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 02/14] pixman: add submodule Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 03/14] pixman: windup in configure & makefiles Gerd Hoffmann
2012-10-17 14:26 ` Paolo Bonzini
2012-11-22 12:34 ` Stefano Stabellini
2012-11-22 12:59 ` Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 04/14] pixman: helper functions Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 05/14] pixman: add pixman image to DisplaySurface Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 06/14] console: make qemu_alloc_display static Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp Gerd Hoffmann
2012-10-19 17:02 ` Stefano Stabellini
2012-10-22 5:26 ` Gerd Hoffmann [this message]
2012-10-17 13:29 ` [Qemu-devel] [PATCH 08/14] qxl: stop direct access to DisplaySurface fields Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 09/14] vga: " Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 10/14] pixman: switch screendump function Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 11/14] pixman/vnc: use pixman images in vnc Gerd Hoffmann
2012-10-19 18:04 ` Stefano Stabellini
2012-10-22 5:40 ` Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 12/14] pixman/vnc: remove rgb_prepare_row* functions Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 13/14] pixman/vnc: remove dead code Gerd Hoffmann
2012-10-17 13:29 ` [Qemu-devel] [PATCH 14/14] pixman: drop obsolete fields from DisplaySurface Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5084D91D.9040003@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.