From: Dan Mick <dan.mick@inktank.com>
To: Alex Elder <elder@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] rbd: zero return code in rbd_dev_image_id()
Date: Mon, 22 Oct 2012 10:18:26 -0700 [thread overview]
Message-ID: <50857FE2.5060705@inktank.com> (raw)
In-Reply-To: <508577F5.3020102@inktank.com>
I really feel like we ought to root-cause this before we patch the
kernel client. Something isn't working the way we expect.
On 10/22/2012 09:44 AM, Alex Elder wrote:
> There is a call in rbd_dev_image_id() to rbd_req_sync_exec()
> to get the image id for an image. Despite the "get_id" class
> method only returning 0 on success, I am getting back a positive
> value (I think the number of bytes returned with the call).
>
> That may or may not be how rbd_req_sync_exec() is supposed to
> behave, but zeroing the return value if successful makes it moot
> and makes this path through the code work as desired.
>
> Do the same in rbd_dev_v2_object_prefix().
>
> Signed-off-by: Alex Elder <elder@inktank.com>
> ---
> drivers/block/rbd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index cf5d109..65e9f1f 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -2169,6 +2169,7 @@ static int rbd_dev_v2_object_prefix(struct
> rbd_device *rbd_dev)
> dout("%s: rbd_req_sync_exec returned %d\n", __func__, ret);
> if (ret < 0)
> goto out;
> + ret = 0; /* rbd_req_sync_exec() can return positive */
>
> p = reply_buf;
> rbd_dev->header.object_prefix = ceph_extract_encoded_string(&p,
> @@ -2862,6 +2863,7 @@ static int rbd_dev_image_id(struct rbd_device
> *rbd_dev)
> dout("%s: rbd_req_sync_exec returned %d\n", __func__, ret);
> if (ret < 0)
> goto out;
> + ret = 0; /* rbd_req_sync_exec() can return positive */
>
> p = response;
> rbd_dev->image_id = ceph_extract_encoded_string(&p,
>
next prev parent reply other threads:[~2012-10-22 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 16:43 [PATCH 0/2] rbd: two bugs Alex Elder
2012-10-22 16:44 ` [PATCH 1/2] rbd: zero return code in rbd_dev_image_id() Alex Elder
2012-10-22 17:18 ` Dan Mick [this message]
2012-10-22 20:00 ` Dan Mick
2012-10-24 16:59 ` Josh Durgin
2012-10-22 16:44 ` [PATCH 2/2] rbd: fix read-only option name Alex Elder
2012-10-24 17:02 ` Josh Durgin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50857FE2.5060705@inktank.com \
--to=dan.mick@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.